From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd2a.google.com (mail-io1-xd2a.google.com [IPv6:2607:f8b0:4864:20::d2a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id B41253CB35 for ; Wed, 21 Aug 2019 09:10:13 -0400 (EDT) Received: by mail-io1-xd2a.google.com with SMTP id i22so4405014ioh.2 for ; Wed, 21 Aug 2019 06:10:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=XlSECvjCL/Ci+omZg5ltjDugiRyBqz4JSu6EC7j5vu4=; b=Y3+Y1GxbI2hScLM+JUqKN74cQMVrmZltbj/ZAhocM0YrDfLR8x91FbE3HrywUnnf9N IaTDqafhMuwPYxUigOqBkJhS4ZoRbVtJrMAS+tafmIicx0n1CGzZIJpm6bWJKFoTfikG 5Tdr1i5s/7Xi4DYg2b90vPdpB4r64KdWmrUddajfTVRXT3PeQhLVgwblWy1k/gxk5+MZ Sc8Knvqz0tl5T82at/DgrEAmR7alGRB+1zmHf92L8J5vlCVsvrfDeoIp1b8+P/osWkg/ xbU2atQ3w3c8ImTIwunhX4Lm/mL6o5nzPAGkpKOJAh8YB1kb8KTl5RRER4+gdnYmBjrd Ob8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=XlSECvjCL/Ci+omZg5ltjDugiRyBqz4JSu6EC7j5vu4=; b=WfxmF7zueS3Pv7oV4MtS+u2rb4ugzTPDoo56b8ImbQHhp/CaB54LnTiQYtk5aGDVUe ZbuH8THOLjzSNabK5UK8wBFN0F/xMxYW8ST/MbIyYK1ormaIiy69S761qN5YAGmKkHY4 g33SjLz90W5CxaH9kSr9EWgHhbFwIu8q9qpDwqf2rNi9WavKwoLBqDFdZTPLfaSkGUYF 7FO+YfHlqkICE+/HVnpJJEFqqa8IYuX4sHwxlfQ/DcnWb4JcP7yat4c6HbdEPlASpQwx 6rQlKu/Naka/aA/igY+p8vCR3o7RMAQcVNTdUMg65iy5SJ247d5MAC3gyDZOp4TmzL+b 0JiQ== X-Gm-Message-State: APjAAAUhwVVhKPW+f05kgBHqIvutNcdABkHP2MLG7dQE8LzSwp2VxlQP F+8Rd5++GNvykdhGqODXO1IazW46knqtGQHGy1M= X-Google-Smtp-Source: APXvYqzpwjOZRTtsO7jxK6NZbmo3FIs7E4zUTrwGcwYbVps6C9HcF+xrzq3qb+YxhaxAJ38XWBILBceGC5raY8HibOI= X-Received: by 2002:a6b:cd07:: with SMTP id d7mr35684752iog.150.1566393012991; Wed, 21 Aug 2019 06:10:12 -0700 (PDT) MIME-Version: 1.0 References: <384866b4-4c91-cf2c-c267-ee4036e5fbf7@newmedia-net.de> <87wof7sriw.fsf@toke.dk> <6782ec15-30eb-63b0-f54f-376c5e6b840b@newmedia-net.de> <87tvabsp99.fsf@toke.dk> <74bccc2b-b805-255f-b6a7-83ade9af6765@newmedia-net.de> <87r25fsn70.fsf@toke.dk> <54438C64-C613-438E-9CB9-6C6D0C5EAFA0@gmail.com> <87sgpvflo4.fsf@taht.net> <87wof6rf7t.fsf@toke.dk> In-Reply-To: <87wof6rf7t.fsf@toke.dk> From: Dave Taht Date: Wed, 21 Aug 2019 06:10:01 -0700 Message-ID: To: =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= Cc: Dave Taht , Jonathan Morton , "cake@lists.bufferbloat.net >> Cake List" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [Cake] cake in dd-wrt X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Aug 2019 13:10:13 -0000 On Wed, Aug 21, 2019 at 3:21 AM Toke H=C3=B8iland-J=C3=B8rgensen wrote: > > Dave Taht writes: > > > Jonathan Morton writes: > > > >>> On 20 Aug, 2019, at 9:39 pm, Sebastian Gottschall wrote: > >>> > >>> =E2=80=A6a heavy bittorrent downloader will still steal the bandwidth= of my scp session. > >> > >> If you can identify the Bittorrent packets, you can mark them CS1, and > >> switch on Cake's "diffserv3" mode (as it is by default). Then the > >> Bittorrent packets will still be able to use full bandwidth if it's > >> available, but will be limited to 1/16th of the total if there is > >> contention. > > > > I regard the whole CS1 thing as having never been particularly > > successful for a variety of reasons - in particular because > > we seemed to be the only ones attempting to use it with rigor. > > > > I would like to patch in and submit "LE" support to mainline cake. > > > > The RFC retires CS1 - which I wouldn't retire - but see: > > > > https://www.rfc-editor.org/rfc/rfc8622.html > > Yeah, getting support for that upstream might be a good idea :) I'd put out a patch on a endian-brain-fart day, which I think was correct?, but didn't get back to it. Another cleanup thought is to constify the cake invsqrt cache. (and actuall= y put in totally correct values) > > Also it seems like a good idea to also submit the NS bit > > exclusion from the ack filter to mainline as well. > > What's that? https://github.com/chromi/sce/blob/sce/net/sched/sch_cake.c#L1274 A cleaner way would be to have it be #ifndef TCP_FLAG_ESCE #define it (I forget where it's defined) #endif #define CAKE_FILTER_FLAGS (TCP_FLAG_ECE | TCP_FLAG_CWR | TCP_FLAG_ESCE) and use that. > > -Toke > _______________________________________________ > Cake mailing list > Cake@lists.bufferbloat.net > https://lists.bufferbloat.net/listinfo/cake --=20 Dave T=C3=A4ht CTO, TekLibre, LLC http://www.teklibre.com Tel: 1-831-205-9740