From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk0-x241.google.com (mail-qk0-x241.google.com [IPv6:2607:f8b0:400d:c09::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 6295D3B260 for ; Mon, 19 Sep 2016 16:32:54 -0400 (EDT) Received: by mail-qk0-x241.google.com with SMTP id b204so10551778qkc.1 for ; Mon, 19 Sep 2016 13:32:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:from:date:message-id:subject:to :content-transfer-encoding; bh=ahgY4ikCxptCqbgJ/2cYWlKUziDD1wCb5Sf0izJRIHg=; b=SFgo9GWPY4HFqQ/u8XLrf3RVpXeIfewH9wB++bwwchdG1tAAwPARod5LAl/omQHnHE ZOForwbrb2Z5hfgsGBamHYKleQby2sbbllFZciTTvU2jhDY1ke+4wyOatNHbCfG8YTNT qrvwbJa2wbPPAdoI/AGWhIcbNY6JExjRTaCCoaUsQqHuazrFPBttybGyDi9kRPoE6ZLu rb22YXk39ZTghMW+zNngZBu3THic08yCxI5qL9L/8mhguEpB/C4XM9A5RuJ0Kogfb+SI iAFTIsEB8Wkdp5VIXxVXpFsP/0taZZRrQqCOP+30MG8nB9OB/+oxZfsREAWNTUXNxHDP 3BgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:from:date:message-id:subject:to :content-transfer-encoding; bh=ahgY4ikCxptCqbgJ/2cYWlKUziDD1wCb5Sf0izJRIHg=; b=fGW24PotlnG8ryTTHVxgebLWCP3uQzJV3QAeTGPounZJOl7KDotydaLokjCpgogNW4 E1DBdmtgRCNLXcYTQXCnVQretLLZx0JNJs+8pklsvlkoOtjGde0PqLpaOk8PZoEiartP OL86eIfbKp6iN9T6QRPYzIpykfZ0+dv5op1R2r3OMgo11vNLBReKOBGunvAqGxaeKhzy 2N9LJqtvy3/i0XkJY3UGCQeM4RBOYimdsISOtsIOkYEmXB1LrhF8qtlV+3QsJbkOKso4 XnOtqp9XmyVzizNiSXcfSaF09K+1NU9UercIFR/i2KWYHNgpGu+ceEfYJLBD6p/SVndT cAIA== X-Gm-Message-State: AE9vXwPkHYSBczUVkqO3QB10TLsbQlYxfumeJNzMVhvK/kFjmlJ4XQuXDgbcWsnboZSXT0liOtb147gz684+9Q== X-Received: by 10.55.73.6 with SMTP id w6mr33429652qka.59.1474317173926; Mon, 19 Sep 2016 13:32:53 -0700 (PDT) MIME-Version: 1.0 Received: by 10.12.137.214 with HTTP; Mon, 19 Sep 2016 13:32:53 -0700 (PDT) From: Dave Taht Date: Mon, 19 Sep 2016 13:32:53 -0700 Message-ID: To: cake@lists.bufferbloat.net Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Cake] cake breaks against net-next X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Sep 2016 20:32:54 -0000 there has been an awful lot of work around reworking the qdiscs in the latest linux to eliminate cache hit problems, and locks. This breaks cake, and I'm too deep in wifi to look at it for a while. Jon? It was my hope that cake would defeat the ping spike I saw in http://blog.cerowrt.org/post/bbrs_basic_beauty/ If anyone wants a working bbr patchset that goes on top of net-next, you can find the v2+1 patch here: http://www.taht.net/~d/bbr.tgz . make -C /lib/modules/4.8.0-rc6-toke-6/build SUBDIRS=3D/home/dave/git/sch_cake modules LDFLAGS_MODULE=3D"--build-id=3D0x2371a6a9eec25520382a69b81f6b3ef26161bead" CFLAGS_MODULE=3D"-DCAKE_VERSION=3D\\\"2371a6a9eec25520382a69b81f6b3ef26161b= ead\\\"" make[1]: Entering directory '/usr/src/linux-headers-4.8.0-rc6-toke-6' CC [M] /home/dave/git/sch_cake/sch_cake.o /home/dave/git/sch_cake/sch_cake.c: In function =E2=80=98cake_hash=E2=80=99= : /home/dave/git/sch_cake/sch_cake.c:321:16: error: =E2=80=98struct flow_dissector_key_tags=E2=80=99 has no member named =E2=80=98vlan_id=E2=80= =99 host_keys.tags.vlan_id =3D 0; ^ /home/dave/git/sch_cake/sch_cake.c: In function =E2=80=98cake_enqueue=E2=80= =99: /home/dave/git/sch_cake/sch_cake.c:697:11: error: implicit declaration of function =E2=80=98qdisc_reshape_fail=E2=80=99 [-Werror=3Dimplicit-function-declaration] return qdisc_reshape_fail(skb, sch); ^ In file included from /home/dave/git/sch_cake/cobalt.c:50:0, from /home/dave/git/sch_cake/sch_cake.c:59: /home/dave/git/sch_cake/sch_cake.c: In function =E2=80=98cake_dequeue=E2=80= =99: /home/dave/git/sch_cake/cobalt.h:59:45: error: too many arguments to function =E2=80=98qdisc_watchdog_schedule_ns=E2=80=99 #define codel_watchdog_schedule_ns(a, b, c) qdisc_watchdog_schedule_ns(a, = b, c) ^ /home/dave/git/sch_cake/sch_cake.c:862:3: note: in expansion of macro =E2=80=98codel_watchdog_schedule_ns=E2=80=99 codel_watchdog_schedule_ns(&q->watchdog, q->time_next_packet, ^ In file included from /home/dave/git/sch_cake/cobalt.c:45:0, from /home/dave/git/sch_cake/sch_cake.c:59: ./include/net/pkt_sched.h:70:6: note: declared here void qdisc_watchdog_schedule_ns(struct qdisc_watchdog *wd, u64 expires); ^ /home/dave/git/sch_cake/sch_cake.c:1002:3: error: too few arguments to function =E2=80=98qdisc_drop=E2=80=99 qdisc_drop(skb, sch); ^ In file included from ./include/net/pkt_sched.h:7:0, from /home/dave/git/sch_cake/cobalt.c:45, from /home/dave/git/sch_cake/sch_cake.c:59: ./include/net/sch_generic.h:746:19: note: declared here static inline int qdisc_drop(struct sk_buff *skb, struct Qdisc *sch, ^ /home/dave/git/sch_cake/sch_cake.c: At top level: /home/dave/git/sch_cake/sch_cake.c:1813:13: error: initialization from incompatible pointer type [-Werror=3Dincompatible-pointer-types] .enqueue =3D cake_enqueue, ^ /home/dave/git/sch_cake/sch_cake.c:1813:13: note: (near initialization for =E2=80=98cake_qdisc_ops.enqueue=E2=80=99) /home/dave/git/sch_cake/sch_cake.c:1816:2: error: unknown field =E2=80=98dr= op=E2=80=99 specified in initializer .drop =3D cake_drop, ^ /home/dave/git/sch_cake/sch_cake.c:1816:11: error: initialization from incompatible pointer type [-Werror=3Dincompatible-pointer-types] .drop =3D cake_drop, ^ /home/dave/git/sch_cake/sch_cake.c:1816:11: note: (near initialization for =E2=80=98cake_qdisc_ops.init=E2=80=99) --=20 Dave T=C3=A4ht Let's go make home routers and wifi faster! With better software! http://blog.cerowrt.org