From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ob0-x230.google.com (mail-ob0-x230.google.com [IPv6:2607:f8b0:4003:c01::230]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by huchra.bufferbloat.net (Postfix) with ESMTPS id 7D19621F71C for ; Mon, 12 Oct 2015 05:04:18 -0700 (PDT) Received: by obbda8 with SMTP id da8so105207180obb.1 for ; Mon, 12 Oct 2015 05:04:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=o2rXngfcr6k3kmMxj1qyLVbkKZxSrVjvtV992mDCY8o=; b=EpT8KDrsMbs12TQ/AhlQV8cAoxV6CS9kLOuXLC6jzyVWMupPvRh4BBEP0ZOtuMIr+K dQQbh9bkbi0QQ72O0m4omhlSGvxwzG2LX6BWvoBg+Xulu9hdvtmia6r2cnRkkw8J5CRV G8J6EO/mjtTi+8fYy5M0q00GHGeulfQSLuhpO+Ep5HhbUjCq/9NiFqcczlfuYpfwAkQ1 L7r0LnmCK62y/uz0b4Xe2O2i4x1rd3Z8y680u2FbtQK75y/88hHMkjRzGX4VILiHJLVt YRt2C93vtCVu7bfimOELWURcd0BFPFAcavUOekDN2nz32B/UyETPU6e48wyL8UuL1ELU CqUg== MIME-Version: 1.0 X-Received: by 10.60.41.9 with SMTP id b9mr15359083oel.37.1444651457913; Mon, 12 Oct 2015 05:04:17 -0700 (PDT) Received: by 10.202.108.212 with HTTP; Mon, 12 Oct 2015 05:04:17 -0700 (PDT) In-Reply-To: References: <20FAC204-CAA3-4E36-938A-E857EE81C0A3@gmx.de> Date: Mon, 12 Oct 2015 14:04:17 +0200 Message-ID: From: Dave Taht To: Sebastian Moeller Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: cake@lists.bufferbloat.net, dtaht/sch_cake , dtaht/sch_cake Subject: Re: [Cake] [sch_cake] Merge branch 'exposeinterval' (5541271) X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.13 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Oct 2015 12:04:43 -0000 sigh. In looking this code over again, interval is a 64 bit value in nsec in our version of codel, and needs no conversion into usec. It also seems to imply that all the conversion values are wrong throughout the code, and the api should expose a 64 bit value. On Mon, Oct 12, 2015 at 1:49 PM, Sebastian Moeller wrote: > Hi Dave, > > > On Oct 12, 2015, at 13:16 , Dave Taht wrote: > >> um, no, interval needs to be kept in usec, and converted more like I did= . > > I have not looked at your code yet. In tc (tc_utils.h or so) ther= e is get_time() that knows how to deal with the default time specifiers lik= e sec ms us=E2=80=A6 I believe from the tc side this should be used to pars= e the user input, just like Kevin=E2=80=99s code does. Now this needs to be= passed to sch_cake.c, where I believe Kevin=E2=80=99s version expects mill= iseconds (MS2TIME(q->interval)), which does not do the right thing if the u= ser specified =E2=80=9Crtf 123usecs=E2=80=9D on tic=E2=80=99s cli=E2=80=A6 = So just getting rid of the MS2TIME called should do the trick, no? > > Best Regards > Sebastian > >> >> On Mon, Oct 12, 2015 at 2:36 AM, Dave Taht wrote: >>> On Mon, Oct 12, 2015 at 11:28 AM, Jonathan Morton wrote: >>>> >>>>> On 12 Oct, 2015, at 12:24, Dave Taht wrote: >>>>> >>>>> This is incorrect for the DC use case. We should be able to have the >>>>> target fall below at least 250us. >>>> >>>> Hey, I=E2=80=99m trying to work on this myself, but the code keeps cha= nging under me. >>> >>> Tough. Deal with it. :) Once the rtt option works right toke and I can >>> finally go test the >>> count/2 idea out properly in the testbed, like, today. You otherwise >>> have the pen, >>> as far as I am concerned. >>> >>>> >>>> - Jonathan Morton >>>> >>> >>> >>> >>> -- >>> Dave T=C3=A4ht >>> Do you want faster, better, wifi? https://www.patreon.com/dtaht >> >> >> >> -- >> Dave T=C3=A4ht >> Do you want faster, better, wifi? https://www.patreon.com/dtaht > --=20 Dave T=C3=A4ht Do you want faster, better, wifi? https://www.patreon.com/dtaht