From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi0-x22f.google.com (mail-oi0-x22f.google.com [IPv6:2607:f8b0:4003:c06::22f]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by huchra.bufferbloat.net (Postfix) with ESMTPS id BDB4E21F4ED for ; Tue, 17 Nov 2015 02:12:03 -0800 (PST) Received: by oixx65 with SMTP id x65so2057023oix.0 for ; Tue, 17 Nov 2015 02:12:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=eOfUO/Eb5ULYTuzsB/4xchAJQbfuLbOc3fBb6k5wrT8=; b=aZiA8GDoPq4DJjYqMU7IX/amptyn6NTAqrnVQuphneP1sf+xpr+WkQYjFNk/lJDkj4 EYnaV307twkV/8++Peg5vYKl+JhAtaP9Ia8xhhXSxpMEnnwrq/YsSAJydxfFX/8mSAjF 6m++NzcOlN9FVXPRXcubNe9PQgw6m/hHpX0zOcVRreyz6lc7pDmoVluGQGEIG/FDSXtR 86yQ6V+W31MkZiqK6c6ZJxgBDWJM2OnvtwVhofP25cwTTk+ZggMYEykeCywdy+mS+5st Zwp3hTqYZVNld6iou57AuUy+59r3cVGPEK7FRS0fhQKWkxXavb9kftszf7JgLUCyRvYT zCkQ== MIME-Version: 1.0 X-Received: by 10.202.83.74 with SMTP id h71mr23247722oib.32.1447755122514; Tue, 17 Nov 2015 02:12:02 -0800 (PST) Received: by 10.202.50.130 with HTTP; Tue, 17 Nov 2015 02:12:02 -0800 (PST) In-Reply-To: <564A3804.2040306@darbyshire-bryant.me.uk> References: <56420697.9080606@darbyshire-bryant.me.uk> <5649EF39.3060300@darbyshire-bryant.me.uk> <5649F423.40000@darbyshire-bryant.me.uk> <564A169D.1060307@darbyshire-bryant.me.uk> <564A1C6D.3050303@darbyshire-bryant.me.uk> <1265B943-4AB3-4AF4-9389-71CA46801A69@gmx.de> <564A23C7.5050108@darbyshire-bryant.me.uk> <564A3804.2040306@darbyshire-bryant.me.uk> Date: Tue, 17 Nov 2015 11:12:02 +0100 Message-ID: From: Dave Taht To: Kevin Darbyshire-Bryant Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: cake@lists.bufferbloat.net Subject: Re: [Cake] Announce - possible new feature - DSCP cleaning X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.13 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Nov 2015 10:12:26 -0000 we can break anything until it goes upstream. I'm not satisified with the api (or wasn't 2 months back).... Dave T=C3=A4ht Let's go make home routers and wifi faster! With better software! https://www.gofundme.com/savewifi On Mon, Nov 16, 2015 at 9:09 PM, Kevin Darbyshire-Bryant wrote: > It is pushed but in a 'squash' branch for review purposes before it gets > merged into master. > > Let me ask things in a different way, and as I've had time to think > about the implications of these changes: By changing how 'squash' is > enabled I've currently broken backwards compatibility between 'new > squash' cake and 'old squash' tc. Now, bearing in mind that this isn't > upstream yet...how concerned are we/should I be for 'new cake' vs 'old > tc' compatibility? Again having thought about it more, I'm pretty sure > I can make 'new cake' and 'old tc' work....is it worth the bother? > > Kevin > > On 16/11/15 18:47, Dave Taht wrote: >> push it then. >> Dave T=C3=A4ht >> Let's go make home routers and wifi faster! With better software! >> https://www.gofundme.com/savewifi >> >> >> On Mon, Nov 16, 2015 at 7:43 PM, Kevin Darbyshire-Bryant >> wrote: >>> >>> On 16/11/15 18:35, Dave Taht wrote: >>>> switch (q->tin_mode) { case CAKE_MODE_SQUASH: case >>>> CAKE_MODE_BESTEFFORT: default: cake_config_besteffort(sch); break; >>>> >>>> ? >>>> Dave T=C3=A4ht >>>> Let's go make home routers and wifi faster! With better software! >>>> https://www.gofundme.com/savewifi >>>> >>> Are you sure you're looking at the 'squash' branch Dave? The 'smarts' >>> of automatically selecting 'besteffort' in the presence of 'squash' has >>> been put into 'tc'. Thus 'squash' on its own behaves as it always did >>> for backwards compatibility. 'squash' in combination with >>> 'diffserv4/precedence' etc also works as expected. >>> >>> There's also a 'nosquash' option to disable squashing on a 'tc change' >>> if required. That code now looks like: >>> >>> switch (q->tin_mode) { >>> case CAKE_MODE_BESTEFFORT: >>> default: >>> cake_config_besteffort(sch); >>> break; >>> ........ >>> >>> >>> >>> >>> >>> > >