From: Dave Taht <dave.taht@gmail.com>
To: Pete Heist <peteheist@gmail.com>
Cc: Cake List <cake@lists.bufferbloat.net>
Subject: Re: [Cake] small cake_hash optimization?
Date: Wed, 22 Nov 2017 10:33:20 -0800 [thread overview]
Message-ID: <CAA93jw7pJESFowu28tC3yruQca1OTU=0GO4z-oSTvyBeksFwKg@mail.gmail.com> (raw)
In-Reply-To: <E902BF37-55F7-4295-9055-945CBC6E2226@gmail.com>
On Wed, Nov 22, 2017 at 4:37 AM, Pete Heist <peteheist@gmail.com> wrote:
>
> On Nov 22, 2017, at 11:06 AM, Pete Heist <peteheist@gmail.com> wrote:
>
> I’ve not done any testing on what the real impact of this change would be,
> or even if it breaks something.
>
>
> Ok, at least a little crude testing with sar:
>
> https://docs.google.com/spreadsheets/d/1LKoq5NaswuHm9H1atXoZA1AhNDg6L4UYS3Pn5lCsb1I/edit#gid=0
>
> ~10% less cake CPU at GigE in this case?
Divides do hurt, particularly if you can't do them out of order. But
that seems like a lot.
> What’s a better tool for timing
> kernel module functions?
Use "perf"
https://en.wikipedia.org/wiki/Perf_(Linux)
>
> Would really need to test if host fairness still works, otherwise this is
> irrelevant…
>
>
> _______________________________________________
> Cake mailing list
> Cake@lists.bufferbloat.net
> https://lists.bufferbloat.net/listinfo/cake
>
--
Dave Täht
CEO, TekLibre, LLC
http://www.teklibre.com
Tel: 1-669-226-2619
next prev parent reply other threads:[~2017-11-22 18:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-22 10:06 Pete Heist
2017-11-22 12:37 ` Pete Heist
2017-11-22 13:51 ` Sebastian Moeller
2017-11-22 18:33 ` Dave Taht [this message]
2017-11-22 18:43 ` Pete Heist
2017-11-23 8:00 ` Sebastian Moeller
2017-11-23 9:30 ` Pete Heist
2017-11-23 9:36 ` Pete Heist
2017-11-23 16:21 ` Dave Taht
2017-11-23 16:48 ` Sebastian Moeller
2017-11-23 16:57 ` Dave Taht
2017-11-23 10:22 ` Sebastian Moeller
2017-11-22 18:38 ` Dave Taht
2017-11-22 18:49 ` Pete Heist
2017-11-22 21:19 ` Pete Heist
2017-11-22 21:26 ` Dave Taht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAA93jw7pJESFowu28tC3yruQca1OTU=0GO4z-oSTvyBeksFwKg@mail.gmail.com' \
--to=dave.taht@gmail.com \
--cc=cake@lists.bufferbloat.net \
--cc=peteheist@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox