From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk0-x231.google.com (mail-qk0-x231.google.com [IPv6:2607:f8b0:400d:c09::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id F0A413B29E for ; Wed, 22 Nov 2017 13:33:21 -0500 (EST) Received: by mail-qk0-x231.google.com with SMTP id w125so18004479qkb.6 for ; Wed, 22 Nov 2017 10:33:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Wbxu7XuIoqMXjBnBAqwAhzIAKRqhvjlhsrht2SIMmFc=; b=k5CUmLbPphE+Ee89N0der0ieZKZjxCagy76ugnZo+xUFc4i8NwSl8gRtP+TQpYBi/m E4/r5gt2Ti6StK237y3lzuzlvgd8zWa1maPyHyfu69HRQ0o0oaTe3k1B1XeLzk1eymM7 oL2ww6qpmSsDAEZvKsWgx3HhEidNMG9t49QiIl7AuhiuFAtQ4AZTf1q1HoBdWOk62zxN Apx3BSc/erPlAOPTF85hulvUXBVPqkgzLVow6TL5pEFbj68pyBmzZOQBOksIGRBsCUA2 lSeO0TFY10eXcL5dvLG79z3D0swhTbL3fD0YBtPc1SGZJUIxD+roau4nbLeu7LmvbV1Y 0qxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Wbxu7XuIoqMXjBnBAqwAhzIAKRqhvjlhsrht2SIMmFc=; b=ezPaI5gYOlLnhwT+ovUe/KRUIWTK9rGIYVYwhAq1SHxE6GOw8VVOZj9vRsWxerL/e3 Wd2i4SpgE7ko5ord9bxgH6brgsLY8SZwQKwsR4sfp7rbAgTebx8116DCcV35jtvB4bww 5kcgsT5UdCzzoqZcmmNrtmgf+NFgFKqERVX2U9vP4NZPHLj7IxFZqUQZ4cVmlPIzDHdi FjW3XuzkVLE75evRAOzMxCFekZLoiIHk49oe6Cp97J1DPvKmHhKi0OM468Hu8bpfnBq/ D7Z05xxCizHkJc6q7iYHVV7iQ1/pPOQFmYr2xHupi6W2XWH6s/EF1YAptt57ur/A6w0n j8kw== X-Gm-Message-State: AJaThX46Mi+InR/tZuVrOHX2ITzw+Hfqjr8JFK2uiKaO+Esqg3vrTpaz hCQzoIWF07XsqxyzoXbm40s79/n8ecKxbRiyJRE5Ig== X-Google-Smtp-Source: AGs4zMbuyquNk7d98955+u+62heVGUzufYqpOGSentOzTJ3W6XnYlReeVQnA9LeVFIc7DyiHlYdebK9xN5eSDueWpvM= X-Received: by 10.55.201.155 with SMTP id m27mr11551774qkl.299.1511375601397; Wed, 22 Nov 2017 10:33:21 -0800 (PST) MIME-Version: 1.0 Received: by 10.12.193.93 with HTTP; Wed, 22 Nov 2017 10:33:20 -0800 (PST) In-Reply-To: References: <107CB879-B196-40F1-A7C2-08B963B7A835@gmail.com> From: Dave Taht Date: Wed, 22 Nov 2017 10:33:20 -0800 Message-ID: To: Pete Heist Cc: Cake List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [Cake] small cake_hash optimization? X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Nov 2017 18:33:22 -0000 On Wed, Nov 22, 2017 at 4:37 AM, Pete Heist wrote: > > On Nov 22, 2017, at 11:06 AM, Pete Heist wrote: > > I=E2=80=99ve not done any testing on what the real impact of this change = would be, > or even if it breaks something. > > > Ok, at least a little crude testing with sar: > > https://docs.google.com/spreadsheets/d/1LKoq5NaswuHm9H1atXoZA1AhNDg6L4UYS= 3Pn5lCsb1I/edit#gid=3D0 > > ~10% less cake CPU at GigE in this case? Divides do hurt, particularly if you can't do them out of order. But that seems like a lot. > What=E2=80=99s a better tool for timing > kernel module functions? Use "perf" https://en.wikipedia.org/wiki/Perf_(Linux) > > Would really need to test if host fairness still works, otherwise this is > irrelevant=E2=80=A6 > > > _______________________________________________ > Cake mailing list > Cake@lists.bufferbloat.net > https://lists.bufferbloat.net/listinfo/cake > --=20 Dave T=C3=A4ht CEO, TekLibre, LLC http://www.teklibre.com Tel: 1-669-226-2619