From: Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk>
To: "Toke Høiland-Jørgensen" <toke@toke.dk>
Cc: "cake@lists.bufferbloat.net" <cake@lists.bufferbloat.net>
Subject: Re: [Cake] Fixing iproute2 compile
Date: Mon, 19 Oct 2015 16:31:31 +0000 [thread overview]
Message-ID: <CACB7BB7-8F71-492B-A55A-B7215FDFFA89@darbyshire-bryant.me.uk> (raw)
In-Reply-To: <87d1wavoe7.fsf@toke.dk>
[-- Attachment #1.1: Type: text/plain, Size: 1300 bytes --]
That fix has already been committed. Or something darn close to it https://kau.toke.dk/git/cake/iproute2/commit/?id=ef1bbd6718c7c2d30814d5b1e3ee6882a668b6d8
--
Cheers,
Kevin@Darbyshire-Bryant.me.uk
Sent from my phone, apologies for brevity, spelling & top posting
> On 19 Oct 2015, at 17:01, Toke Høiland-Jørgensen <toke@toke.dk> wrote:
>
> So finally got iproute2 to compile out of the kau.toke.dk repo. The
> patch below was needed to cake. Posting it here rather than just
> committing in the hope of getting someone (Jonathan?) to take a look at
> it and fix it everywhere it's needed :)
>
> -Toke
>
> diff --git a/tc/q_cake.c b/tc/q_cake.c
> index 4d64405..1384a46 100644
> --- a/tc/q_cake.c
> +++ b/tc/q_cake.c
> @@ -495,7 +496,7 @@ static int cake_print_xstats(struct qdisc_util *qu, FILE *f,
>
> } else if (stnc->version >= 1 && stnc->version < 0xFF
> && stnc->max_tins == TC_CAKE_MAX_TINS
> - && RTA_PAYLOAD(xstats) >= offsetof(*stnc, capacity_estimate))
> + && RTA_PAYLOAD(xstats) >= offsetof(typeof(*stnc), capacity_estimate))
> {
> int i;
>
> _______________________________________________
> Cake mailing list
> Cake@lists.bufferbloat.net
> https://lists.bufferbloat.net/listinfo/cake
[-- Attachment #1.2: Type: text/html, Size: 2418 bytes --]
[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 3062 bytes --]
next prev parent reply other threads:[~2015-10-19 16:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-19 16:01 Toke Høiland-Jørgensen
2015-10-19 16:31 ` Kevin Darbyshire-Bryant [this message]
2015-10-20 15:33 ` Toke Høiland-Jørgensen
2015-10-19 16:41 ` Kevin Darbyshire-Bryant
2015-10-19 21:17 ` Kevin Darbyshire-Bryant
2015-10-20 9:13 ` Kevin Darbyshire-Bryant
2015-10-20 15:38 ` Toke Høiland-Jørgensen
2015-10-21 10:31 ` Kevin Darbyshire-Bryant
2015-10-21 11:38 ` Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACB7BB7-8F71-492B-A55A-B7215FDFFA89@darbyshire-bryant.me.uk \
--to=kevin@darbyshire-bryant.me.uk \
--cc=cake@lists.bufferbloat.net \
--cc=toke@toke.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox