Cake - FQ_codel the next generation
 help / color / mirror / Atom feed
From: Georgios Amanakis <gamanakis@gmail.com>
To: "Toke Høiland-Jørgensen" <toke@toke.dk>
Cc: Cake List <cake@lists.bufferbloat.net>, netdev@vger.kernel.org
Subject: Re: [Cake] [PATCH net-next v2] Add Common Applications Kept Enhanced (cake) qdisc
Date: Tue, 24 Apr 2018 11:32:00 -0400	[thread overview]
Message-ID: <CACvFP_hEv_cEPKFxz+7X5mvwbM+4oTOAxMcW52b51qYUpez1ow@mail.gmail.com> (raw)
In-Reply-To: <20180424081406.5127f1bc@xeon-e3>

On Tue, 24 Apr 2018 13:44:06 +0200
Toke Høiland-Jørgensen <toke@toke.dk> wrote:

> +config NET_SCH_CAKE
> +       tristate "Common Applications Kept Enhanced (CAKE)"
> +       help
> +         Say Y here if you want to use the Common Applications Kept Enhanced
> +          (CAKE) queue management algorithm.
> +
> +         To compile this driver as a module, choose M here: the module
> +         will be called sch_cake.

In net/sched/Kconfig we should probably add NF_CONNTRACK as a dependency:
"depends on NF_CONNTRACK"

Otherwise if NET_SCH_CAKE=y and NF_CONNTRACK=m compilation fails with:

net/sched/sch_cake.o: In function `cake_enqueue':
sch_cake.c:(.text+0x3e10): undefined reference to `nf_ct_get_tuplepr'
sch_cake.c:(.text+0x3e3a): undefined reference to `nf_conntrack_find_get'
make: *** [Makefile:1041: vmlinux] Error 1

  reply	other threads:[~2018-04-24 15:32 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-03 22:06 [Cake] [PATCH net-next 0/3] " Dave Taht
2017-12-03 22:06 ` [Cake] [PATCH net-next 1/3] pkt_sched.h: add support for sch_cake API Dave Taht
2017-12-03 22:06 ` [Cake] [PATCH net-next 2/3] Add Common Applications Kept Enhanced (cake) qdisc Dave Taht
2017-12-03 22:06 ` [Cake] [PATCH net-next 3/3] Add support for building the new cake qdisc Dave Taht
     [not found]   ` <201712051010.18kFjMiy%fengguang.wu@intel.com>
2017-12-05  4:48     ` Dave Taht
2018-04-24 11:44 ` [Cake] [PATCH net-next v2] Add Common Applications Kept Enhanced (cake) qdisc Toke Høiland-Jørgensen
2018-04-24 11:44   ` [Cake] [PATCH iproute2-next v2] Add support for cake qdisc Toke Høiland-Jørgensen
2018-04-24 12:30     ` [Cake] [PATCH iproute2-next v3] " Toke Høiland-Jørgensen
2018-04-24 14:44       ` Stephen Hemminger
2018-04-24 14:45       ` Stephen Hemminger
2018-04-24 14:52         ` Toke Høiland-Jørgensen
2018-04-24 15:10           ` Stephen Hemminger
2018-04-24 15:38             ` Toke Høiland-Jørgensen
2018-04-24 15:11   ` [Cake] [PATCH net-next v2] Add Common Applications Kept Enhanced (cake) qdisc Stephen Hemminger
2018-04-24 15:14   ` Stephen Hemminger
2018-04-24 15:32     ` Georgios Amanakis [this message]
2018-04-24 15:41       ` Toke Høiland-Jørgensen
     [not found]         ` <CACvFP_hzHY+=qPh6_=_++UhbnAU1xjPguY7fNzG0TSVhYm0V3Q@mail.gmail.com>
2018-04-24 15:51           ` Georgios Amanakis
2018-04-24 16:03             ` Toke Høiland-Jørgensen
2018-04-26 19:16   ` kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACvFP_hEv_cEPKFxz+7X5mvwbM+4oTOAxMcW52b51qYUpez1ow@mail.gmail.com \
    --to=gamanakis@gmail.com \
    --cc=cake@lists.bufferbloat.net \
    --cc=netdev@vger.kernel.org \
    --cc=toke@toke.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox