From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-x241.google.com (mail-lf0-x241.google.com [IPv6:2a00:1450:4010:c07::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 7FA083B29E for ; Tue, 24 Apr 2018 11:32:02 -0400 (EDT) Received: by mail-lf0-x241.google.com with SMTP id g203-v6so20944801lfg.11 for ; Tue, 24 Apr 2018 08:32:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=28YXFR8eRSTcOCMYoX7SqhY9NGi/CNhbBnKEbzskerM=; b=jgzpvigpnvfqXTFdKCH8f2ypiCqhbCvH8U/bhgBq5I9Gve3kkKxuu9HQquy1lfJTW+ AiwRiXOPWi2li6f2TlFayo4ORT1tmw3X6ANjJGxAqZhycpDrbuwoWMfTwZBBIDJpBXRx D4OJ5ZbpaxVXPnI78LE8C3QQq78d76uK+lnoE1M/beG3DIevM8qA/NqUqfUuhKWpjseS 6xEBdGt1dJrGJ5ZCnxJcqHczTMq6xu+8RSwP9sxcQe7mqajCL5Hq+DXKuezeYs02rG6v 04PYtxyTUj50WkbEMT3J10c+cXsNz2lnHQ+Xl4dlq7yuPjByHGBqPsKNu7wTlKub9CEF sD/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=28YXFR8eRSTcOCMYoX7SqhY9NGi/CNhbBnKEbzskerM=; b=Mu82z2dL7kvQrSssZbTz/Z3GNHEtWWN2evvq2nO8tG84k2uxt2JmT8//gGtburd/aL yOCoBSOxw5o0z581WOZbk7ypUrMJnlt+scJb6pmJVfTA6I0tH/XNelf2+u2knWb2xqAI l/E160QibpEjoDTcZk2zAeyfnoRIBeBHDMj7vZysRkcvq1aNlNnsICtwWtS9TAA9vQoZ QZ8A6wQ48lHMORoI0dDjQySdBLIpGtpuz7jgUWPy7HZUngRyisQWIdbYwoc1OPuAF5ds MYW5wIAKQvDtcG3LFFNMWxNk2pVDAsbEDCLc8lFd91x/IUdR+tKn9aufwV9T4v6WpMtN zrYQ== X-Gm-Message-State: ALQs6tCU33uw2mq8ZYCM14ZpEEpTRAFbE1YLUPHoP6joWm08TK5ora4q hqxDs+6wM0D9158rYwnbb1Azhd0jxM4Cu8xcRUo= X-Google-Smtp-Source: AIpwx4/vGhT37oXzxPMO7A7Wp2fREQeL+bg3mMt7EjUCcGz4Z2w6sspxmWUvi+4kWWDPDgKp5FRrfdWv8ZQ/eHnxKKI= X-Received: by 10.46.146.204 with SMTP id k12mr10782071ljh.101.1524583920778; Tue, 24 Apr 2018 08:32:00 -0700 (PDT) MIME-Version: 1.0 Received: by 10.46.156.139 with HTTP; Tue, 24 Apr 2018 08:32:00 -0700 (PDT) In-Reply-To: <20180424081406.5127f1bc@xeon-e3> References: <1512338775-3270-1-git-send-email-dave.taht@gmail.com> <20180424114407.5939-1-toke@toke.dk> <20180424081406.5127f1bc@xeon-e3> From: Georgios Amanakis Date: Tue, 24 Apr 2018 11:32:00 -0400 Message-ID: To: =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= Cc: Cake List , netdev@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [Cake] [PATCH net-next v2] Add Common Applications Kept Enhanced (cake) qdisc X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Apr 2018 15:32:02 -0000 On Tue, 24 Apr 2018 13:44:06 +0200 Toke H=C3=B8iland-J=C3=B8rgensen wrote: > +config NET_SCH_CAKE > + tristate "Common Applications Kept Enhanced (CAKE)" > + help > + Say Y here if you want to use the Common Applications Kept Enha= nced > + (CAKE) queue management algorithm. > + > + To compile this driver as a module, choose M here: the module > + will be called sch_cake. In net/sched/Kconfig we should probably add NF_CONNTRACK as a dependency: "depends on NF_CONNTRACK" Otherwise if NET_SCH_CAKE=3Dy and NF_CONNTRACK=3Dm compilation fails with: net/sched/sch_cake.o: In function `cake_enqueue': sch_cake.c:(.text+0x3e10): undefined reference to `nf_ct_get_tuplepr' sch_cake.c:(.text+0x3e3a): undefined reference to `nf_conntrack_find_get' make: *** [Makefile:1041: vmlinux] Error 1