From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt0-x233.google.com (mail-qt0-x233.google.com [IPv6:2607:f8b0:400d:c0d::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 907373CB56 for ; Thu, 8 Mar 2018 13:32:09 -0500 (EST) Received: by mail-qt0-x233.google.com with SMTP id l25so7865778qtj.1 for ; Thu, 08 Mar 2018 10:32:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Q6/uAtLYvI6DRgGRNotR1Xd7toJxyNGRoCI2rght4wE=; b=Qfla2bIjeZpjxuwb7m+8QFK8MxH43pdN/JO/u7pmK5dSWLZt5d/yCcx3zPVSFDaygg oKc0cAHDQvwwGEv3+zPTHxqfVhJFD5hIJF8/adkM3Y5DMIpi+hASFT6AHGt06MasZ2+s dyGg2c46zS242bmomEQ4k4RbkC2ZhjXzpM5yxtbu1L7xDXvCLhYoDKyPMjzeQ5SGXYtI TydWxQXebPZhWwKEUFzZNkd7SesDcPFCmc+R7JcobGlPqXHEkm90ja1Ysgbhx7M9szi6 GxaGtSvKKbsPsKSy6UfCL8+XxAzRoAuilsUnBp9D4pTXm//IigQyT3CJP38q4mJtTRdC flXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Q6/uAtLYvI6DRgGRNotR1Xd7toJxyNGRoCI2rght4wE=; b=DndBok9E6I47jkMfCS28/l/SsW4Xw9fuuZLBF2gD+Q4GYC468lSzdSrPUjcGMARsfA wsinuXPRLBhDJw+PLVAZVtcVA4qCdHEx5TBRZXHgzvCMshVbAXW2gJ9/uDFlsd9u1ZuY HmJFi+KxV5tEt0fMgAxc6H4JCwLzW7KWURgoy7qrYh8cRmVAaP/fsvQ8XcqFBspGSc3J UD6DNMWrholsCSGO0Ykmzd06qeei8S6OZKCOiWdOyV+EHSctQ4vjr9LjMBOBvR3C8658 qwsxQwNdSSGGWx50kExYhzDyX3Lx16/2mx6VWk9Z6skC2pGs/YqTeVga0QjzabKE6rVN 2Nbw== X-Gm-Message-State: AElRT7F5tqdaAFuTNC5FOzIhZtWEbESNw4fsaks0EdCrNH3m1Tm0O3wz aNHlzxPpNkp8Rwy2Utcb5i7/K/ryMQ+l0oc/Rrc= X-Google-Smtp-Source: AG47ELuxgJDUolQ9ap2klc1pCKwERba/iUG3DdpU8tDS8IApSPB9ZjHN79E4DMzAj1Q1m/8m8dAzQGGYMekn2NDLhEA= X-Received: by 10.200.41.139 with SMTP id 11mr41666661qts.247.1520533928877; Thu, 08 Mar 2018 10:32:08 -0800 (PST) MIME-Version: 1.0 Received: by 10.140.42.86 with HTTP; Thu, 8 Mar 2018 10:32:08 -0800 (PST) In-Reply-To: <87po4e24ph.fsf@toke.dk> References: <20180127130542.25817-1-toke@toke.dk> <876068nccm.fsf@toke.dk> <0A156FD3-4816-462C-952B-7938EF8C0EA3@gmail.com> <87sh9cl15n.fsf@toke.dk> <879005B6-2334-4F46-9922-4BC2CACBF107@darbyshire-bryant.me.uk> <87vae8yy68.fsf@toke.dk> <87sh9cyxy9.fsf@toke.dk> <340269AF-2325-4657-8939-5E3195D1C0DC@darbyshire-bryant.me.uk> <87muzkyvj7.fsf@toke.dk> <11DDD9A0-BBD7-4DAA-ACE1-EB88CDC26E7C@darbyshire-bryant.me.uk> <87h8psyraq.fsf@toke.dk> <6F0B516E-3244-4A93-8762-3EAF3BD71BF2@darbyshire-bryant.me.uk> <87k1unlgck.fsf@toke.dk> <4654DB0C-74E6-46FB-9F62-119076D0A20B@darbyshire-bryant.me.uk> <87371a3ljk.fsf@toke.dk> <87sh9a25ta.fsf@toke.dk> <8B3F5A39-852D-41CE-B623-C65FCBA037FF@darbyshire-bryant.me.uk> <04044BF0-504A-41DC-8F1B-A9528B4E887A@darbyshire-bryant.me.uk> <87po4e24ph.fsf@toke.dk> From: Georgios Amanakis Date: Thu, 8 Mar 2018 13:32:08 -0500 Message-ID: To: =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= Cc: Stephen Hemminger , "cake@lists.bufferbloat.net" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Mar 2018 18:32:09 -0000 I am currently testing on my router, Archlinux with kernels 4.14.24/4.15.7, sch_cake from cobalt and tc-adv but it is behaving as it should: =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D8<=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D qdisc cake 8001: dev ens4 root refcnt 2 bandwidth 12200Kbit besteffort dual-dsthost wash ingress rtt 100.0ms noatm overhead 18mpu 64 Sent 950929 bytes 4293 pkt (dropped 2, overlimits 641 requeues 0) backlog 0b 0p requeues 0 memory used: 44528b of 4Mb capacity estimate: 12200Kbit min/max transport layer size: 28 / 1500 min/max overhead-adjusted size: 64 / 1518 average transport hdr offset: 14 qdisc cake 8002: dev ens3 root refcnt 2 bandwidth 2500Kbit besteffort dual-srchost nat wash ack-filter rtt 100.0ms noatm overhead 18mpu 64 Sent 254423 bytes 1712 pkt (dropped 0, overlimits 2158 requeues 0) backlog 0b 0p requeues 0 memory used: 18Kb of 4Mb capacity estimate: 2500Kbit min/max transport layer size: 28 / 1500 min/max overhead-adjusted size: 64 / 1518 average transport hdr offset: 14 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D8<=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D George On Thu, Mar 8, 2018 at 6:21 AM, Toke H=C3=B8iland-J=C3=B8rgensen wrote: > Kevin Darbyshire-Bryant writes: > >>> On 8 Mar 2018, at 11:09, Kevin Darbyshire-Bryant wrote: >>> >>> >>> >>>> On 8 Mar 2018, at 10:57, Toke H=C3=B8iland-J=C3=B8rgensen wrote: >>>> >>>> Kevin Darbyshire-Bryant writes: >>>> >>>>> Archer c7 v2. master branch of openwrt >>>> >>>> Ah, great; I actually have one of those sitting on my desk that I coul= d >>>> potentially reflash without breaking anything too important. >>>> >>>> In the meantime; do you get the same weird output on the >>>> dropped/overlimit/requeues fields if you install a different qdisc tha= n >>>> cake? >>> >>> From previous email this morning: >>> >>>> Definitely dubious and I=E2=80=99m no longer convinced it=E2=80=99s a = cake only issue. Looked at my AP which is running an older version of open= wrt, so older cake, older kernel etc etc and all qdiscs are returning odd i= mpossibly high values in a variety of fields. >>> >>> >>> >>> tc -s qdisc >>> qdisc noqueue 0: dev lo root refcnt 4485644 >>> Sent 0 bytes 0 pkts (dropped 0, overlimits 0) >>> qdisc fq_codel 0: dev eth1 root refcnt 4485644 limit 4497776p flows 453= 5164 quantum 4536072 target 5.0ms interval 100.0ms memory_limit 4Mb ecn >>> Sent 74281480509 bytes 91321865 pkts (dropped 0, overlimits 0) >>> maxpacket 1514 drop_overlimit 0 new_flow_count 7549 ecn_mark 0 >>> new_flows_len 0 old_flows_len 0 >>> qdisc noqueue 0: dev br-lan root refcnt 4485644 >>> Sent 0 bytes 0 pkts (dropped 0, overlimits 0) >>> qdisc noqueue 0: dev eth1.2 root refcnt 4485644 >>> Sent 0 bytes 0 pkts (dropped 0, overlimits 0) >>> qdisc noqueue 0: dev br-wifi_guest root refcnt 4485644 >>> Sent 0 bytes 0 pkts (dropped 0, overlimits 0) >>> qdisc noqueue 0: dev eth1.15 root refcnt 4485644 >>> Sent 0 bytes 0 pkts (dropped 0, overlimits 0) >>> qdisc noqueue 0: dev wlan1 root refcnt 4485644 >>> Sent 0 bytes 0 pkts (dropped 0, overlimits 0) >>> qdisc noqueue 0: dev wlan0 root refcnt 4485644 >>> Sent 0 bytes 0 pkts (dropped 0, overlimits 0) >>> qdisc noqueue 0: dev wlan1-1 root refcnt 4485644 >>> Sent 0 bytes 0 pkts (dropped 0, overlimits 0) >>> qdisc noqueue 0: dev wlan0-1 root refcnt 4485644 >>> Sent 0 bytes 0 pkts (dropped 0, overlimits 0) >>> >>> And that=E2=80=99s on an openwrt system from commit f5b4f5f8e33624f27af= 9fb3f86e09084181c08ed >>> Author: Alif M. Ahmad >>> Date: Sun Feb 25 03:18:41 2018 +0000 >>> >>> So actually this problem has been around a little while, pre recent cak= e changes. >> >> Oh and curiously the bad values go away if you ask for json output >> it=E2=80=99s much better. Which rather points at a =E2=80=98feature=E2= =80=99 of the >> =E2=80=98print_string=E2=80=99 behaviour. > > Right. Well, the print_* functions are behind several levels of > pre-processor indirection, so not quite obvious what's going on here. > Don't really see why they should spit out garbage values, though. > > > Stephen, do you have any ideas? > > -Toke > > >> >> tc -s -j qdisc >> [{ >> "kind": "noqueue", >> "handle": "0:", >> "dev": "lo", >> "root": true, >> "refcnt": 2, >> "options": {} Sent 0 bytes 0 pkts (dropped 0, overlimits 0) >> },{ >> "kind": "fq_codel", >> "handle": "0:", >> "dev": "eth1", >> "root": true, >> "refcnt": 2, >> "options": { >> "limit": 10240, >> "flows": 1024, >> "quantum": 1514, >> "target": 4999, >> "interval": 99999, >> "memory_limit": 4194304, >> "ecn": true >> } Sent 74283705614 bytes 91330210 pkts (dropped 0, overlimits 0)= maxpacket 1514 drop_overlimit 0 new_flow_count 7549 ecn_mark 0 >> new_flows_len 0 old_flows_len 0 >> },{ >> "kind": "noqueue", >> "handle": "0:", >> "dev": "br-lan", >> "root": true, >> "refcnt": 2, >> "options": {} Sent 0 bytes 0 pkts (dropped 0, overlimits 0) >> },{ >> "kind": "noqueue", >> "handle": "0:", >> "dev": "eth1.2", >> "root": true, >> "refcnt": 2, >> "options": {} Sent 0 bytes 0 pkts (dropped 0, overlimits 0) >> },{ >> "kind": "noqueue", >> "handle": "0:", >> "dev": "br-wifi_guest", >> "root": true, >> "refcnt": 2, >> "options": {} Sent 0 bytes 0 pkts (dropped 0, overlimits 0) >> },{ >> "kind": "noqueue", >> "handle": "0:", >> "dev": "eth1.15", >> "root": true, >> "refcnt": 2, >> "options": {} Sent 0 bytes 0 pkts (dropped 0, overlimits 0) >> },{ >> "kind": "noqueue", >> "handle": "0:", >> "dev": "wlan1", >> "root": true, >> "refcnt": 2, >> "options": {} Sent 0 bytes 0 pkts (dropped 0, overlimits 0) >> },{ >> "kind": "noqueue", >> "handle": "0:", >> "dev": "wlan0", >> "root": true, >> "refcnt": 2, >> "options": {} Sent 0 bytes 0 pkts (dropped 0, overlimits 0) >> },{ >> "kind": "noqueue", >> "handle": "0:", >> "dev": "wlan1-1", >> "root": true, >> "refcnt": 2, >> "options": {} Sent 0 bytes 0 pkts (dropped 0, overlimits 0) >> },{ >> "kind": "noqueue", >> "handle": "0:", >> "dev": "wlan0-1", >> "root": true, >> "refcnt": 2, >> "options": {} Sent 0 bytes 0 pkts (dropped 0, overlimits 0) >> } >> ] >> >> >>> >>> >>> _______________________________________________ >>> Cake mailing list >>> Cake@lists.bufferbloat.net >>> https://lists.bufferbloat.net/listinfo/cake >> >> >> Cheers, >> >> Kevin D-B >> >> 012C ACB2 28C6 C53E 9775 9123 B3A2 389B 9DE2 334A > _______________________________________________ > Cake mailing list > Cake@lists.bufferbloat.net > https://lists.bufferbloat.net/listinfo/cake