From: Georgios Amanakis <gamanakis@gmail.com>
To: Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk>
Cc: Cake@lists.bufferbloat.net
Subject: Re: [Cake] cake in lede-17.01
Date: Sun, 15 Jul 2018 12:13:44 -0400 [thread overview]
Message-ID: <CACvFP_hU_vQqq6eqj5AMp=2gr62ozihu+5UwVP8-OUD0xZa+ig@mail.gmail.com> (raw)
In-Reply-To: <9E71378A-EE18-4437-8672-B12A6569E6F6@darbyshire-bryant.me.uk>
[-- Attachment #1: Type: text/plain, Size: 287 bytes --]
I am not sure we need this in 4.4.
In the patch we check for "d->tail->nla_type == padattr".
However, all gnet_stats_copy*() are defined without a padding attribute.
On top of that on a TP-Link WR-941ND (ar71xx) the stats appear fine.
Any insight would be greatly appreciated.
George
[-- Attachment #2: Type: text/html, Size: 547 bytes --]
next prev parent reply other threads:[~2018-07-15 16:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-15 13:32 Georgios Amanakis
2018-07-15 14:43 ` Kevin Darbyshire-Bryant
2018-07-15 16:13 ` Georgios Amanakis [this message]
2018-07-15 16:43 ` Kevin Darbyshire-Bryant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACvFP_hU_vQqq6eqj5AMp=2gr62ozihu+5UwVP8-OUD0xZa+ig@mail.gmail.com' \
--to=gamanakis@gmail.com \
--cc=Cake@lists.bufferbloat.net \
--cc=kevin@darbyshire-bryant.me.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox