From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-x22b.google.com (mail-lf0-x22b.google.com [IPv6:2a00:1450:4010:c07::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 742573B29E for ; Sun, 15 Jul 2018 12:13:58 -0400 (EDT) Received: by mail-lf0-x22b.google.com with SMTP id g6-v6so19839414lfb.11 for ; Sun, 15 Jul 2018 09:13:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dZC1jbqYHTqtflEUHeoRn2NVO/tugihTtZTHsHPbNEM=; b=IBfnnkivUYvK78HJokoR9RSBsr9tt1evN8HqJeNr7anteKXsHlRBQH9EFFuO43Gd2g LHOX2tdCEkepiqsrli0EuqjG3PTTBG/uAxrL9KQgymjS9xU/74PoOOvlYkLbwJgUgEL3 0grA94TTQ/QFld7gRUUJL20Zm/VzV0njYwPkH8rEBAm05uO0ugcjK5ZbX8sxyhPTlTRq RCr7PtDbgtI+TayAQX+xZlZocTFEOAJZsBuJvAnmIxKbOm96hJ4eHrBR2bukK4Kt7fNp d0QpBwEScC+jka9SLh8v55lmWNxmGD5Fxh4x2gzH4aQgTEFUIXNaQwUISMqFipAfA2WW Kz8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dZC1jbqYHTqtflEUHeoRn2NVO/tugihTtZTHsHPbNEM=; b=CRli2WObTDSoMiX69ESU0XoW4kpiWsjj9mRhVaHcL4EEwpZ24/Xl4V21rGAM/1mhmH 3P/PQ7AyXBjxezd51go57V4OZYslqewsbHOekhdpvNuyBI3LpmM5kmpxjJGanbpI13QZ cb6aG8PjAV0uWu/4XgkahZb/QDnRf1C323YDn8pJtEZD6x28AcALrL3lLsVn24TCOw8a Y41rpquv8A7qi1UFH7mRmR06YnGBhE9kztbmsG3ERxg+7ww12ezWpzhrEL3wIVi7Pubd SIMs5mhJV21H3iJWWECXHlZwvCopHnpStlZsFJ0U176cPhEw0a5nWFepvg6sivv6SiGy SLeg== X-Gm-Message-State: AOUpUlFw0YfKiSZvouEPTnpv5+CbWVLX0xffGSfOiuADx2nJNpvYWP0u PeTgeaYJ/QCuifhui7BN41z9QuVFbZMC/7rKE6U= X-Google-Smtp-Source: AAOMgpd/KId7limZU/33mOz6DChxh/Pe+XYHhWQMf0fNn7TYNNtRU3+5EMdH+TF0cZPo0B6o2095ZCNu+54bYxM+u/Y= X-Received: by 2002:a19:7609:: with SMTP id c9-v6mr9259697lff.73.1531671236752; Sun, 15 Jul 2018 09:13:56 -0700 (PDT) MIME-Version: 1.0 References: <7ebfe7710037de2679d448a57b0129b6648ab4ba.camel@gmail.com> <9E71378A-EE18-4437-8672-B12A6569E6F6@darbyshire-bryant.me.uk> In-Reply-To: <9E71378A-EE18-4437-8672-B12A6569E6F6@darbyshire-bryant.me.uk> From: Georgios Amanakis Date: Sun, 15 Jul 2018 12:13:44 -0400 Message-ID: To: Kevin Darbyshire-Bryant Cc: Cake@lists.bufferbloat.net Content-Type: multipart/alternative; boundary="000000000000fabb1205710bff0a" Subject: Re: [Cake] cake in lede-17.01 X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Jul 2018 16:13:58 -0000 --000000000000fabb1205710bff0a Content-Type: text/plain; charset="UTF-8" I am not sure we need this in 4.4. In the patch we check for "d->tail->nla_type == padattr". However, all gnet_stats_copy*() are defined without a padding attribute. On top of that on a TP-Link WR-941ND (ar71xx) the stats appear fine. Any insight would be greatly appreciated. George --000000000000fabb1205710bff0a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
I am not sure we need this in 4.4.
= In the patch we check for "d->tail->nla_type=C2=A0=3D=3D=C2=A0pa= dattr".
However, all gnet_stats_copy*() are def= ined without a padding attribute.

On top of that on a TP-Link WR-941ND (ar71xx) the stats appear fi= ne.

Any insight would be= greatly appreciated.

Ge= orge

--000000000000fabb1205710bff0a--