From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 55B4B3CB6C for ; Mon, 7 Jan 2019 10:11:45 -0500 (EST) Received: by mail-lf1-x12f.google.com with SMTP id v5so520483lfe.7 for ; Mon, 07 Jan 2019 07:11:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=M3F3fuXyBrU5AAtJPqX2IqzPgQ2MmjsmcHC1IBtTctE=; b=G9y8w6aN2VkSYAWdRM6MkpphQlrMxko3rPAt57amjaxu4CSMPhDFJSWjz0xifK7Kka ZLAxdxw57AuznjdorFy3Atm1bXuPCB0Eos5EfF8IX0j7j8wAKJ0xL+32gGSbP4Zm574m yNwfMd9Jk26qioHeoxuC6zVc5yyEPqwJ5cN9QHivCwqTIoL6wjG6l5tF2/lfU/ZF7B6L nj+EmBnfJ1sB1J/JOVW/shKxJYO4E8LQuCthUr+tWOq1qpbZRi16NDIoV/M/3LGkMs1G A4pXjAk7hwu46tKzXVGLinGHiC+f/tte8H216KMdnXNFf94keN+dkqmXM6dBGobDKVot jn6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=M3F3fuXyBrU5AAtJPqX2IqzPgQ2MmjsmcHC1IBtTctE=; b=fqIdL+RtAej1UkfNmQw/NKSzHKgWhpdZJkGycwAinHg0+iR216OZoBtE8QadcQe+vG SpVS+6vX1N7sOwCs3NlyRMeQz37JkeWQjIuw6IylBd5L5Hbf9b0qVKEnPsXfPVVBJl7T DPM0aqtrFoTu87xBmtvjK02clUNZLdhcOKXkyRqvD1EP4H+8hh+ksj2WsCwNVy/4nha9 KZnJXpvGtHFZNNP0Vk+wH8ow/eSh5RW4zAaNk6VTHUIkmBOhKhlpAzKsicep8X3D5LR2 U8j0OnZ7XgDufFGVbaGuNCHfDEFFuF3yY0VRfG0SZZsAIcw+hH8oKZJWvdyTZ8tfqw3E 8bSw== X-Gm-Message-State: AA+aEWbl7/XwqHDTuk3j+fz5+apVy/iUc5O2b5Tl7ErVGEDmu8taAShM UqfHjeNhbf8gSPJ29z7nOBlleyn26ka2WSfEuDQ= X-Google-Smtp-Source: AFSGD/WA9z83YpqbW2Swaw2esC71Nn0G0T/YaEmsA6FnBsuRRSbYGTu51eoDIjste2+K9sVbdevBeKDLju642Z1jBJ4= X-Received: by 2002:a19:a28e:: with SMTP id l136mr33115157lfe.87.1546873903916; Mon, 07 Jan 2019 07:11:43 -0800 (PST) MIME-Version: 1.0 References: <008901d4a63d$7d054420$770fcc60$@gmail.com> <2EEF29A5-9038-478E-B23F-9C5B64A09B81@gmail.com> In-Reply-To: <2EEF29A5-9038-478E-B23F-9C5B64A09B81@gmail.com> From: Georgios Amanakis Date: Mon, 7 Jan 2019 10:11:32 -0500 Message-ID: To: Jonathan Morton Cc: Cake List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [Cake] host hashes and NAT neglected in src/dst-host mode X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jan 2019 15:11:45 -0000 Yes, of course! I was counting the flow-modes wrong. Sorry for the confusion. On Mon, Jan 7, 2019 at 3:20 AM Jonathan Morton wrot= e: > > > On 7 Jan, 2019, at 6:00 am, = wrote: > > > > 633 if ((flow_override || !(flow_mode & CAKE_FLOW_FLOWS)) && > > 634 (host_override || !(flow_mode & CAKE_FLOW_HOSTS))) > > 635 goto skip_hash; > > These lines require careful reading. > > First, the "override" flags indicate whether an external filter has chang= ed the flow or host hashes, meaning we should not then update them ourselve= s. > > Secondly, the logic is "if we *don't* need the flow hash *and* we *don't*= need the host hash, then skip the complicated hash code". > > In the dual and triple modes, both the flow and host hashes are required,= and bit-level examination of the codes used to identify them should reflec= t that. In "flows" and "host" modes, only one or the other are needed, but= they will still disable the above check (unless an external filter was use= d). > > In short, only "flowblind" mode or the use of external filters are capabl= e of skipping that block. > > - Jonathan Morton >