From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x22e.google.com (mail-lj1-x22e.google.com [IPv6:2a00:1450:4864:20::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 63CDC3CB35 for ; Sun, 3 Mar 2019 21:55:59 -0500 (EST) Received: by mail-lj1-x22e.google.com with SMTP id w6so2948823ljd.7 for ; Sun, 03 Mar 2019 18:55:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=65+6pHRo4oLxFmjjSHvjWbkqlsuxr/zMdInPineERTc=; b=hJeiJJUMHjY+Od1og/62Bzj8yltfrZHN+Vb5u+POWxbY4GLYmHHowSLqPRjGzESOJj TXOC1nBFyH3KRsShej5l7488P31eU51aNxGxjrGKT5/cRhKt0JYCIiV2eJfQanOhIHan rtBNa2kMHn2g09SmtEKPwen9HPKEbPusUroQUiPg32x1H7tI6akLpqtvtZA04/hvmJQk q21WWD1OdabGYSy0MsvxhTkZZk523mShZ1oSEX/z+WoYalUgXI3/J2h7j/RixddZxf49 C2IJeqcd/gyG8ZcmAViy44JgMH8Cc+BQhQImzyrJ69DUF6nJSfPbAroz8tkFwv8lautP jelQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=65+6pHRo4oLxFmjjSHvjWbkqlsuxr/zMdInPineERTc=; b=JfzHhPFncHfdWjKxBBIn7srh04NFeBZAl7evn4C8oljFi5JNMJWY0EoeUqhZLtLOS2 es/TzQf7zklt4wgr9iZgXjpOOeZWwF4BCte7TTfV/JJjj+pVvJm2f8wqfUo7QCiK+UbI xmMI7ErBqO0S2hoZKk2jNnLZxBoPabu4d1clflR4bowl1KdAoeskoqnunu95/+MQeFLD QHEhuO50fPyB3HTJg2HJs7ICDUEPB2qw3Wkrx/gyfU8olCY9Y8ZVTPRaoZSfuq/SRulE tmOTUgz5jbT5jRPbXr8lyVrw6KkajAiE64sSd1yb7BlJFcdSNovvJ5d0WM6hLTonrgmC LY4Q== X-Gm-Message-State: APjAAAXqG7wzwZw5m+B1mDntbYI1cqwlyFCzYg8bzEzayc3ZDJDuoqaX n7poSXebt7X8XRzGABNQv7qNw/q5UbqJwBVECN4= X-Google-Smtp-Source: APXvYqxyBoxYiD1BBQ+8WYRjr0Ex1ZydF8XiZ7kh0egqg6vy10h7lt1YRfyEyZHZFhZYPDHHcOT8UDvOTO2a2OKp+fg= X-Received: by 2002:a2e:9dda:: with SMTP id x26mr9117732ljj.53.1551668157980; Sun, 03 Mar 2019 18:55:57 -0800 (PST) MIME-Version: 1.0 References: <72193310-7502-47B8-9554-7F8F9FA23204@heistp.net> <874l8mn9iy.fsf@toke.dk> <417E17B2-17F7-4106-A92D-C5B5AC41D808@gmx.de> <5CC769AC-AD0C-40E8-BFCA-6AD2A8162FFC@gmail.com> <49A8FB42-EC0B-41B7-8CE4-888DF3C2A88D@gmx.de> <542D3BC3-317A-4F3E-A5B6-16FF678DDFAC@gmail.com> <5C8177FD-2605-4CDD-9AA2-F0E5AF9C779B@heistp.net> <1C81557C-2FD5-4C48-BC17-F9E841D08097@gmail.com> <511C22FF-64A5-46CA-BFB9-4EA350B76122@gmail.com> <9746402E-41EA-43F9-AAE6-53C038EABFFF@heistp.net> <000001d4d1f3$c5599eb0$500cdc10$@gmail.com> In-Reply-To: From: Georgios Amanakis Date: Sun, 3 Mar 2019 21:55:46 -0500 Message-ID: To: Pete Heist Cc: Jonathan Morton , Sebastian Moeller , =?UTF-8?Q?Toke_H=C3=B8iland=2DJ=C3=B8rgensen_via_Cake?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [Cake] Upstream submission of dual-mode fairness patch X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Mar 2019 02:55:59 -0000 I was just thinking that getting rid of the decrement of flow->deficit and tin->deficit when we call cake_advance_shaper() to account for "ingress" traffic might not be that awful after all. That way, the shaper logic is unaffected but the fairness logic wouldn't account for that "ingress traffic" and would yield fairer results. I would love to hear your thoughts. On Sun, Mar 3, 2019 at 2:49 PM Pete Heist wrote: > > > > On Mar 3, 2019, at 8:03 PM, gamanakis@gmail.com wrote: > > > > For the record, I can replicate it now. I also think that this behavior= is expected. > > There is a work-around but it seems like an awful hack: > > > > ----------8<---------- > > diff --git a/sch_cake.c b/sch_cake.c > > index 733b897..08e08f4 100644 > > --- a/sch_cake.c > > +++ b/sch_cake.c > > @@ -2216,7 +2216,6 @@ retry: > > if (q->rate_flags & CAKE_FLAG_INGRESS) { > > len =3D cake_advance_shaper(q, b, skb, > > now, true); > > - flow->deficit -=3D len; > > b->tin_deficit -=3D len; > > } > > flow->dropped++; > > ----------8<---------- > > > > > > Then the results are: > > > > IP1, 1 up: 47.18 mbit/s > > IP2, 32 up: 46.99 > > IP1, 32 down: 40.98 > > IP2, 1 down: 41.34 > > Yes, thanks for confirming it, this fix equalizes goodput for me as well,= although I think we=E2=80=99re in agreement that nothing should actually c= hange in the end(?) > > If so, I think we should document this. If it wasn=E2=80=99t obvious to u= s right away what was happening, then it probably won=E2=80=99t be obvious = to others. > > If I don=E2=80=99t hear any objection to this in the next couple days, I= =E2=80=99ll submit a pull request to tc-adv for tc-cake.8, if that=E2=80=99= s the right place to do it. >