From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mail.toke.dk; spf=pass smtp.mailfrom=; dkim=pass header.d=trailofbits.com; arc=pass; dmarc=pass (Used From Domain Record) header.from=trailofbits.com policy.dmarc=reject Received: from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com [IPv6:2a00:1450:4864:20::22a]) by mail.toke.dk (Postfix) with ESMTPS id F17B211E3818 for ; Tue, 09 Jun 2026 14:16:21 +0200 (CEST) Received: by mail-lj1-x22a.google.com with SMTP id 38308e7fff4ca-396bed274b9so46552721fa.0 for ; Tue, 09 Jun 2026 05:16:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1781007381; cv=none; d=google.com; s=arc-20240605; b=K1SDgwbmlVugs/7eASXpODRSqRSv9k4Z07n/ilRyTl1xA8XsYPGNiJZXZuJhzmkwb9 zjNLt9ImqZ5rH/cb1PwCbUDUZ0jxjnsOsGegX/u14lQ/elrBG6NHot7e26Z3EAgH/d1M 2WP/SWqyqUgoz7V4IihrGQmK7qWGLJGFeIGhngtWNvd22aVb5DT4bRg90QDjAoZ4/WKT WGNTam+SO7yoClm/QFWqa4i93qIWmgvq4WSt5z2KlzIGmJ+LJ2OeJPjh2i8u8X0Kc9Jr sZ+GANbm+xkYFWIPXQv3PT78WpdM8XQ4ru28ifmezmbAJ3J/6Uhb+WVrnHQB8aq81ySD rurw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=okHsnL8+kGj13ffxwZXFsn1xCZyYlTCVOYxGFJ+E5jU=; fh=zuB9av1wvYBz4VjzU1b2h6Q77qf9ZHornGGfmrP1NKQ=; b=A/sdjgLqBC29ooinj0lI75rXywWAdLSpIdibWf12pwdJpeGgFPA8gw356euVuh7upr txW0/6ZoofZN8SyGPptLelroTGP87BI27rHH7rBuH87rDqRXrjPRzK/XTEiMmoODrDcS opNK8MWOMRcvMwbI5TOQBLk22uC5+MzGEnqh7/LfMpsp4O7HFRydwK8ZzKAV1Fc0+Lqd JGIzwoBFHBytK9Na+I8ygHr0wKLotauvBSYfH9LmS5PnJMZCXUENMEj/JYpoZi0V7Dxp pWf2FeIfO83fYZYfORRDgbk1g2vy65ezF007OlWZSJR+OY+AIR3Dflb8WRcAoDqv9QtZ 3Tvw==; darn=lists.bufferbloat.net ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=trailofbits.com; s=google; t=1781007381; x=1781612181; darn=lists.bufferbloat.net; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=okHsnL8+kGj13ffxwZXFsn1xCZyYlTCVOYxGFJ+E5jU=; b=Qy0kqak6JLNS/HQBTpuyoqNhLaHbg7Es4sxozkUPmAyrVG8wTFdOoHnyauKfk3o6PM JPFCtNAHdOt3h/xAEaProM7eKfo8oYbGBSDb09WeB7iHNMhB1mei1qkD8X5PSD/820AC wCXizH7GT2G6wrR+QxV/VyXYcSaGD9e5HzoeMszwbd8T+8vXxj9PR25ER8D2ckuT+HG2 YrnCIBlCfo2N6OWdSO7Jf/R0xn5tFzyG3cTwqiFCgG9myQ1nHNXMZvMQpIxtKc1Bq2Ji 0Dg9MqTOo+HSGMHzzFUuvFVcv27ph3SJ9fHlj7PP2X/1Ih4MFQHoGNxmiVFxXcxQLV7O RBeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781007381; x=1781612181; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=okHsnL8+kGj13ffxwZXFsn1xCZyYlTCVOYxGFJ+E5jU=; b=fP9klRySe5KwJAVblGiR5hKjPgpZwn+WjLO2RTE0GaPpYHL2Om9+yJ3Cj3uA4X1Te6 MO0VwBzYiOqvTfMmxj/IZ+55ZVzlHMZ6jqLuO/9EAnjJrd5T/yR3Xk9/iOfPFuiWpFBQ 0gV5dpLVEWlICr4kIONOmUo1U18UFKh/4kwrl1cskKP3IYIrbZTt7TlpO2cjCejrOwcz h7yezuBL8gbwZ650yFXQB0WiAcRfAL7eL4GQMtS/SW4ga1Umz7bm+gpT1Rv+Ft7YFQRu ew9dmpEuVcDvX5ZXt6Oq+dhEC+4GjWjhnDNy0ff+cBOsGXMy03/RBM7VB6zz3OT4fDnA O0wg== X-Forwarded-Encrypted: i=1; AFNElJ8AVY0FWpLg8Oza+U6W+6f5i7wNm+CoIxyThI8yHY/AsHAzIdih+1506LZg+rAasMbP9wTQ@lists.bufferbloat.net X-Gm-Message-State: AOJu0Yyf2rJKOz0cClh+DrlK6D538mrxWm15ww7imtE+y2WEA3uWmdED ISxdJW5f/Ch7lEXVuHXKkgLjp6sSsDbTTa4yoEMqqNg05Jp6MvDEPZmIqsBPmZJbw/JQNKkqOn5 W96yCul1ZR9ZlusuBjm4DAIKygo7yi7XibYNongiY7w== X-Gm-Gg: Acq92OFQvM2yBiSDieN+jhO2DEypafHAQW9I/Xn7NB6gFg6UMK0sqLc2+BJm/mDDgiF ONd+p++mnqGKpBhqqLM7qYYkcd2jiISJ63lk5DJeHo7EMbYgfUl1PsmkjCbOAACR7hyMaXBu+2R zWPVqrzL0wj0XrU9dkODbOaS7Il2tDL0ETqdYUf3Fkg9T+hh/jtyfI+Ou/lok8btJpRRAOSGglZ oTdovkpv3TjVLHei6T7EEJOHoITrtOTWgbuKOfDmaQDg83N8tcuu+Ja6/O2h0D/+foUq7QWHzSO nFgBg8Y2B/2HpBFCYAqetYl4OKM= X-Received: by 2002:a05:6512:3e18:b0:5aa:6b8b:8c9c with SMTP id 2adb3069b0e04-5aa87bf3751mr6215270e87.42.1781007380529; Tue, 09 Jun 2026 05:16:20 -0700 (PDT) MIME-Version: 1.0 References: <20260609000605.1234374.9ba17536ec9e.cake-rate-change-stale-flow-deficit@trailofbits.com> In-Reply-To: From: Samuel Moelius Date: Tue, 9 Jun 2026 08:16:06 -0400 X-Gm-Features: AVVi8CexXyUcc87AwUVjcMsIXevgQnYIxFlnIj4FSx6j9GGaX9uR577Xu9GYnt4 Message-ID: To: Eric Dumazet Cc: =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= , Jamal Hadi Salim , Jiri Pirko , "David S. Miller" , Jakub Kicinski , Paolo Abeni , Simon Horman , "moderated list:CAKE QDISC" , "open list:TC subsystem" , open list Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-MailFrom: sam.moelius@trailofbits.com X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation Message-ID-Hash: 2JWRVUTWNWMG4WROQLAXLBKC3YX4T76H X-Message-ID-Hash: 2JWRVUTWNWMG4WROQLAXLBKC3YX4T76H X-Mailman-Approved-At: Tue, 09 Jun 2026 14:26:25 +0200 X-Mailman-Version: 3.3.10 Precedence: list Subject: [Cake] Re: [PATCH] net/sched: cake: clamp active flow deficit on rate changes List-Id: Cake - FQ_codel the next generation Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, Jun 8, 2026 at 9:08=E2=80=AFPM Eric Dumazet w= rote: > > On Mon, Jun 8, 2026 at 5:08=E2=80=AFPM Samuel Moelius > wrote: > > > > Changing CAKE rate parameters updates the quantum used for future > > scheduling, but active flows can retain deficit computed under the old > > rate. > > > > That stale deficit lets an already active flow receive service based on > > the previous configuration after userspace changes the shaper rate. > > > > After recomputing rate-derived scheduling parameters, clamp positive > > active-flow deficits to the quantum that applies under the new > > configuration. > > > > Assisted-by: Codex:gpt-5.5-cyber-preview > > Signed-off-by: Samuel Moelius > > --- > > This is bloat for a not existent issue. > > pw-bot: cr Sorry for misunderstanding, but is this patch rejected?