From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mail.toke.dk; spf=pass smtp.mailfrom=; dkim=pass header.d=trailofbits.com; arc=pass; dmarc=pass (Used From Domain Record) header.from=trailofbits.com policy.dmarc=reject Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [IPv6:2a00:1450:4864:20::12c]) by mail.toke.dk (Postfix) with ESMTPS id 6D0F112A27F8 for ; Mon, 29 Jun 2026 20:44:42 +0200 (CEST) Received: by mail-lf1-x12c.google.com with SMTP id 2adb3069b0e04-5aea3417c6bso2503486e87.2 for ; Mon, 29 Jun 2026 11:44:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1782758680; cv=none; d=google.com; s=arc-20260327; b=otMgCdPVpBjFXfuBJaOmVKqOCPx4dfksKtQV/GfmpWIb77/sKz+bpzH7LAJrsXbqH9 ftGSWPItaYSCt4dH2vg6CuTLU305ih38EG712dMawLOlKOdR0cQYgdaDXbYM8X6mFC1E TrL2MPhLVKDdKNLHLLEj2qBUaxo9vXk/c+DtUkf/Jeg+f86pD8KV+kEyomZtFngxvYg9 G7Q1sEWhlQ2f4MRKusRdk6gKW+kx3QS3VxpmOyoyhouCVVXmTfVlXn4mKbnz1PlprU2G UQ1l275DULqjnrLQ2smVZkD5pTMH/h9GPoKh3L3QRXG7+lMaUG8fQbT3L49fTUuO4Qns Y+ZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=h8GXVWaPeCuflzpz/fudyGnPI2CJbmSQwizJP5KijfQ=; fh=NzkS09Rvs2O/Z65tQtrbtwfRAqD8ODlykB0B6TWD0ko=; b=StEJzX2WQWc0rGLcXOJRaHcgCTH/iNhp9IFxeegBVnEFEmOJUiYT450V+uad6UZz3M 8MX+VxUHc6+q9VkgbV4d+CdlrRg0UO+A3tu4b44BuYVkxXfDDnf7Qh8bpxJq+XxzpGmg oXc6p1u3CX4ywVN2BzWKY7jYCBJRQ8nyiY+QfwcMlrVC2iE4zK7PDro44Dg+lXjCbN9Q ITyX0qg0XYQ0jrKqdqeURizrirr/H8MZBW+rAXT8cUDsa7/nZL3P0Xh9sAsJNOKjNId2 RqUCFkIOHYLWtoCa3piParmeq6BOSnxmrKwmN36s+M7dLmHLVOAa3lnoRfcE7W23LB+x Br5A==; darn=lists.bufferbloat.net ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=trailofbits.com; s=google; t=1782758680; x=1783363480; darn=lists.bufferbloat.net; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=h8GXVWaPeCuflzpz/fudyGnPI2CJbmSQwizJP5KijfQ=; b=ahu/iR9sFuqWROtdsISdE0FuJbj9A8yj951BaBbyPP9GS2vrtIzxQwJrapzhALHhDO h+l9KanA5T3HWwBnGGtVSJqEQlcLdvShaqTmgTSNYWoDvCkZ4VEY0b0f4qU2dCxOls5i JGqs1AHFANPyG7DbHSU8H42DEeYVzBKJGmv/1bDELzRYXWemFVUn/AbBn1u4J+B3sLxa 68WciKaQeXzYicKfeagin5SxlHKiyFPBcTT9hT1VQxazG1IGM2dJxLRVrDbr///S8mxE 0EghfPKGQA4uk2pee84jmeJiSlGlsnzmclwp/IcS7XfdHIK3AxWTcGM6VBajq6NTL0mz R1+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782758680; x=1783363480; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=h8GXVWaPeCuflzpz/fudyGnPI2CJbmSQwizJP5KijfQ=; b=moUqWrYBjXsn90O2WsegvBKMIggLK1EyTDzJSauXWW9Zz5a3zP1NKv9ng0Rq5did4K vF42NJBzlVvmYr00qYCzLqmaT8EPwEDLr8axPd4NH6E9CjWlqJpLdo24VEiRMqL+wwLo Cz5EYyMWt4eCdlGauPNLfZDappeAeGmmjfQs/Ye39WOjvKXxKeISM125yFix5fqbMZMo JyORbSD3aR+8SVj1Z45oahYsSx0VELbd8uDMYQ7jiUsx5Z0z3iE0bfKTPXS+EI9iLKxk O4oI/p1Modi/umhdAKiMQx0e1jgydp8gFDf0r08XP4A36cibKuvu+zCgcG3Z6BwhwWtO HkVg== X-Forwarded-Encrypted: i=1; AHgh+RqIMmHyjRqmTmuoSBL5W/zrsDsiZd2+wPGnvIwHWzS68AkbB7iQa0I4HnQLHx6pcGTw7DUr@lists.bufferbloat.net X-Gm-Message-State: AOJu0YzN+CY9VEUFcHHNbYxFKDyJktoEWkB594j4QOOjcvq9aFyFyVOH EFAt3F7Siyrr7k2kiFI37l0sfORxH7jSMuYa+SNClEMqJb5L71WBJIAyBSMkxIH3k5+5l2ZbbmS +/m+snnAjoBSYh66o3IXCs6+gqz+8YFCLmVMPxKJcLQ== X-Gm-Gg: AfdE7clsXhF7r0s1PwZI0CihnyPtffBrDnvBe68fRSmECQY1QgMrzMj2V7UvvujSQLP MDRovp4a9sQAPw0m20fySMbdJTsW5sG1HI+JumbwiYwwakENB1VRWTZ9tt/0aOVUjYydfoUyl27 gBwiu7/k/nLIjpf7UFeTQo+mRUBfuv3NwvF/51PTxz9dikbM1i5MJXhvX1LYrrBkBunqkLsnPXc Q+RnML9QN6/RNNmmczIdAzauXY1xIelolVyaN9wGsdGTUdHYX/yA7NNJG4tOUEv2Eupejo= X-Received: by 2002:ac2:454e:0:b0:5ae:b019:af66 with SMTP id 2adb3069b0e04-5aebdbb2550mr64975e87.39.1782758680559; Mon, 29 Jun 2026 11:44:40 -0700 (PDT) MIME-Version: 1.0 References: <20260609232935.1602659.8545fdb04fbe.cake-overhead-underflow@trailofbits.com> <20260613142626.1b2183eb@kernel.org> In-Reply-To: From: Samuel Moelius Date: Mon, 29 Jun 2026 14:44:28 -0400 X-Gm-Features: AVVi8CemPKN3BPaGiEa1_mcG3yW7cCKSdTjgFUbLx24prCZ6rrSJeilUHeOCVxY Message-ID: To: Jakub Kicinski Cc: =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= , Jamal Hadi Salim , Jiri Pirko , "David S. Miller" , Eric Dumazet , Paolo Abeni , Simon Horman , "moderated list:CAKE QDISC" , "open list:TC subsystem" , open list Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-MailFrom: sam.moelius@trailofbits.com X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation Message-ID-Hash: VTWZLXE3KCRZKTB6TUFE6NGIYKO4HKKN X-Message-ID-Hash: VTWZLXE3KCRZKTB6TUFE6NGIYKO4HKKN X-Mailman-Approved-At: Tue, 30 Jun 2026 11:43:21 +0200 X-Mailman-Version: 3.3.10 Precedence: list Subject: [Cake] Re: [PATCH net v2] net/sched: cake: reject overhead values that underflow length List-Id: Cake - FQ_codel the next generation Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, Jun 29, 2026 at 1:24=E2=80=AFPM Samuel Moelius wrote: > > On Sat, Jun 13, 2026 at 5:26=E2=80=AFPM Jakub Kicinski = wrote: > > > > On Tue, 9 Jun 2026 23:29:36 +0000 Samuel Moelius wrote: > > > +static const struct netlink_range_validation_signed cake_overhead_ra= nge =3D { > > > + .min =3D -64, > > > + .max =3D 256, > > > > Both Sashiko's complain - these values are neither safe nor sufficient. > > > > How was the -64 chosen? It looks suspiciously close the min ethernet > > frame length. > > That's how it was chosen. But as you've shown, it was not a good choice. > > I would like to submit a revised patch that does the check on the > datapath, as you suggested. Should I send that patch? Or would you > prefer to wait for a response from Toke? Apologies. I just noticed Toke did reply. Should I send a patch consistent with what he suggested?