Re: [Cake] Dropping dropped

[Adrian Popescu <adriannnpopescu@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1368 bytes --]

On Thu, Feb 14, 2019 at 4:35 PM Toke Høiland-Jørgensen <toke@redhat.com>
wrote:

> Adrian Popescu <adriannnpopescu@gmail.com> writes:
>
> > Hello,
> >
> > I've taken a look at cake's source code to see what simple changes could
> be
> > made to attempt to speed it up. There seemed to be a per flow variable
> > called dropped which might not be that useful for regular users. The
> > attached patch removes it.
>
> I appreciate the sentiment; however, we keep a lot of statistics for a
> reason, and we don't want to just drop those. Besides, a single variable
> increment is probably not going to make much difference for performance.
>

Perhaps this seemed I implied that it was more than an experiment or
something meant to be merged. Is sharing a patch to start a conversation
frowned upon?

The point is that low end routers can't run cake at high speeds. It doesn't
make sense to buy more expensive hardware for home networks.


>
> > Perhaps cake could be optimized further for slow devices. What's the
> > recommended solution for profiling the kernel on mips with openwrt?
>
> No doubt; however, I'd suggest going about it by actually measuring any
> bottle-necks and working from there. The 'perf' tool works on openwrt
> these days, I think; that would probably be a good place to start.
>

Thanks.


>
> -Toke
>

[-- Attachment #2: Type: text/html, Size: 2186 bytes --]