From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it1-x130.google.com (mail-it1-x130.google.com [IPv6:2607:f8b0:4864:20::130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 3AC473CB35 for ; Fri, 15 Feb 2019 03:23:29 -0500 (EST) Received: by mail-it1-x130.google.com with SMTP id z131so11829561itf.5 for ; Fri, 15 Feb 2019 00:23:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6Lfhjy50cZMBz5MFe+Ib5tMKaYoUiF8wVoizsD0A6JY=; b=E3c7An0f3XvczERUcRYyhPUy2hT3WOtgoSpfGF+amwYhDYVAzzhzsoyzmFjTLO9qRb j917eQuV3eJMU78VFChNTr8RnBRFtldJ5QsqDnVHs88z8QQSb9jaSGmDFRxiissnDNu5 XryF/4bY1LQ63OUMoDd1U5E/RzbPxhUB73jUKfHeWBIDQ7gm+3pfu2L7ol5xdAK4k3Yf g505mjgMO0kO1iCEVUV48eoAJwH/Mv8tEi2D5/tBg6ZjHje5ahmSb2bbd4/I+TIxt3iL X4+izO4xxW6xLtZ7RhoHvelirNmrx9wjMmx09jniU/wmCszPL9i3+jvDfUnOziLPxWwl Y3SA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6Lfhjy50cZMBz5MFe+Ib5tMKaYoUiF8wVoizsD0A6JY=; b=ih03UuwRSkEsqWAYYzQ6Mo+mtzDqyuJwEARDX2bd0+YUd55w7UTp1pHuOnY+TTRxDT bSddhI1Nd5/OlMyp/0A4TrFsuQ2eZlSNAMNxygwvAZG13AEkAJcLSb2SRHwGr2+TA4Pu Ggr0Bvc2rmy2tsqvwqMrpEHpuocoteD/6s75Offwxjdx/1K1sBM/IEhVpLBFUfHWc7ma I4/5Skc3AdbxwdLjR4uTP6Saz1f+QX3+GNwilOw4ZI0MjIk7YyHGwYHTcH5lhcQKoDkB ElDV0Ns+Xh8n24OHjOM9XRmdcWhDPQmnjcfxUDJmrCc5H5bxjpQaBV40U5IYwkbuOS7x pG3Q== X-Gm-Message-State: AHQUAub0v6jz3ZFEzxNBvjrHUSpfCraKD7zEZcGvQ9KjQKCq34wSVHiT s6dhgaS0V+sOlRngdUCJ616BJTDovTsZKDZrMuc= X-Google-Smtp-Source: AHgI3IafNNqnQ8meJzC21Xmk8QCNaU3tPpaVHj20vsh2I44rchSm5P+dmzVYmdoic3xU0Vq1Su5kgn3JL7oKNrNo+tg= X-Received: by 2002:a5e:8f4b:: with SMTP id x11mr4986350iop.217.1550219008680; Fri, 15 Feb 2019 00:23:28 -0800 (PST) MIME-Version: 1.0 References: <87imxmwi8b.fsf@toke.dk> In-Reply-To: <87imxmwi8b.fsf@toke.dk> From: Adrian Popescu Date: Fri, 15 Feb 2019 10:23:17 +0200 Message-ID: To: =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= Cc: Cake List Content-Type: multipart/alternative; boundary="00000000000056293a0581ea7dec" Subject: Re: [Cake] Dropping dropped X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Feb 2019 08:23:29 -0000 --00000000000056293a0581ea7dec Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Feb 14, 2019 at 4:35 PM Toke H=C3=B8iland-J=C3=B8rgensen wrote: > Adrian Popescu writes: > > > Hello, > > > > I've taken a look at cake's source code to see what simple changes coul= d > be > > made to attempt to speed it up. There seemed to be a per flow variable > > called dropped which might not be that useful for regular users. The > > attached patch removes it. > > I appreciate the sentiment; however, we keep a lot of statistics for a > reason, and we don't want to just drop those. Besides, a single variable > increment is probably not going to make much difference for performance. > Perhaps this seemed I implied that it was more than an experiment or something meant to be merged. Is sharing a patch to start a conversation frowned upon? The point is that low end routers can't run cake at high speeds. It doesn't make sense to buy more expensive hardware for home networks. > > > Perhaps cake could be optimized further for slow devices. What's the > > recommended solution for profiling the kernel on mips with openwrt? > > No doubt; however, I'd suggest going about it by actually measuring any > bottle-necks and working from there. The 'perf' tool works on openwrt > these days, I think; that would probably be a good place to start. > Thanks. > > -Toke > --00000000000056293a0581ea7dec Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Thu, Feb 14, 2019 at 4:35 PM Toke = H=C3=B8iland-J=C3=B8rgensen <toke@red= hat.com> wrote:
Adrian Popescu <adriannnpopescu@gmail.com> writes:

> Hello,
>
> I've taken a look at cake's source code to see what simple cha= nges could be
> made to attempt to speed it up. There seemed to be a per flow variable=
> called dropped which might not be that useful for regular users. The > attached patch removes it.

I appreciate the sentiment; however, we keep a lot of statistics for a
reason, and we don't want to just drop those. Besides, a single variabl= e
increment is probably not going to make much difference for performance.
=C2=A0
Perhaps this seemed I implied that it w= as more than an experiment or something meant to be merged. Is sharing a pa= tch to start a conversation frowned upon?

The poin= t is that low end routers can't run cake at high speeds. It doesn't= make sense to buy more expensive hardware for home networks.
=C2=A0

> Perhaps cake could be optimized further for slow devices. What's t= he
> recommended solution for profiling the kernel on mips with openwrt?
No doubt; however, I'd suggest going about it by actually measuring any=
bottle-necks and working from there. The 'perf' tool works on openw= rt
these days, I think; that would probably be a good place to start.

Thanks.
=C2=A0

-Toke
--00000000000056293a0581ea7dec--