From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it1-x142.google.com (mail-it1-x142.google.com [IPv6:2607:f8b0:4864:20::142]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 07F273CB35 for ; Thu, 14 Feb 2019 09:01:32 -0500 (EST) Received: by mail-it1-x142.google.com with SMTP id r11so15173117itc.2 for ; Thu, 14 Feb 2019 06:01:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=2eahRhfguLVVSOzlXVIy2mYLnkQsTzfy8xqMpPrIrx0=; b=pOn6j6ka/0B2nfUX6OPKE7TDSidQ35MYCFFc5G+Wz8b9/H1CRbi7wIQxkOW3yomvrh 9nEe1vsDXAoI/lCCs08yM+Htxf5xb0PQSnHCJ4p64ReLOYTYs7vCLI9AYcCw/NQ+mQqA xCWS0X4CTZLdw8gYoAdVwLdP3GZw5+OF17T4sLDSZFs67Io8/xbc//4EWL0FYTSCKGFx 17EhugtqgnghiprN0l9Tp6qD0EAb/yc2h5pY7IpMMmVbv3Za4r86tGlAkheJvPT+eF9D UeuFoXZ3YxhuASIU9J3PMGZ+rGo5DFE+fdU1Xv/iBY1EKx0hPP5FPIbVPjzUsW60Nfgy niGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=2eahRhfguLVVSOzlXVIy2mYLnkQsTzfy8xqMpPrIrx0=; b=R+j6TKPStfBUu9pP1L4JBiFUetUjXm6gtmP/SMSTNpKdQ+27438lKz2YnPMWXY+AvF XKVdFKpoyLtGZpn+D07GhpNoPGXWUN68+uEftKlPfgN8xbZpfKIcJcHPetYVhqg/oo0m HOZQivpbppIirEvJhl432LseTP8wDMJtwfKyBfU9Vtn2Q/gV1qzGQIjhgU06UTNUlwcP bGEbPq9A2atOBYkr0iMeyx+dOWQiaFmx/MlraUcoTB4CvQvjzrznhDJeLnq1z8CBanav v9Z7usFk4DzQR2LublUMbtCoqGldBhsRBNB28GxSucf33l6QhDZbtLVOq877didC4a5x D/Gg== X-Gm-Message-State: AHQUAua8fXSPN/f94/TTHWXqdQ+5NUo4geWYf5NPE/Wb+qQAPklq4FvW RMIt02PaMePJRcnMisvNI+v18XGYW32leKBC4AFaq5Jk X-Google-Smtp-Source: AHgI3IacTqV3Uh36gTxHS1mfzUY/4umD7UjzU3cltpTvC3q7CNdxS4bdpO9+oLYnA8twYZTe6m8KwevMOE6KAX6/9pE= X-Received: by 2002:a6b:3b0d:: with SMTP id i13mr2484298ioa.266.1550152891364; Thu, 14 Feb 2019 06:01:31 -0800 (PST) MIME-Version: 1.0 From: Adrian Popescu Date: Thu, 14 Feb 2019 16:01:19 +0200 Message-ID: To: Cake List Content-Type: multipart/mixed; boundary="000000000000701d300581db18ad" Subject: [Cake] Dropping dropped X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Feb 2019 14:01:32 -0000 --000000000000701d300581db18ad Content-Type: multipart/alternative; boundary="000000000000701d2c0581db18ab" --000000000000701d2c0581db18ab Content-Type: text/plain; charset="UTF-8" Hello, I've taken a look at cake's source code to see what simple changes could be made to attempt to speed it up. There seemed to be a per flow variable called dropped which might not be that useful for regular users. The attached patch removes it. Perhaps cake could be optimized further for slow devices. What's the recommended solution for profiling the kernel on mips with openwrt? --000000000000701d2c0581db18ab Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello,

I've taken a look= at cake's source code to see what simple changes could be made to atte= mpt to speed it up. There seemed to be a per flow variable called dropped w= hich might not be that useful for regular users. The attached patch removes= it.

Perhaps cake could be optimized further f= or slow devices. What's the recommended solution for profiling the kern= el on mips with openwrt?


--000000000000701d2c0581db18ab-- --000000000000701d300581db18ad Content-Type: application/octet-stream; name="cake-remove-dropped.patch" Content-Disposition: attachment; filename="cake-remove-dropped.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_js4ougre0 ZGlmZiAtLWdpdCBhL3NjaF9jYWtlLmMgYi9zY2hfY2FrZS5jCmluZGV4IDNhMjZkYjAuLmQxZWEx ZDYgMTAwNjQ0Ci0tLSBhL3NjaF9jYWtlLmMKKysrIGIvc2NoX2Nha2UuYwpAQCAtMTM2LDcgKzEz Niw2IEBAIHN0cnVjdCBjYWtlX2Zsb3cgewogCXN0cnVjdCBza19idWZmCSAgKnRhaWw7CiAJc3Ry dWN0IGxpc3RfaGVhZCAgZmxvd2NoYWluOwogCXMzMgkJICBkZWZpY2l0OwotCXUzMgkJICBkcm9w cGVkOwogCXN0cnVjdCBjb2JhbHRfdmFycyBjdmFyczsKIAl1MTYJCSAgc3JjaG9zdDsgLyogaW5k ZXggaW50byBjYWtlX2hvc3QgdGFibGUgKi8KIAl1MTYJCSAgZHN0aG9zdDsKQEAgLTE1OTQsNyAr MTU5Myw2IEBAIHN0YXRpYyB1bnNpZ25lZCBpbnQgY2FrZV9kcm9wKHN0cnVjdCBRZGlzYyAqc2No LCBzdHJ1Y3Qgc2tfYnVmZiAqKnRvX2ZyZWUpCiAJc2NoLT5xc3RhdHMuYmFja2xvZyAtPSBsZW47 CiAJcWRpc2NfdHJlZV9yZWR1Y2VfYmFja2xvZyhzY2gsIDEsIGxlbik7CiAKLQlmbG93LT5kcm9w cGVkKys7CiAJYi0+dGluX2Ryb3BwZWQrKzsKIAlzY2gtPnFzdGF0cy5kcm9wcysrOwogCkBAIC0y MTkxLDcgKzIxODksNiBAQCByZXRyeToKIAkJCWZsb3ctPmRlZmljaXQgLT0gbGVuOwogCQkJYi0+ dGluX2RlZmljaXQgLT0gbGVuOwogCQl9Ci0JCWZsb3ctPmRyb3BwZWQrKzsKIAkJYi0+dGluX2Ry b3BwZWQrKzsKIAkJcWRpc2NfdHJlZV9yZWR1Y2VfYmFja2xvZyhzY2gsIDEsIHFkaXNjX3BrdF9s ZW4oc2tiKSk7CiAjaWYgTElOVVhfVkVSU0lPTl9DT0RFIDwgS0VSTkVMX1ZFUlNJT04oNCwgOCwg MCkKQEAgLTMwODgsNyArMzA4NSw2IEBAIHN0YXRpYyBpbnQgY2FrZV9kdW1wX2NsYXNzX3N0YXRz KHN0cnVjdCBRZGlzYyAqc2NoLCB1bnNpZ25lZCBsb25nIGNsLAogCQkJY2FrZV9tYXliZV91bmxv Y2soc2NoKTsKIAkJfQogCQlxcy5iYWNrbG9nID0gYi0+YmFja2xvZ3NbaWR4ICUgQ0FLRV9RVUVV RVNdOwotCQlxcy5kcm9wcyA9IGZsb3ctPmRyb3BwZWQ7CiAJfQogCWlmIChnbmV0X3N0YXRzX2Nv cHlfcXVldWUoZCwgTlVMTCwgJnFzLCBxcy5xbGVuKSA8IDApCiAJCXJldHVybiAtMTsK --000000000000701d300581db18ad--