Hi Jonathan,

Thanks a lot for the quick review and suggestions to improve the code readability.

We incorporated all the changes but didn't see any improvement in the results.

However, we finally noticed that it was the packet size used in our simulations that was affecting the throughput. It was earlier set to 1000 bytes, and after making it 1500 bytes (including headers) we note that the throughput is not affected.

We have uploaded the new graphs on the same wiki link:

https://github.com/Daipu/COBALT/wiki/Light-Traffic

We're not sure why packet size is affecting the throughput so largely. Is it the expected behavior?

Thanks and Regards

Jendaipou Palmei

Shefali Gupta

On Tue, Nov 27, 2018 at 8:07 PM Jonathan Morton <chromatix99@gmail.com> wrote:

> On 27 Nov, 2018, at 4:10 pm, Jendaipou Palmei <jendaipoupalmei@gmail.com> wrote:
>
> We have made the changes in the code as suggested.
>
> Here is the diff after making the changes:
>
> https://github.com/Daipu/COBALT/commit/033db330287e2072bad94ac441f8aed774678a7d
>
> Additionally, we have also updated the values of 'Pincrement' and 'Pdecrement' (parameters of BLUE) in ns-3 to match the ones used in the Cake implementation in Linux.
>
> Does the diff look correct?

It does look like an improvement. How's the behaviour?

NB: the decimal values used in the constants are not quite precise equivalents of the Linux values, since you have dropped some of the trailing digits. You could use (1./256) and (1./4096) to both make them precise and more human-readable.

- Jonathan Morton