From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb1-xb29.google.com (mail-yb1-xb29.google.com [IPv6:2607:f8b0:4864:20::b29]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 5568F3B2A4 for ; Fri, 25 Jan 2019 03:35:43 -0500 (EST) Received: by mail-yb1-xb29.google.com with SMTP id n78so3505608yba.12 for ; Fri, 25 Jan 2019 00:35:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qJyksVWyPnn6w6FYmtGsY07OWatk1iRh9UFZOZI/0KU=; b=E0TqcGgQBRA+JQFSXiPw7z0QjBGrD4jP4HBXzcx8guSBr9Zj4WLzFKxfyfLwl0QpZi 53/8LEOvifElqAOODR1FkZQHkwltnc9BlJb6MH9noUzHp1yEgfgCtdqiaDeQvfY2VKhe s1CMZnVgBXWwkTHQGisqaq4m4lpJJC+mySmEal3mVa1HNWyFSm7pKnVcwluJKEwqNF3g 8BOmiB+gwbsfBp+cg98INK7cWIQ3pvDHd7pQmgJ41XX95gPJ3itKFpr2rHuG/VzHOY3h imxBcpC1jsfQERPvnphHPKJhkBPW3Eob9Wgbr0zFNSyMpPODd4XztlON5tDLIQmtYgZJ Wisg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qJyksVWyPnn6w6FYmtGsY07OWatk1iRh9UFZOZI/0KU=; b=ZKMkj80yx/QWH+/ghHnlxI/zMYtiON8EISsNopfSgsWY9Q4gXpQDozOkp6LQSYUIOH e1TWq4O+v1AwlmtYIQyaTSUFwwGJZeGPF+Hbqr2EoZ/uzfMdB+nsIWwcVNOuQQNyKdYa CHYGA+q/YS1PTJFct6uc5Eu9wg6vmNr5rlYLz63hUBZ3hLX3JPcGjzdD7mokpDytzN5b YTpQNIU8hV0/Ci+UaC7AmOTBAzOU8Yvv7/qUw7gVJdu/DAHJi14eOkobRHLBbF4NXDxE uW2NTT0bp7YDQo5nE56uq/rgLLm8n6zZsbcObGMVgVW4Z+YWgVRddQP7ONMIihUG5jEd 73JA== X-Gm-Message-State: AJcUukfJ11Wm77mczful/A2u48FpNczxEC9my4okfwTl0F6RCki44Iip WIUA5K0gZhbJF9d83Z7CUnAnrGQP0FoHxIqTxfQ= X-Google-Smtp-Source: ALg8bN5DgNy2diTNFV6s0+wDIcPBBXvLaiIOAHvjNNVKDOvhUN4HByv7HDbLCnNPWx9q+HrfsJfZV08QYfaSuyvizk4= X-Received: by 2002:a25:bb87:: with SMTP id y7mr9772416ybg.321.1548405342632; Fri, 25 Jan 2019 00:35:42 -0800 (PST) MIME-Version: 1.0 References: <87va4nzsn4.fsf@taht.net> <6578A0D1-FF6A-474E-A6D5-98185F98CB45@gmail.com> <08381337-F99A-46D1-87AF-B0F71A8753BC@gmail.com> <949D58FF-9C2F-4516-8547-20A712EC0C92@gmail.com> <271B3584-068F-4FED-B037-B8E920A9EE55@gmail.com> <70BDD881-B509-43FE-81BB-E9C4B1145FA1@gmail.com> <8467184E-7C35-4AFE-9CC6-292215022FDB@gmail.com> <4487BE09-D5D9-4F54-B652-409E50CB4BF4@gmail.com> <75328570-86F6-4BC4-B456-453A4C9FA464@gmail.com> <4F9FBE72-2D10-4A9B-8662-EB1691C935F6@gmail.com> In-Reply-To: From: Shefali Gupta Date: Fri, 25 Jan 2019 14:05:29 +0530 Message-ID: To: Jonathan Morton Cc: Dave Taht , Cake List Content-Type: multipart/alternative; boundary="0000000000006a810f05804436fb" Subject: Re: [Cake] COBALT implementation in ns-3 with results under different traffic scenarios X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jan 2019 08:35:43 -0000 --0000000000006a810f05804436fb Content-Type: text/plain; charset="UTF-8" Hello Jonathan, We have updated all the graphs with updated COBALT code and BQL enabled. Wiki Link: https://github.com/Daipu/COBALT/wiki Diff for COBALT code: https://github.com/Daipu/COBALT/commit/624d0c761b9d1de99499918cb2078195f8b796b5 Thanks and Regards, Shefali Gupta Jendaipou Palmei On Wed 23 Jan 2019, 10:57 p.m. Shefali Gupta Hi Jonathan, > > Thanks! > > First, we noticed that cobalt_cache_init method was not implemented in > ns-3 COBALT, so we implemented it (but this wasn't the main reason for the > wrong behaviour). > > Later, we found that the data types used in the implementation of COBALT > in ns-3 were different from those used in Linux. > > e.g., uint32_t was used instead of int64_t for the variables with > datatype ktime_t in Linux. > > Results improved considerably after these changes. > > We will update the wiki with latest results. > > Regards, > Shefali Gupta > Jendaipou Palmei > > On Wed 23 Jan 2019, 9:53 p.m. Jonathan Morton wrote: > >> > On 23 Jan, 2019, at 6:19 pm, Shefali Gupta >> wrote: >> > >> > We believe we have spotted the issue now. The new plot is attached >> below. >> >> That does look considerably improved. What was the problem in the end? >> >> Now would be a good time to regenerate all the test graphs, and make sure >> there are results for each test for each qdisc tested. Ideally all graphs >> should be generated from the same run(s), to ensure their data is mutually >> consistent. >> >> - Jonathan Morton >> >> --0000000000006a810f05804436fb Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello Jonathan,

We have updated all the graphs with updated COB= ALT code and BQL enabled.

Wiki Link:

Diff for COBALT code:
https://github.c= om/Daipu/COBALT/commit/624d0c761b9d1de99499918cb2078195f8b796b5

<= /div>
Th= anks and Regards,
Shefali Gupta
Jendaipou Palmei

On Wed 23 Jan 2019, 10:57 p.m. Shefali Gu= pta <shefaligups11@gmail.com<= /a> wrote:
Hi Jonathan,<= /div>
Thanks!

First, we noticed that=C2=A0cobalt_cache_init method was not impl= emented in ns-3 COBALT, so we=C2=A0implemented=C2=A0it (but this wasn't= the main reason for the wrong behaviour).

Later, we found that the data t= ypes used in the implementation of COBALT in ns-3=C2=A0 were different from= those used in Linux.

e.g., uint32_t was used instead of int64_t for the v= ariables with datatype=C2=A0ktime_t in Linux.

Results improved considerabl= y after these changes.

We will update the wiki with latest results.

=
R= egards,
Shefali Gupta
Jendaipou Palmei

> = On 23 Jan, 2019, at 6:19 pm, Shefali Gupta <shefaligups1= 1@gmail.com> wrote:
>
> We believe we have spotted the issue now. The new plot is attached bel= ow.

That does look considerably improved.=C2=A0 What was the problem in the end= ?

Now would be a good time to regenerate all the test graphs, and make sure t= here are results for each test for each qdisc tested.=C2=A0 Ideally all gra= phs should be generated from the same run(s), to ensure their data is mutua= lly consistent.

=C2=A0- Jonathan Morton

--0000000000006a810f05804436fb--