From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-x243.google.com (mail-lf0-x243.google.com [IPv6:2a00:1450:4010:c07::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 12E7C3B25D for ; Thu, 19 May 2016 06:44:09 -0400 (EDT) Received: by mail-lf0-x243.google.com with SMTP id y84so5304905lfc.3 for ; Thu, 19 May 2016 03:44:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to; bh=y6tvgSvjT31gDxNuoHC9ua7IugE+mTd5fx2033Bb6UE=; b=y8a4fjo6iPbbCyd7AkIIlzLuqVSsy5ItKuPteqYFdggPsfnd0qoP74owuEAAzBTne6 yq0y+6tUx3DpeTXBR6graDj4YilbtJsBNZMGFqZMSHHfTYH1DHwtqPHkTdxMAQqfEL+M jgk5Js82n9rs5Vh93QFk7eTG7CPt+jhQ5P+qTLTuTw+IchJ8yyn979oWjbl1UwbFSmCp xzqF/HcP7zFb+bFcWUQxpok5bHWoTuzL1QuNgf4toBz16SsCw+r4mBM+6NWInbpeFb6q dP+yoVM0qqxToAnKOA+j+vxt9s9rpLzAT1PzYv2X1MjPb2i8ce/OIK29R9m7bDtUUz+s Xiqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:date:message-id:subject:from:to; bh=y6tvgSvjT31gDxNuoHC9ua7IugE+mTd5fx2033Bb6UE=; b=Yhvl2jRvzO/vBAfy3p3OGKHYP8PnhX8JSDc7dzNbjCjDGzXohpKrQJBqT/CKxh+eGR RtqAONDPRLRnkqZt3wJd0DReHFVf96FidwQAKmfbAWoI2UHQxzORhz94aLbar0SNj9q+ b99ed/D3mbbH2mvBslwB1ZQk87cd8oI85Ps7SjSRPvBIkYebz5bdq+s5blRWkPGTl2fA eEE++qutNmjMNMjuxfdGgvhFa9M1KbyzI9eS/m9aaf6/6B8IVfTKN/O5mbzQHGmuKWYa bBBiSimrPaAej9EQDrrr1aOabOTMsbsO4PRVPi+3yhxeAphwpyJiiG6GyQCPbfz9cW4V k4TQ== X-Gm-Message-State: AOPr4FV7Vm03qjN/1TUjaZisV07ioXhg9QbKO5rcUSNyZAxns7feOyq+k2WqzU9Us0G8gHCZA7KWkn03JsIzmw== MIME-Version: 1.0 X-Received: by 10.112.16.6 with SMTP id b6mr4289125lbd.13.1463654647827; Thu, 19 May 2016 03:44:07 -0700 (PDT) Received: by 10.25.156.210 with HTTP; Thu, 19 May 2016 03:44:07 -0700 (PDT) Date: Thu, 19 May 2016 06:44:07 -0400 Message-ID: From: LeetMniWheat To: cake@lists.bufferbloat.net Content-Type: multipart/alternative; boundary=001a11c322ee5b93ef05332fa7dd Subject: [Cake] sch_cake broken on 4.4.11 and 4.5.5? X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 May 2016 10:44:09 -0000 --001a11c322ee5b93ef05332fa7dd Content-Type: text/plain; charset=UTF-8 For those not follow following sch_cake on github or the latest kernels changes; due to recent updates to net_sched backported from 4.6 to kernels 4.4.11 and 4.5.5, the current sch_cake code on github needs an update and I believe is unsuitable for use at this time (though I am in no way an authoritative source on this matter). Since OpenWRT/LEDE is planning 4.4.x for the next release I thought it relevant to post this since I've had quite a few headaches troubleshooting kernel BUG checks and stack traces which are presumably related. There's a simple bandaid fix in issue #20 in sch_cake.c which changes the following: #if KERNEL_VERSION(4, 6, 0) > LINUX_VERSION_CODE to: #if KERNEL_VERSION(4, 4, 0) > LINUX_VERSION_CODE Although now it should probably be (4, 4, 11) and above, but I believe these issues stem a bit deeper than this can fix since I've seen stack traces with layer_cake.qos with kernel 4.4.10 (with original code) and on kernel 4.4.11 with the bandaid fix. I must also point out that my own issues could be a platform-specific for x86/Debian, though chromi@github had commented previously that the current code is unstable with diffserv turned on so I am unsure if this is related but I have not been able to reproduce the stack traces after removing sch_cake. Relevant links: https://github.com/dtaht/sch_cake/issues/20 https://git.kernel.org/cgit/linux/kernel/git/stable/stable-queue.git/tree/releases/4.4.11 https://git.kernel.org/cgit/linux/kernel/git/stable/stable-queue.git/tree/releases/4.5.5 --001a11c322ee5b93ef05332fa7dd Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
For those not follow following sch_cake on github or the l= atest kernels changes;
due to recent updates to net_sched backported fro= m 4.6 to kernels 4.4.11 and
4.5.5, the current sch_cake code on github n= eeds an update and I believe is
unsuitable for use at this time (though = I am in no way an authoritative source
on this matter). Since OpenWRT/LE= DE is planning 4.4.x for the next release I
thought it relevant to post = this since I've had quite a few headaches
troubleshooting kernel BUG= checks and stack traces which are presumably related.

There's a= simple bandaid fix in issue #20 in sch_cake.c
which changes the followi= ng:

#if KERNEL_VERSION(4, 6, 0) > LINUX_VERSION_CODE
to:
#i= f KERNEL_VERSION(4, 4, 0) > LINUX_VERSION_CODE

Although now it sh= ould probably be (4, 4, 11) and above, but I believe these
issues stem a= bit deeper than this can fix since I've seen stack traces with
laye= r_cake.qos with kernel 4.4.10 (with original code) and on kernel 4.4.11
= with the bandaid fix.

I must also point out that my own issues could= be a platform-specific for
x86/Debian, though chromi@github had comment= ed previously that the current code
is unstable with diffserv turned on = so I am unsure if this is related but I
have not been able to reproduce = the stack traces after removing sch_cake.

Relevant links:
https://github.com/dtaht/s= ch_cake/issues/20
https://git.kernel.org/= cgit/linux/kernel/git/stable/stable-queue.git/tree/releases/4.4.11
<= a href=3D"https://git.kernel.org/cgit/linux/kernel/git/stable/stable-queue.= git/tree/releases/4.5.5">https://git.kernel.org/cgit/linux/kernel/git/stabl= e/stable-queue.git/tree/releases/4.5.5
--001a11c322ee5b93ef05332fa7dd--