From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mail.toke.dk; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=GyyKma8D; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=kernel.org policy.dmarc=quarantine Received: from sea.source.kernel.org (sea.source.kernel.org [IPv6:2600:3c0a:e001:78e:0:1991:8:25]) by mail.toke.dk (Postfix) with ESMTPS id 2A00C185F208 for ; Mon, 19 Oct 2026 16:53:39 +0200 (CEST) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 9AF4A4400E for ; Mon, 19 Oct 2026 14:53:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 837B51F000CC for ; Mon, 19 Oct 2026 14:53:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1792421616; bh=S+Ym8tXJWpZWXVR5/0qvx3lNlnmmr/1Btzux3EG85GU=; h=References:In-Reply-To:From:Date:Subject:To:Cc; b=GyyKma8DEU8LSTI4xyIJlBMuM+HXHkGaNJeSbmUgefuKybsGpD1Oz3fL/0N77Lnu3 H5IcY7wSRBUaMST+xRC8fj110MbaTlz3hInidel759VJhyqt6GEq58hav0GWR2ttj2 0xtHAh5nS+49iqvgzvFtzk95WDcGlKeYC8MvHuMXMT1/hechZLKrqoYOyq95+5ssxV u49V/SNquRCLfT2H9ZYWIW/YXQiq/+vZkYIdiXZriAHtPzsOpZSdf9ew0qDrg6O0bl X8FEWZ0XjyMkC+wMW42hCfeCgDiim1FnjBXrRsXvnqCNmV3DihemtbbijjY7Ogiyhh BioEpKqzOmACg== Received: by mail-qv1-f54.google.com with SMTP id 6a1803df08f44-91bb5795792so21204076d6.2 for ; Mon, 19 Oct 2026 07:53:36 -0700 (PDT) X-Forwarded-Encrypted: i=1; AKwUvBwoLQuzSuglY+OZ/0yjI1ETR/cVMfQvkRS9cWBqL66suImMwzmC3bkYkmuv08dE8654/KY5@lists.bufferbloat.net X-Gm-Message-State: AFq9FYICODA32MJhr8s3No/f55d7UYDGKdUJMLCv17MzrwCufdl1oKPn HduBO0e5Odb9A+rTgng/Jq4kRs+ND+uad0bpBT5okbLSqUpGF1JA657qiA6cL7qd0hiLPEshwLa V40DviJrDLWvev1z+osiHXUnDiOIjGeY= X-Received: by 2002:a05:620a:17a2:b0:92e:bc28:5479 with SMTP id af79cd13be357-93f29b7fa33mr1291629285a.2.1792421615693; Mon, 19 Oct 2026 07:53:35 -0700 (PDT) MIME-Version: 1.0 References: <87ld7t3kl3.fsf@all.your.base.are.belong.to.us> In-Reply-To: From: =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= Date: Mon, 19 Oct 2026 16:53:23 +0200 X-Gmail-Original-Message-ID: X-Gm-Features: AclHuK8qzzgheaqrj_7NZPjxMNt7VBnt0bxhEsZWkBPMHkeW-T9XNuxRdU9gNI0 Message-ID: To: Jamal Hadi Salim Cc: netdev@vger.kernel.org, =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= , Jiri Pirko , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , cake@lists.bufferbloat.net, Victor Nogueira , Sashiko Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-MailFrom: bjorn@kernel.org X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation Message-ID-Hash: BWD46AIZXOM6J5O2IGKKQIEX7RUCS6NL X-Message-ID-Hash: BWD46AIZXOM6J5O2IGKKQIEX7RUCS6NL X-Mailman-Approved-At: Mon, 19 Oct 2026 19:51:57 +0200 X-Mailman-Version: 3.3.10 Precedence: list Subject: [Cake] Re: [PATCH net-next v2 1/4] net/sched/sch_cake: serialize reconfiguration with the datapath List-Id: Cake - FQ_codel the next generation Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Jamal! On Mon, 19 Oct 2026 at 15:47, Jamal Hadi Salim wrote: > > Hey Bj=C3=B6rn, > > On Mon, Oct 19, 2026 at 9:07=E2=80=AFAM Bj=C3=B6rn T=C3=B6pel wrote: > > > > Jamal Hadi Salim writes: > > > > > This is a follow-up to commit 7cbfb180945c ("net/sched: sch_cake: fix > > > autorate reconfiguration throttling"). That change only stored > > > last_reconfig_time; it did not address the concurrency between the > > > autorate rate update in cake_enqueue() and the netlink reconfiguratio= n > > > path, which the original review flagged. > > > > > You are reviewing a very old version - the last one was a v6[1], most > of these fixes are in the "no good deed goes unpunished" from sashiko > ;-> > I am about to post a v7. Maybe review that one? OMG... sorry for the noise. Bj=C3=B6rn