From: Jonathan Morton <chromatix99@gmail.com>
To: Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk>
Cc: cake@lists.bufferbloat.net
Subject: Re: [Cake] cake review comments cake_drop
Date: Sun, 4 Oct 2015 12:03:15 +0300 [thread overview]
Message-ID: <CAJq5cE0U4V8xkVNzg3_muvj0_uCZKk9D5SAngDvcT-QsqzHG5g@mail.gmail.com> (raw)
In-Reply-To: <56102F88.8070201@darbyshire-bryant.me.uk>
[-- Attachment #1: Type: text/plain, Size: 413 bytes --]
I remember changing cake_drop so that it iterated over the list of active
flows rather than the whole potential array. Hence an inactive class, which
has no active queues, costs nothing to iterate over. Usually the total
number of active queues is tolerably small.
Conversely I don't precisely remember the sequence of events for reducing
the class count, so this change might well break it.
- Jonathan Morton
[-- Attachment #2: Type: text/html, Size: 477 bytes --]
next prev parent reply other threads:[~2015-10-04 9:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-03 19:42 Kevin Darbyshire-Bryant
2015-10-04 9:03 ` Jonathan Morton [this message]
2015-10-04 10:56 ` Sebastian Moeller
2015-10-04 17:46 ` Kevin Darbyshire-Bryant
2015-10-05 7:27 ` Sebastian Moeller
2015-10-04 10:50 ` Sebastian Moeller
2015-10-04 17:23 ` Kevin Darbyshire-Bryant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJq5cE0U4V8xkVNzg3_muvj0_uCZKk9D5SAngDvcT-QsqzHG5g@mail.gmail.com \
--to=chromatix99@gmail.com \
--cc=cake@lists.bufferbloat.net \
--cc=kevin@darbyshire-bryant.me.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox