From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yk0-x232.google.com (mail-yk0-x232.google.com [IPv6:2607:f8b0:4002:c07::232]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by huchra.bufferbloat.net (Postfix) with ESMTPS id AE9CC21F7EA for ; Sun, 4 Oct 2015 02:03:19 -0700 (PDT) Received: by ykdg206 with SMTP id g206so145236388ykd.1 for ; Sun, 04 Oct 2015 02:03:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=8T5z2UXQEnnoyuwn4yHXgg4d5eai+SbqjEBnEMPW7+Q=; b=mLlp9U8r/QNCBLeL2RquoHaCJSPKOzKwRci9Vus+RMmtrWWG+rQPe63vGIpvIV8HLT uWUjY6XMIJUE7eicnmd82qnx7BDDzucmqC1uyR8sCDcjZC7w+73wCPy/m7+8kWYIWriN ipWFK7G7IZlIYqoE6UklBWuHl5qjd0DEq2sl/x5Bluw9iCsNW3xNaBWVfzhjCI4KEWMi 8/crkLkCyOmavCjmwG8vHXKYT2eDNoyZG2SRkfGb3+PbAnh0XF29BWy8rGR1QfWw56y2 cHL6HzpuEa3uU9eDDFAa0aH7HzhydCa2LA8vyNG8yMvpZs07rhdxZEu9zIwx4eseFTj8 y80Q== MIME-Version: 1.0 X-Received: by 10.170.217.68 with SMTP id j65mr20160019ykf.9.1443949396133; Sun, 04 Oct 2015 02:03:16 -0700 (PDT) Received: by 10.37.33.66 with HTTP; Sun, 4 Oct 2015 02:03:15 -0700 (PDT) Received: by 10.37.33.66 with HTTP; Sun, 4 Oct 2015 02:03:15 -0700 (PDT) In-Reply-To: <56102F88.8070201@darbyshire-bryant.me.uk> References: <56102F88.8070201@darbyshire-bryant.me.uk> Date: Sun, 4 Oct 2015 12:03:15 +0300 Message-ID: From: Jonathan Morton To: Kevin Darbyshire-Bryant Content-Type: multipart/alternative; boundary=001a113a4368d48f67052143aaf7 Cc: cake@lists.bufferbloat.net Subject: Re: [Cake] cake review comments cake_drop X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.13 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 04 Oct 2015 09:03:42 -0000 --001a113a4368d48f67052143aaf7 Content-Type: text/plain; charset=UTF-8 I remember changing cake_drop so that it iterated over the list of active flows rather than the whole potential array. Hence an inactive class, which has no active queues, costs nothing to iterate over. Usually the total number of active queues is tolerably small. Conversely I don't precisely remember the sequence of events for reducing the class count, so this change might well break it. - Jonathan Morton --001a113a4368d48f67052143aaf7 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

I remember changing cake_drop so that it iterated over the l= ist of active flows rather than the whole potential array. Hence an inactiv= e class, which has no active queues, costs nothing to iterate over.=C2=A0 U= sually the total number of active queues is tolerably small.

Conversely I don't precisely remember the sequence of ev= ents for reducing the class count, so this change might well break it.

- Jonathan Morton

--001a113a4368d48f67052143aaf7--