[Cake] is there a patch for tc-adv somewhere for showing active_flows

[Cake] is there a patch for tc-adv somewhere for showing active_flows

[Dave Taht]

I seem to recall one... and also doing up
a patch to cake that shipped it

don't see it...

boy it has been a while

-- 
Dave Täht
Do you want faster, better, wifi? https://www.patreon.com/dtaht

Re: [Cake] is there a patch for tc-adv somewhere for showing active_flows

[Kevin Darbyshire-Bryant]

[-- Attachment #1: Type: text/plain, Size: 1517 bytes --]

On 29/09/15 12:12, Dave Taht wrote:
> I seem to recall one... and also doing up
> a patch to cake that shipped it
>
> don't see it...
>
> boy it has been a while
>

Are you thinking of Toke's iproute2 repo?
http://kau.toke.dk/git/cake/iproute2/  -  There's something there which
adds cake stats and I think is the real source of the pull request I
recently sent you.

Your tc-adv repo never got those updates and since openwrt references
the cerowrt-packages repo which then reference your cake, pie & tc-adv
repos neither did it.

The situation is I think best described as lacking clarity.  Certainly
I've found it confusing and ended up maintaining my own branch of
cerowrt-packages, and in some cases (eg tc-adv sparse/bulk/active flows)
generated quilt style patches for my local openwrt build. 

Ideally I'd have offered this to all here, the closest I got was a quick
write-up of some build instructions.  I do know how time consuming this
can become.

As a 'for example' the recent changes to cake & tc-adv should also
result in cerowrt-packages having the git SHA ref updated in the package
Makefiles.  That way at least cerowrt-package subscribers get to test
the bleeding edge code :-)

I've no idea how this then gets into upstream openwrt.  I'm willing to
try and maintain as long as I get some support, otherwise I'm going to
find myself doing a lot of guessing again which is exhausting.

Happy to receive private emails :-)

Kevin (onboard train dodgy wifi)



[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4816 bytes --]

Re: [Cake] is there a patch for tc-adv somewhere for showing active_flows

[Toke Høiland-Jørgensen]

Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk> writes:

> I've no idea how this then gets into upstream openwrt.

One idea for this, which I tried poking into but didn't get to work:
Supposedly, iproute2 contains a facility to load qdisc support as a
shared library. If we could get this to work, we could include a
'cake.so' for iproute along with the kernel module (or in a separate
package), and thus not have to replace the stock 'tc' package. That
would presumably be easier to upstream...(?)

-Toke

Re: [Cake] is there a patch for tc-adv somewhere for showing active_flows

[Dave Taht]

No it would be easiest to just submit a normal patch to iproute
upstream, when the api is done. no muss, no fuss. But we are due for
an api change.

On Tue, Sep 29, 2015 at 6:15 AM, Toke Høiland-Jørgensen <toke@toke.dk> wrote:
> Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk> writes:
>
>> I've no idea how this then gets into upstream openwrt.
>
> One idea for this, which I tried poking into but didn't get to work:
> Supposedly, iproute2 contains a facility to load qdisc support as a
> shared library. If we could get this to work, we could include a
> 'cake.so' for iproute along with the kernel module (or in a separate
> package), and thus not have to replace the stock 'tc' package. That
> would presumably be easier to upstream...(?)
>
> -Toke
> _______________________________________________
> Cake mailing list
> Cake@lists.bufferbloat.net
> https://lists.bufferbloat.net/listinfo/cake



-- 
Dave Täht
Do you want faster, better, wifi? https://www.patreon.com/dtaht

Re: [Cake] is there a patch for tc-adv somewhere for showing active_flows

[Toke Høiland-Jørgensen]

Dave Taht <dave.taht@gmail.com> writes:

> No it would be easiest to just submit a normal patch to iproute
> upstream, when the api is done. no muss, no fuss. But we are due for
> an api change.

Yes, except that this requires a stable ABI. Which we don't currently
have...

-Toke

Re: [Cake] is there a patch for tc-adv somewhere for showing active_flows

[Sebastian Moeller]

HI Dave, hi list,

On Sep 29, 2015, at 15:24 , Dave Taht <dave.taht@gmail.com> wrote:

> No it would be easiest to just submit a normal patch to iproute
> upstream, when the api is done. no muss, no fuss. But we are due for
> an api change.

	What change is due? Sorry to ask, but I genuinely seem to have missed the cake boat…

Best Regards
	Sebastian

> 
> On Tue, Sep 29, 2015 at 6:15 AM, Toke Høiland-Jørgensen <toke@toke.dk> wrote:
>> Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk> writes:
>> 
>>> I've no idea how this then gets into upstream openwrt.
>> 
>> One idea for this, which I tried poking into but didn't get to work:
>> Supposedly, iproute2 contains a facility to load qdisc support as a
>> shared library. If we could get this to work, we could include a
>> 'cake.so' for iproute along with the kernel module (or in a separate
>> package), and thus not have to replace the stock 'tc' package. That
>> would presumably be easier to upstream...(?)
>> 
>> -Toke
>> _______________________________________________
>> Cake mailing list
>> Cake@lists.bufferbloat.net
>> https://lists.bufferbloat.net/listinfo/cake
> 
> 
> 
> -- 
> Dave Täht
> Do you want faster, better, wifi? https://www.patreon.com/dtaht
> _______________________________________________
> Cake mailing list
> Cake@lists.bufferbloat.net
> https://lists.bufferbloat.net/listinfo/cake

Re: [Cake] is there a patch for tc-adv somewhere for showing active_flows

[Dave Taht]

On Tue, Sep 29, 2015 at 7:22 AM, Sebastian Moeller <moeller0@gmx.de> wrote:
> HI Dave, hi list,
>
> On Sep 29, 2015, at 15:24 , Dave Taht <dave.taht@gmail.com> wrote:
>
>> No it would be easiest to just submit a normal patch to iproute
>> upstream, when the api is done. no muss, no fuss. But we are due for
>> an api change.
>
>         What change is due? Sorry to ask, but I genuinely seem to have missed the cake boat…

We can delete two variables from xstats (lastcount and one other). We
need to add support for at least setting the interval (I do not think
we want to expose the target). You have made other suggestions.

I would like to be able to hash on src/dst src and dst macaddrs also,
but that's not an api change.

other needed api changes?

> Best Regards
>         Sebastian
>
>>
>> On Tue, Sep 29, 2015 at 6:15 AM, Toke Høiland-Jørgensen <toke@toke.dk> wrote:
>>> Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk> writes:
>>>
>>>> I've no idea how this then gets into upstream openwrt.
>>>
>>> One idea for this, which I tried poking into but didn't get to work:
>>> Supposedly, iproute2 contains a facility to load qdisc support as a
>>> shared library. If we could get this to work, we could include a
>>> 'cake.so' for iproute along with the kernel module (or in a separate
>>> package), and thus not have to replace the stock 'tc' package. That
>>> would presumably be easier to upstream...(?)
>>>
>>> -Toke
>>> _______________________________________________
>>> Cake mailing list
>>> Cake@lists.bufferbloat.net
>>> https://lists.bufferbloat.net/listinfo/cake
>>
>>
>>
>> --
>> Dave Täht
>> Do you want faster, better, wifi? https://www.patreon.com/dtaht
>> _______________________________________________
>> Cake mailing list
>> Cake@lists.bufferbloat.net
>> https://lists.bufferbloat.net/listinfo/cake
>



-- 
Dave Täht
Do you want faster, better, wifi? https://www.patreon.com/dtaht

Re: [Cake] is there a patch for tc-adv somewhere for showing active_flows

[Jonathan Morton]

[-- Attachment #1: Type: text/plain, Size: 223 bytes --]

The big api change is in the stats output, which I'm still working on.  As
a stop gap, I have already pushed a version with both sparse and bulk flows
reporting.

The config api is inherently extensible.

- Jonathan Morton

[-- Attachment #2: Type: text/html, Size: 287 bytes --]

Re: [Cake] is there a patch for tc-adv somewhere for showing active_flows

[Kevin Darbyshire-Bryant]

[-- Attachment #1: Type: text/plain, Size: 822 bytes --]

Dave,

I've pulled the commits from Toke's iproute2 repo in which Jonathan is
placing his stats & other tweaks and sent you a pull request:
https://github.com/dtaht/tc-adv/pull/3 to get them into your tc-adv repo
(which is slightly more cero/openwrt facing)

All the recent changes to cake & tc are running here.... livin' on the
bleeding edge :-)

Kevin



On 29/09/15 16:22, Jonathan Morton wrote:
>
> The big api change is in the stats output, which I'm still working
> on.  As a stop gap, I have already pushed a version with both sparse
> and bulk flows reporting.
>
> The config api is inherently extensible.
>
> - Jonathan Morton
>
>
>
> _______________________________________________
> Cake mailing list
> Cake@lists.bufferbloat.net
> https://lists.bufferbloat.net/listinfo/cake



[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4816 bytes --]

Re: [Cake] is there a patch for tc-adv somewhere for showing active_flows

[Dave Taht]

done. so nice to be making so much forward progress again.

still always in search of comments and text for:

https://docs.google.com/document/d/1VTOHEpRXSvhWvQ0leM-sROJ_XC7Fk1WjFXq57ysFtAA/edit?usp=sharing

On Wed, Sep 30, 2015 at 2:55 AM, Kevin Darbyshire-Bryant
<kevin@darbyshire-bryant.me.uk> wrote:
> Dave,
>
> I've pulled the commits from Toke's iproute2 repo in which Jonathan is
> placing his stats & other tweaks and sent you a pull request:
> https://github.com/dtaht/tc-adv/pull/3 to get them into your tc-adv repo
> (which is slightly more cero/openwrt facing)
>
> All the recent changes to cake & tc are running here.... livin' on the
> bleeding edge :-)
>
> Kevin
>
>
>
> On 29/09/15 16:22, Jonathan Morton wrote:
>>
>> The big api change is in the stats output, which I'm still working
>> on.  As a stop gap, I have already pushed a version with both sparse
>> and bulk flows reporting.
>>
>> The config api is inherently extensible.
>>
>> - Jonathan Morton
>>
>>
>>
>> _______________________________________________
>> Cake mailing list
>> Cake@lists.bufferbloat.net
>> https://lists.bufferbloat.net/listinfo/cake
>
>
>
> _______________________________________________
> Cake mailing list
> Cake@lists.bufferbloat.net
> https://lists.bufferbloat.net/listinfo/cake
>



-- 
Dave Täht
Do you want faster, better, wifi? https://www.patreon.com/dtaht

Re: [Cake] is there a patch for tc-adv somewhere for showing active_flows

[Sebastian Moeller]

Jonathan,

is Tokes repository the next best to master, or will all eventually accumulate in Dave’s repository? I just wonder which iproute2 to actually build on my test machine ;)

Best Regards
	Sebastian

On Sep 30, 2015, at 11:55 , Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk> wrote:

> Dave,
> 
> I've pulled the commits from Toke's iproute2 repo in which Jonathan is
> placing his stats & other tweaks and sent you a pull request:
> https://github.com/dtaht/tc-adv/pull/3 to get them into your tc-adv repo
> (which is slightly more cero/openwrt facing)
> 
> All the recent changes to cake & tc are running here.... livin' on the
> bleeding edge :-)
> 
> Kevin
> 
> 
> 
> On 29/09/15 16:22, Jonathan Morton wrote:
>> 
>> The big api change is in the stats output, which I'm still working
>> on.  As a stop gap, I have already pushed a version with both sparse
>> and bulk flows reporting.
>> 
>> The config api is inherently extensible.
>> 
>> - Jonathan Morton
>> 
>> 
>> 
>> _______________________________________________
>> Cake mailing list
>> Cake@lists.bufferbloat.net
>> https://lists.bufferbloat.net/listinfo/cake
> 
> 
> _______________________________________________
> Cake mailing list
> Cake@lists.bufferbloat.net
> https://lists.bufferbloat.net/listinfo/cake

Re: [Cake] is there a patch for tc-adv somewhere for showing active_flows

[Dave Taht]

at the moment it seems best to keep working these out of tree versions, imho.

On Wed, Sep 30, 2015 at 4:27 AM, Sebastian Moeller <moeller0@gmx.de> wrote:
> Jonathan,
>
> is Tokes repository the next best to master, or will all eventually accumulate in Dave’s repository? I just wonder which iproute2 to actually build on my test machine ;)
>
> Best Regards
>         Sebastian
>
> On Sep 30, 2015, at 11:55 , Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk> wrote:
>
>> Dave,
>>
>> I've pulled the commits from Toke's iproute2 repo in which Jonathan is
>> placing his stats & other tweaks and sent you a pull request:
>> https://github.com/dtaht/tc-adv/pull/3 to get them into your tc-adv repo
>> (which is slightly more cero/openwrt facing)
>>
>> All the recent changes to cake & tc are running here.... livin' on the
>> bleeding edge :-)
>>
>> Kevin
>>
>>
>>
>> On 29/09/15 16:22, Jonathan Morton wrote:
>>>
>>> The big api change is in the stats output, which I'm still working
>>> on.  As a stop gap, I have already pushed a version with both sparse
>>> and bulk flows reporting.
>>>
>>> The config api is inherently extensible.
>>>
>>> - Jonathan Morton
>>>
>>>
>>>
>>> _______________________________________________
>>> Cake mailing list
>>> Cake@lists.bufferbloat.net
>>> https://lists.bufferbloat.net/listinfo/cake
>>
>>
>> _______________________________________________
>> Cake mailing list
>> Cake@lists.bufferbloat.net
>> https://lists.bufferbloat.net/listinfo/cake
>
> _______________________________________________
> Cake mailing list
> Cake@lists.bufferbloat.net
> https://lists.bufferbloat.net/listinfo/cake



-- 
Dave Täht
Do you want faster, better, wifi? https://www.patreon.com/dtaht

Re: [Cake] is there a patch for tc-adv somewhere for showing active_flows

[Kevin Darbyshire-Bryant]

[-- Attachment #1: Type: text/plain, Size: 3224 bytes --]



On 30/09/15 12:28, Dave Taht wrote:
> at the moment it seems best to keep working these out of tree versions, imho.

The 'problem' with that Dave is that there are people here keen to be on
the latest commits so that they may test the latest 'n' greatest code. 
Who doesn't want a willing set of fools^H^H^H^H^H^H testers trying to
break code for free? :-)

You've mentioned how great it is that things have been moving well
recently, yes it is!  I'd say that some of that is down to someone in
essence doing a bit of janitorial work in collecting commits together
and pushing them into a central-ish repo, namely yours.  Personally
speaking sending to your repo makes more sense as that's where the
ceropackages repo points the openwrt users to go (well I think that's
the case anyway)

None of this is rocket surgery/brain science, somehow even I seem
capable of merging repos/commits, but having some sort of idea in which
repo active development is taking place so it can be collated & tested
would be a very nice thing :-)

From what I can work out at the moment, your github sch-cake repo is
where you & JM work on the cake module, so hasn't diverged.  JM appears
to work on iproute/tc in Toke's iproute2 repo, but you work on
iproute/tc in your github/tc-adv repo - they did diverge a little, with
trivial merge conflicts.  Are there any more?  What have I missed?

Apologies, I'm a little frustrated by other events at the moment and I
think that may have spilled into this email as well....no hurt/insult
intended.

Kevin

> On Wed, Sep 30, 2015 at 4:27 AM, Sebastian Moeller <moeller0@gmx.de> wrote:
>> Jonathan,
>>
>> is Tokes repository the next best to master, or will all eventually accumulate in Dave’s repository? I just wonder which iproute2 to actually build on my test machine ;)
>>
>> Best Regards
>>         Sebastian
>>
>> On Sep 30, 2015, at 11:55 , Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk> wrote:
>>
>>> Dave,
>>>
>>> I've pulled the commits from Toke's iproute2 repo in which Jonathan is
>>> placing his stats & other tweaks and sent you a pull request:
>>> https://github.com/dtaht/tc-adv/pull/3 to get them into your tc-adv repo
>>> (which is slightly more cero/openwrt facing)
>>>
>>> All the recent changes to cake & tc are running here.... livin' on the
>>> bleeding edge :-)
>>>
>>> Kevin
>>>
>>>
>>>
>>> On 29/09/15 16:22, Jonathan Morton wrote:
>>>> The big api change is in the stats output, which I'm still working
>>>> on.  As a stop gap, I have already pushed a version with both sparse
>>>> and bulk flows reporting.
>>>>
>>>> The config api is inherently extensible.
>>>>
>>>> - Jonathan Morton
>>>>
>>>>
>>>>
>>>> _______________________________________________
>>>> Cake mailing list
>>>> Cake@lists.bufferbloat.net
>>>> https://lists.bufferbloat.net/listinfo/cake
>>>
>>> _______________________________________________
>>> Cake mailing list
>>> Cake@lists.bufferbloat.net
>>> https://lists.bufferbloat.net/listinfo/cake
>> _______________________________________________
>> Cake mailing list
>> Cake@lists.bufferbloat.net
>> https://lists.bufferbloat.net/listinfo/cake
>
>



[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4816 bytes --]

Re: [Cake] is there a patch for tc-adv somewhere for showing active_flows

[Dave Taht]

you now have commit access to both the sch_cake and tc-adv repos.

Anyone else want direct access?

On Thu, Oct 1, 2015 at 2:00 PM, Kevin Darbyshire-Bryant
<kevin@darbyshire-bryant.me.uk> wrote:
>
>
> On 30/09/15 12:28, Dave Taht wrote:
>> at the moment it seems best to keep working these out of tree versions, imho.
>
> The 'problem' with that Dave is that there are people here keen to be on
> the latest commits so that they may test the latest 'n' greatest code.
> Who doesn't want a willing set of fools^H^H^H^H^H^H testers trying to
> break code for free? :-)
>
> You've mentioned how great it is that things have been moving well
> recently, yes it is!  I'd say that some of that is down to someone in
> essence doing a bit of janitorial work in collecting commits together
> and pushing them into a central-ish repo, namely yours.  Personally
> speaking sending to your repo makes more sense as that's where the
> ceropackages repo points the openwrt users to go (well I think that's
> the case anyway)
>
> None of this is rocket surgery/brain science, somehow even I seem
> capable of merging repos/commits, but having some sort of idea in which
> repo active development is taking place so it can be collated & tested
> would be a very nice thing :-)
>
> From what I can work out at the moment, your github sch-cake repo is
> where you & JM work on the cake module, so hasn't diverged.  JM appears
> to work on iproute/tc in Toke's iproute2 repo, but you work on
> iproute/tc in your github/tc-adv repo - they did diverge a little, with
> trivial merge conflicts.  Are there any more?  What have I missed?
>
> Apologies, I'm a little frustrated by other events at the moment and I
> think that may have spilled into this email as well....no hurt/insult
> intended.
>
> Kevin
>
>> On Wed, Sep 30, 2015 at 4:27 AM, Sebastian Moeller <moeller0@gmx.de> wrote:
>>> Jonathan,
>>>
>>> is Tokes repository the next best to master, or will all eventually accumulate in Dave’s repository? I just wonder which iproute2 to actually build on my test machine ;)
>>>
>>> Best Regards
>>>         Sebastian
>>>
>>> On Sep 30, 2015, at 11:55 , Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk> wrote:
>>>
>>>> Dave,
>>>>
>>>> I've pulled the commits from Toke's iproute2 repo in which Jonathan is
>>>> placing his stats & other tweaks and sent you a pull request:
>>>> https://github.com/dtaht/tc-adv/pull/3 to get them into your tc-adv repo
>>>> (which is slightly more cero/openwrt facing)
>>>>
>>>> All the recent changes to cake & tc are running here.... livin' on the
>>>> bleeding edge :-)
>>>>
>>>> Kevin
>>>>
>>>>
>>>>
>>>> On 29/09/15 16:22, Jonathan Morton wrote:
>>>>> The big api change is in the stats output, which I'm still working
>>>>> on.  As a stop gap, I have already pushed a version with both sparse
>>>>> and bulk flows reporting.
>>>>>
>>>>> The config api is inherently extensible.
>>>>>
>>>>> - Jonathan Morton
>>>>>
>>>>>
>>>>>
>>>>> _______________________________________________
>>>>> Cake mailing list
>>>>> Cake@lists.bufferbloat.net
>>>>> https://lists.bufferbloat.net/listinfo/cake
>>>>
>>>> _______________________________________________
>>>> Cake mailing list
>>>> Cake@lists.bufferbloat.net
>>>> https://lists.bufferbloat.net/listinfo/cake
>>> _______________________________________________
>>> Cake mailing list
>>> Cake@lists.bufferbloat.net
>>> https://lists.bufferbloat.net/listinfo/cake
>>
>>
>
>
>
> _______________________________________________
> Cake mailing list
> Cake@lists.bufferbloat.net
> https://lists.bufferbloat.net/listinfo/cake
>



-- 
Dave Täht
Do you want faster, better, wifi? https://www.patreon.com/dtaht

Re: [Cake] is there a patch for tc-adv somewhere for showing active_flows

[Kevin Darbyshire-Bryant]

[-- Attachment #1: Type: text/plain, Size: 612 bytes --]



On 01/10/15 14:31, Dave Taht wrote:
> you now have commit access to both the sch_cake and tc-adv repos.
>
> Anyone else want direct access?
>

Cheers Dave!

Have I somehow become janitor.....this is one of those 'everyone else
took a step back whilst I looking the other way' scenarios isn't it? :-)

You're gonna hate me but I've just sent 2 pull requests to the
ceropackages-3.10 to bump cake & tc-adv Makefiles to the (b)leading edge
versions.  https://github.com/dtaht/ceropackages-3.10/pulls

Antoine, you might want to be across this too, though I think you
already are ;-)

Kevin


[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4816 bytes --]

Re: [Cake] is there a patch for tc-adv somewhere for showing active_flows

[Dave Taht]

On Thu, Oct 1, 2015 at 3:17 PM, Kevin Darbyshire-Bryant
<kevin@darbyshire-bryant.me.uk> wrote:
>
>
> On 01/10/15 14:31, Dave Taht wrote:
>> you now have commit access to both the sch_cake and tc-adv repos.
>>
>> Anyone else want direct access?
>>
>
> Cheers Dave!
>
> Have I somehow become janitor.....this is one of those 'everyone else
> took a step back whilst I looking the other way' scenarios isn't it? :-)

You've proven yourself, and are eager to drive things further along.

And as fast as people show up capable willing to step up to something,
I step back. It should be pretty clear at this point that I'me totally
overwhelmed...

All I ask is that you communicate when you are going to have to drop
out (vacation, work, etc), so others can step up.

also:

I note that a really major thing stopping me from considering another
cerowrt-scale effort - tackling ease of install, homenet, wifi,
uptime, in addition to queue managment -  is
that I am not kidding about my PTFD (post traumatic flashing
disorder). It was my hope to make build and testing - and automating
flashes and testing of a testbed, someones's paid gig, but so far no
luck on that.

Or perhaps we can continue to up openwrt's game.

I am pretty happy with how y'all are now driving cake along, but
make-wifi-fast, oh, my....

> You're gonna hate me but I've just sent 2 pull requests to the
> ceropackages-3.10 to bump cake & tc-adv Makefiles to the (b)leading edge
> versions.  https://github.com/dtaht/ceropackages-3.10/pulls
>
> Antoine, you might want to be across this too, though I think you
> already are ;-)

Think toke ? merged those.

> Kevin
>



-- 
Dave Täht
Do you want faster, better, wifi? https://www.patreon.com/dtaht