From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qv1-xf36.google.com (mail-qv1-xf36.google.com [IPv6:2607:f8b0:4864:20::f36]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 67E633CB37 for ; Wed, 4 Aug 2021 07:36:54 -0400 (EDT) Received: by mail-qv1-xf36.google.com with SMTP id d17so893435qvn.13 for ; Wed, 04 Aug 2021 04:36:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=ulJco/J+QCYSGRw6APbs5XS7yXBU8p0kktv8dj9Xj0U=; b=cJxJaf8gPG7zf64dMIFcn75iMEpbcvAB6ar0iVBY/2CcTnpz21o0XiodmcDRQDMsVC TNXFXLOtjK4qmoRftbDjMKBCpDGQpjMOuxuNw/C25Uxjkxi+6UPRtGhXw9U/zXPQ14ck pkE1EVcQLfCvsAfv76bfw5VyhaCkHuFxTJF2q9iXp+xOZ8v/iEUIkYaHbNHSqVWleoqz hF4Lglo/2bBuqLnlnO2td26XZvYRoIe89n/lTmV4YwIkBMiWYInrMKlPNYbkVTV9PiM0 3vO1AVHA0bgGhsklzH+NCBqL9nCfDKY0XD+DaCSOskMrX8L9VvZ/dWhvRbLpQc/BkSlk KaBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=ulJco/J+QCYSGRw6APbs5XS7yXBU8p0kktv8dj9Xj0U=; b=TnneQGwkyZAvo3oDOfBe4s3eiY7yWlfY067UbiUGVGviZEIeIUFrRIyeBaicOzcbJ9 dD/xj0mpWNLdc5s7/iicJkSkOYkLpSb4srZpjgWVfQLx9dmjGUD8e2GTxMzhVfMkDl4R 0O+5oUFEz9iGumrhw+E7X8xfCRTgW3zxqzl5XwvyTMRHG+QyYD32bq/eYkX/TVDLjpYO TEjPbtcUsxes6RwAyoL7yZQIEwHyIARXF5XKxPHRZa9n5EyCPKfayKXdMoee4Dy4tghV mlUQT7kjuSF4MiE1SUm+h9R2bd3gvoz4AdtirKXSaaTQw8bYWlm86zeT3BFmv24BY0hG Fglw== X-Gm-Message-State: AOAM5311cjX1BwqfM3n5+Y7lw7Nou0zilz8h40i91ETwHZNM3BADZvO+ 2ZbDEneR/RanhbA7LWGRlWcCZVVDjQ1PwbMHb14= X-Google-Smtp-Source: ABdhPJy9r8zpykFzy0piz4rmHgzSRd5r4Ce1jLT0arRVBwTbhgpLW4nb/uRz06xBEZ2SsVFwRTsLt0FtV14f3zugIcA= X-Received: by 2002:ad4:5de1:: with SMTP id jn1mr24934568qvb.62.1628077013958; Wed, 04 Aug 2021 04:36:53 -0700 (PDT) MIME-Version: 1.0 References: <3ebc0a3ccdcfa67a48c5ad764ce3389782633fef.camel@heistp.net> <87r1f95und.fsf@toke.dk> In-Reply-To: <87r1f95und.fsf@toke.dk> From: Jonathan Morton Date: Wed, 4 Aug 2021 14:36:43 +0300 Message-ID: To: =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= Cc: Pete Heist , Cake List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [Cake] cake srchost/dsthost stopped working? X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Aug 2021 11:36:54 -0000 On Wed, 4 Aug 2021 at 14:14, Toke H=C3=B8iland-J=C3=B8rgensen via Cake wrote: > > Pete Heist writes: > > > One more tip, reverting this commit seems to fix it: > > > > https://github.com/torvalds/linux/commit/b0c19ed6088ab41dd2a727b60594b7= 297c15d6ce > > Ah, I think I see what the problem is; could you please try the patch > below? > > -Toke > > diff --git a/net/sched/sch_cake.c b/net/sched/sch_cake.c > index 951542843cab..a83c4d4326da 100644 > --- a/net/sched/sch_cake.c > +++ b/net/sched/sch_cake.c > @@ -720,7 +720,7 @@ static u32 cake_hash(struct cake_tin_data *q, const s= truct sk_buff *skb, > skip_hash: > if (flow_override) > flow_hash =3D flow_override - 1; > - else if (use_skbhash) > + else if (use_skbhash && flow_mode & CAKE_FLOW_FLOWS) > flow_hash =3D skb->hash; > if (host_override) { > dsthost_hash =3D host_override - 1; Good catch - I was going to have to wade in and remind myself how this lump of code worked. But shouldn't the masking operation be in brackets, to make the precedence explicit? - Jonathan Morton