From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt0-x236.google.com (mail-qt0-x236.google.com [IPv6:2607:f8b0:400d:c0d::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 942413B29E for ; Sat, 25 Nov 2017 14:04:59 -0500 (EST) Received: by mail-qt0-x236.google.com with SMTP id r39so34735127qtr.13 for ; Sat, 25 Nov 2017 11:04:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=PwWd0aiEbII3QWDbl7VsPd/lZ4aDxUuGnNQtNOA/u/s=; b=M7Tkn0VSdQaYBbFon5vQjyXdqc62RciJhlTdmBi4qbTahNrre56FJibJ0/+7SweDTf LdVR1VAMk2agoDwQQXy3B8eKdPbvyerNbPVYYmUtGvOIMyHdZKRBfgpCUO4XPcVjxojd bEMvdR4OgSnq2xDTYhNpPCPzkQPVjp7jp3T2IlbEcsGQdSQYgNjMcdoYMT96oQXmmcxN D8Pf0QYQ3Uco9pqObEHOXMacV7vYPdGuXIyxmJDh+5eQiAngc25OXaVXNw6RN01jF7v7 8R2GBSZaIfEhowMlDUgWw1NpLukAQnCsONz+xXhfwtdJUxSohbS6oCqsyjfC1DZtlszs u8Qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=PwWd0aiEbII3QWDbl7VsPd/lZ4aDxUuGnNQtNOA/u/s=; b=adfsMFRwhqZc1NCLpvYFdxGsz1SXclZh5pdlPCTLxJi+tAyFrYkQZ/NoUU7nBbPdTE FsX8WTovXNWItai32YWw0eDiD/i6PZO8LejycTxtUzoJADW9mg4eY49C8rjG4MfFmWc3 GNr6q5hEyNBT+XoroG+RKL+h2pdnPn5wm2dM+dV14WCOaTJP6tnxEshzab2dIoGkObZE 52XpeMpiI9YNkmoBP6PSrrU/qLfWiC/05woFzCxfajv19v1TnbLhUW+zsLwG3C73oplm IHtupdXuMCAMQaHcr88kV1IWuMbh3tMWchm7AfJ+FfbzRmgptVltQp4edFmZH0wIXqP1 nkeA== X-Gm-Message-State: AJaThX4zSEYmgkjDBuye65XPL4XZY9cPNHSiKUvh5h0hHoB2/yLUcvfp wexndmLUb0e0n6h7UIvlsVcZF9iBmwNX40HrGNQ= X-Google-Smtp-Source: AGs4zMY3oft7UQmXDisDvXB3ccABZEJa7bFL+/Kh+bF5I6Wzfi/nS/oB33uwjqAA3hwV51ZS+IvlIvxDq6cXvFNGaQA= X-Received: by 10.237.54.227 with SMTP id f90mr51269536qtb.121.1511636699208; Sat, 25 Nov 2017 11:04:59 -0800 (PST) MIME-Version: 1.0 Received: by 10.140.84.85 with HTTP; Sat, 25 Nov 2017 11:04:58 -0800 (PST) Received: by 10.140.84.85 with HTTP; Sat, 25 Nov 2017 11:04:58 -0800 (PST) In-Reply-To: References: <840D255A-5723-4D95-BEF3-50B411A7D0E8@darbyshire-bryant.me.uk> <0D923D70-F9A2-4CB9-A516-B6B80FF4967B@gmail.com> From: Jonathan Morton Date: Sat, 25 Nov 2017 21:04:58 +0200 Message-ID: To: Pete Heist Cc: Dave Taht , Cake List Content-Type: multipart/alternative; boundary="001a114358607c60f8055ed3581d" Subject: Re: [Cake] allocate_src allocate_dst X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Nov 2017 19:04:59 -0000 --001a114358607c60f8055ed3581d Content-Type: text/plain; charset="UTF-8" Gotos are fairly common in kernel code, chiefly for exception handling. Obviously structured code is still preferred where it makes sense, but there are cases where it would actually confuse matters. I hope to be able to spend most of tomorrow going over the code as it currently stands. I even have an up-to-date net-next tree on one of my machines to build against. - Jonathan Morton --001a114358607c60f8055ed3581d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Gotos are fairly common in kernel code, chiefly for exceptio= n handling.=C2=A0 Obviously structured code is still preferred where it mak= es sense, but there are cases where it would actually confuse matters.

I hope to be able to spend most of tomorrow going over the c= ode as it currently stands.=C2=A0 I even have an up-to-date net-next tree o= n one of my machines to build against.

- Jonathan Morton

--001a114358607c60f8055ed3581d--