From: Jonathan Morton <chromatix99@gmail.com>
To: Dave Taht <dave.taht@gmail.com>
Cc: Cake List <cake@lists.bufferbloat.net>
Subject: Re: [Cake] set filtered acks to bulk mode
Date: Wed, 6 Dec 2017 08:08:41 +0200 [thread overview]
Message-ID: <CAJq5cE3+mP_dG3Y+UFQbidJDMxgPZEPULLYmTFQsNa+fBiwTxQ@mail.gmail.com> (raw)
In-Reply-To: <CAA93jw7kkRcvUdz1PZ6u1+FtuZsq8EzHAMs5gPb3Jq_06=-1mw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 689 bytes --]
This is all sorts of wrong.
First, setting the enum isn't sufficient to actually make the flow bulk.
You need to move it to the bulk queue-of-queues and update the stats
counters too. That's probably why it's crashing for Ryan.
Second, I fail to see why this is necessary or even desirable. If there
are enough acks to activate the filter, then I assume it should be treated
as bulk already. Or, if the filter itself thins out the acks enough to
make it sparse, then it still makes sense to deliver those acks timely so
as to maximise the reduced information they carry. Remember too that Codel
implements head drop precisely to minimise the feedback lag via ack.
- Jonathan Morton
[-- Attachment #2: Type: text/html, Size: 783 bytes --]
next prev parent reply other threads:[~2017-12-06 6:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-05 22:00 Dave Taht
2017-12-06 4:59 ` Ryan Mounce
2017-12-06 6:08 ` Jonathan Morton [this message]
2017-12-06 7:05 ` Dave Taht
2017-12-06 8:10 ` Sebastian Moeller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJq5cE3+mP_dG3Y+UFQbidJDMxgPZEPULLYmTFQsNa+fBiwTxQ@mail.gmail.com \
--to=chromatix99@gmail.com \
--cc=cake@lists.bufferbloat.net \
--cc=dave.taht@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox