From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt0-x22e.google.com (mail-qt0-x22e.google.com [IPv6:2607:f8b0:400d:c0d::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 321013BA8E for ; Wed, 6 Dec 2017 01:08:42 -0500 (EST) Received: by mail-qt0-x22e.google.com with SMTP id g10so6416363qtj.12 for ; Tue, 05 Dec 2017 22:08:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=SDD3z22GqG7TYdcc6i4OCcim0bZAOuM7AGaPHfhSZCM=; b=mMB1v36DDm98URAdUoVMaFBfHX8uPlMD7pJmRbSPo7SVlrnMG1oy+Sw85IRtlwk+lB 5a3+qD101Vfjam8PwCgfb2nCtE6C7HOf79Wysw1mM4ciucKL44ICosBGVfEvPhwXHNtl r/N8hujwYbrpC2ukTBDq6QNheikc4oQeFvzt87tB2XCnmrbQh1NMQfvfsbFsafsZbYMh 7Ye+zHMXiSbZck161FzvwocxrkmLeUfa7e44+ON3sc8ft736QDE2T+G2u+fRKVTFi4gz cwRS7cegnwQSVzQt7edMs8AGlOqP1UbUG+L8gDIRO0qtUj7d/EhIH5FZWVIUGANqcRDe nddw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=SDD3z22GqG7TYdcc6i4OCcim0bZAOuM7AGaPHfhSZCM=; b=Ke6QOCg49aPLyRhwy6htFJRxokrIOqhmwXiKz/NnmNur5mVrRjKw3PPnya02Pqd7NK 2QGvWjukBRZLnwxKlfECL5BFjO6hqE/WtQBfgNVoOL8y0dew9Y+MAj7lgh96kvA7Vx38 MgIwvJ0DVNwTjOQWj3QJamxKHFJ+hv09t9bPGGreSSl6P9yyvzoaKT0kfIgEBDjF5neZ LWH1IBlln+IJWSiiM4ih48RYeX4HVnS1BLwijbjZ671ttKw5m1v9/Urb8chS2yf51hrM eaJJhruE5B5i1u4Zj0aqVegU/6V54W9p67wA3vqUupRlJGcUKD/k/1ktVXS+X3m+TxDp 5JcQ== X-Gm-Message-State: AKGB3mKGZiDuAPgTPDuGP97yjYMsqehIbe1hcn+IbTNSZsFQ2VpL0dFK rj7N7y1nGq0DmMVkdTgXdlAbPHQgyL7qpRzZ/mA= X-Google-Smtp-Source: AGs4zMbDMHSuWJLoDJG/3aVeTD0OXrg9Ui4KCoZhKa1Bvx8DVVft3C5FcEU/wo/neYyLO5NPA9cc0b5Z5EhszET5lHY= X-Received: by 10.200.46.50 with SMTP id r47mr3431129qta.314.1512540521812; Tue, 05 Dec 2017 22:08:41 -0800 (PST) MIME-Version: 1.0 Received: by 10.140.102.179 with HTTP; Tue, 5 Dec 2017 22:08:41 -0800 (PST) Received: by 10.140.102.179 with HTTP; Tue, 5 Dec 2017 22:08:41 -0800 (PST) In-Reply-To: References: From: Jonathan Morton Date: Wed, 6 Dec 2017 08:08:41 +0200 Message-ID: To: Dave Taht Cc: Cake List Content-Type: multipart/alternative; boundary="001a1137b0f682d76f055fa5c82b" Subject: Re: [Cake] set filtered acks to bulk mode X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Dec 2017 06:08:42 -0000 --001a1137b0f682d76f055fa5c82b Content-Type: text/plain; charset="UTF-8" This is all sorts of wrong. First, setting the enum isn't sufficient to actually make the flow bulk. You need to move it to the bulk queue-of-queues and update the stats counters too. That's probably why it's crashing for Ryan. Second, I fail to see why this is necessary or even desirable. If there are enough acks to activate the filter, then I assume it should be treated as bulk already. Or, if the filter itself thins out the acks enough to make it sparse, then it still makes sense to deliver those acks timely so as to maximise the reduced information they carry. Remember too that Codel implements head drop precisely to minimise the feedback lag via ack. - Jonathan Morton --001a1137b0f682d76f055fa5c82b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

This is all sorts of wrong.

First, setting the enum isn't sufficient to actually mak= e the flow bulk.=C2=A0 You need to move it to the bulk queue-of-queues and = update the stats counters too.=C2=A0 That's probably why it's crash= ing for Ryan.

Second, I fail to see why this is necessary or even desirabl= e.=C2=A0 If there are enough acks to activate the filter, then I assume it = should be treated as bulk already.=C2=A0 Or, if the filter itself thins out= the acks enough to make it sparse, then it still makes sense to deliver th= ose acks timely so as to maximise the reduced information they carry.=C2=A0= Remember too that Codel implements head drop precisely to minimise the fee= dback lag via ack.

- Jonathan Morton

--001a1137b0f682d76f055fa5c82b--