Hi Pete
yes i find this patch and add to cake source
and in my test with hfsc and cake
i use

tc qdisc add dev eth1 root handle 1: hfsc default 1
tc class add dev eth1 parent 1: classid 1:1 hfsc ls rate 7mbit ul rate 7mbit
tc qdisc add dev eth1 parent 1:1 cake besteffort bandwidth 5mbit datacentre
nat memlimit 32m

user speed is 5mbit and on hfsc i add extra 2 mbit to give free limit for
cake.
and work fine but in dmesg get :

[44835.530255] qdisc_peek_len: cake qdisc 8017: is non-work-conserving?
[44840.689403] HFSC: cake qdisc 8012: is non-work-conserving?


user receive 5mbit for upload and download and fine work.
mai be need to add no-split-gso to config

but after add have same error on dmesg :

[44955.641391] HFSC: cake qdisc 8021: is non-work-conserving?
[44955.958904] HFSC: cake qdisc 801C: is non-work-conserving?

but work fine and will remove warrning from kernel source to not list in
dmesg :)





i try same config with drr  to remove speed limit from hfsc and use only
cake bandwidth and work same fine but in time of work machine crash .


Best Regards,
Martin


On Thu, Mar 7, 2019 at 8:05 PM Pete Heist <pete@heistp.net> wrote:

> If it’s just straight cake under hfsc with a rate here’s what I do
> (obviously replace 100mbit with your rate):
>
> tc qdisc add dev eth1 root handle 1: hfsc default 1
> tc class add dev eth1 parent 1: classid 1:1 hfsc ls rate 100mbit ul rate
> 100mbit
> tc qdisc add dev eth1 parent 1:1 cake
>
> Also, there were recent fixes to the Linux kernel and cake regarding GSO
> splitting. You may find with hfsc on older kernels that you have to use
> “cake no-split-gso” to avoid lockups.
>
> On Mar 7, 2019, at 12:32 PM, Martin Zaharinov <micron10@gmail.com> wrote:
>
> thanks i will try
>
>
>
> On Thu, Mar 7, 2019, 13:25 Toke Høiland-Jørgensen <toke@redhat.com> wrote:
>
>> Martin Zaharinov <micron10@gmail.com> writes:
>>
>> > please write my one sample line with this
>>
>> From your script you'd need to use:
>>
>> tc qdisc add dev eth1 parent 1:0004 cake
>>
>> instead of
>>
>> tc qdisc add dev eth1 parent 1:0004 sfq perturb 10
>>
>> And adjust your HFSC parameter to shape to the rate you want. Can't help
>> you with that part, sorry, you'll need to go read up on shaping with
>> HFSC (or I'd suggest maybe using HTB instead as that is simpler to
>> configure). There are loads of tutorials for that online :)
>>
>> -Toke
>>
> _______________________________________________
> Cake mailing list
> Cake@lists.bufferbloat.net
> https://lists.bufferbloat.net/listinfo/cake
>
>
>