From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua1-x930.google.com (mail-ua1-x930.google.com [IPv6:2607:f8b0:4864:20::930]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 2A20F3B29E for ; Thu, 7 Mar 2019 13:23:49 -0500 (EST) Received: by mail-ua1-x930.google.com with SMTP id q17so10530749uam.0 for ; Thu, 07 Mar 2019 10:23:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MGbAskV59XIu7PhxWin4pj0p++lLQxn5Hiw8OjD4JNE=; b=W/VwK6YpmyhsIVCOn6kna6EHM9iIvwlfbnkxAfQS9h3a6UOpMb6zeD/gIgB24f9fJo SrCabvG808rN77wD2QvxEwDrTwPWmFNsQmKz4I3WpNfSmJ5OIplfkf6cCAbvZuk5ASSo iOeX4XXddHjCnyoDHFm1CnxvGxrJ/onnoCYsehAPET/p9oz4OSgBCRQ5UDHT2hGFu0rC GmEmGluN6tofhVo46/oA3buHce4l+75Bdx6NvHQfy6cfVjMSR0Z2mXeYwK7/JwuY3caL jujNpu6+/NH58eqh86gfgnQNDeMidpt/EDogMQ7d9ZtVsSg4ZqTLjVkIcaRzbyvbj/2I lhVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MGbAskV59XIu7PhxWin4pj0p++lLQxn5Hiw8OjD4JNE=; b=DsnhxR4q9WKsJQBp/ynDC2vUjAJnzaIjvnbB2PmNfZ3/LA7odfsnbmhw3cuvNcaOgi 73yJhHJDURaExkbkEePo/8rxK/6j58YlasPoEvni4x1NzzebovOLaNPp4Az3QDPjcJUK Frl8gNaIteHB48+Ox6umkl1Ju0QqhUR0oYOQW1/tRJfURUO0lN3K5GcKu/hQB0mWp2pr OGia88lxhrywxY4T7PSJwUhQBvkdq3loN4aTHHykX/sFNZnoSdO+tkkiJgFg3XVh7WOm ibm5hxD7UAlVFbJwaKoLDmMOJIs+mCADRff6QJsQACHKmziKOUi6EEjRPLmgAI5Dq/kR TsQw== X-Gm-Message-State: APjAAAWFk1VKKeIzjQW1qK7V0oTScbTmS0oksP9+IiZiFwZMDtNB6EWM nYVSQhVZ3lNmDqLGoe6boCvPHPZRVzYZdjuUwlX9/Elp X-Google-Smtp-Source: APXvYqzrHCV9ilOOEKA+3iEj5KRmBt3reJyoe1D4o9zN412aEBuQd/9vyGq9H197KJTbuK+AOcX3tvw9VWzaJ7Wr6Y0= X-Received: by 2002:ab0:6216:: with SMTP id m22mr7789556uao.48.1551983028499; Thu, 07 Mar 2019 10:23:48 -0800 (PST) MIME-Version: 1.0 References: <8736nz11mt.fsf@toke.dk> <87o96nyo1n.fsf@toke.dk> <87lg1r0xp0.fsf@toke.dk> <87h8cf0wt7.fsf@toke.dk> <87ef7j0vui.fsf@toke.dk> In-Reply-To: From: Martin Zaharinov Date: Thu, 7 Mar 2019 20:23:37 +0200 Message-ID: To: Pete Heist Cc: =?UTF-8?Q?Toke_H=C3=B8iland=2DJ=C3=B8rgensen_via_Cake?= Content-Type: multipart/alternative; boundary="0000000000001c7a9c0583853544" Subject: Re: [Cake] Bug or not Cake + hfsc or Cake + Drr X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Mar 2019 18:23:49 -0000 --0000000000001c7a9c0583853544 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Pete yes i find this patch and add to cake source and in my test with hfsc and cake i use tc qdisc add dev eth1 root handle 1: hfsc default 1 tc class add dev eth1 parent 1: classid 1:1 hfsc ls rate 7mbit ul rate 7mbi= t tc qdisc add dev eth1 parent 1:1 cake besteffort bandwidth 5mbit datacentre nat memlimit 32m user speed is 5mbit and on hfsc i add extra 2 mbit to give free limit for cake. and work fine but in dmesg get : [44835.530255] qdisc_peek_len: cake qdisc 8017: is non-work-conserving? [44840.689403] HFSC: cake qdisc 8012: is non-work-conserving? user receive 5mbit for upload and download and fine work. mai be need to add no-split-gso to config but after add have same error on dmesg : [44955.641391] HFSC: cake qdisc 8021: is non-work-conserving? [44955.958904] HFSC: cake qdisc 801C: is non-work-conserving? but work fine and will remove warrning from kernel source to not list in dmesg :) i try same config with drr to remove speed limit from hfsc and use only cake bandwidth and work same fine but in time of work machine crash . Best Regards, Martin On Thu, Mar 7, 2019 at 8:05 PM Pete Heist wrote: > If it=E2=80=99s just straight cake under hfsc with a rate here=E2=80=99s = what I do > (obviously replace 100mbit with your rate): > > tc qdisc add dev eth1 root handle 1: hfsc default 1 > tc class add dev eth1 parent 1: classid 1:1 hfsc ls rate 100mbit ul rate > 100mbit > tc qdisc add dev eth1 parent 1:1 cake > > Also, there were recent fixes to the Linux kernel and cake regarding GSO > splitting. You may find with hfsc on older kernels that you have to use > =E2=80=9Ccake no-split-gso=E2=80=9D to avoid lockups. > > On Mar 7, 2019, at 12:32 PM, Martin Zaharinov wrote: > > thanks i will try > > > > On Thu, Mar 7, 2019, 13:25 Toke H=C3=B8iland-J=C3=B8rgensen wrote: > >> Martin Zaharinov writes: >> >> > please write my one sample line with this >> >> From your script you'd need to use: >> >> tc qdisc add dev eth1 parent 1:0004 cake >> >> instead of >> >> tc qdisc add dev eth1 parent 1:0004 sfq perturb 10 >> >> And adjust your HFSC parameter to shape to the rate you want. Can't help >> you with that part, sorry, you'll need to go read up on shaping with >> HFSC (or I'd suggest maybe using HTB instead as that is simpler to >> configure). There are loads of tutorials for that online :) >> >> -Toke >> > _______________________________________________ > Cake mailing list > Cake@lists.bufferbloat.net > https://lists.bufferbloat.net/listinfo/cake > > > --0000000000001c7a9c0583853544 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Pete
yes i find this patch and add to cak= e source
and in my test with hfsc and cake=C2=A0
i use= =C2=A0

tc qdisc add dev eth1 root handle 1: h= fsc default 1
tc class add dev eth1 parent 1: classid 1:1 hfsc ls= rate 7mbit ul rate 7mbit
tc qdisc add dev eth1 parent 1:1 cake b= esteffort bandwidth 5mbit datacentre nat memlimit 32m

user speed is 5mbit and on hfsc i = add extra 2 mbit to give free limit for cake.
and work fine but i= n dmesg get :

[44835.530255] qdisc_peek_len: = cake qdisc 8017: is non-work-conserving?
[44840.689403] HFSC: cak= e qdisc 8012: is non-work-conserving?


user receive 5mbit for upload and download and fine work.
mai be need to add no-split-gso to config=C2=A0

= but after add have same error on dmesg :=C2=A0

[44955.641391] HFSC: cake qdisc 8021: is non-work-conserving?
[= 44955.958904] HFSC: cake qdisc 801C: is non-work-conserving?

but work fine and will remove warrning from kernel source = to not list in dmesg :)



<= div>

i try same config with drr=C2=A0 to remov= e speed limit from hfsc and use only cake bandwidth and work same fine but = in time of work machine crash .


Bes= t Regards,
Martin


On Thu, Mar 7, 2019 at 8:05 PM Pete Heist <pete@heistp.net> wrote:
If it=E2= =80=99s just straight cake under hfsc with a rate here=E2=80=99s what I do = (obviously replace 100mbit with your rate):

tc qdis= c add dev eth1 root handle 1: hfsc default 1
tc class add dev eth= 1 parent 1: classid 1:1 hfsc ls rate 100mbit ul rate 100mbit
tc q= disc add dev eth1 parent 1:1 cake

Also, there were= recent fixes to the Linux kernel and cake regarding GSO splitting. You may= find with hfsc on older kernels that you have to use =E2=80=9Ccake no-spli= t-gso=E2=80=9D to avoid lockups.

On Mar 7, 2019, at 12:32 PM, Martin Zaharinov <micron10@gmail.com> wr= ote:

thanks i will try



On Thu, Mar 7, 2019, 13:25 Toke H=C3=B8iland-J=C3=B8= rgensen <toke@redha= t.com> wrote:
Martin Zaharinov <micron10@gmail.com> writes:

> please write my one sample line with this

>From your script you'd need to use:

tc qdisc add dev eth1 parent 1:0004 cake

instead of

tc qdisc add dev eth1 parent 1:0004 sfq perturb 10

And adjust your HFSC parameter to shape to the rate you want. Can't hel= p
you with that part, sorry, you'll need to go read up on shaping with HFSC (or I'd suggest maybe using HTB instead as that is simpler to
configure). There are loads of tutorials for that online :)

-Toke
_______________________________________________
Cake mailing list
Cake@lists.buf= ferbloat.net
https://lists.bufferbloat.net/listinfo/cake

--0000000000001c7a9c0583853544--