From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mail.toke.dk; dkim=pass header.d=mojatatu.com header.i=@mojatatu.com header.a=rsa-sha256 header.s=google header.b="dm/1+YQT"; arc=pass; dmarc=none Received: from mail-pf1-x430.google.com (mail-pf1-x430.google.com [IPv6:2607:f8b0:4864:20::430]) by mail.toke.dk (Postfix) with ESMTPS id 459431874CC1 for ; Mon, 19 Oct 2026 23:05:36 +0200 (CEST) Received: by mail-pf1-x430.google.com with SMTP id d2e1a72fcca58-885cd98d226so36496b3a.1 for ; Mon, 19 Oct 2026 14:05:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1792443934; cv=none; d=google.com; s=arc-20260327; b=g7fT86scxWmZMpzTH/unFYjqfbgyEracQ0QC7GQ6TLGzPAhLg4xoWRBuE5Jqk3pQwS ml+U5bKB4qBPPhFk1FikFwI/HY4+/FL1f0haTyciEiEeeoEbGxERi44JR8pZe1OpkO1I LOPkW49bwlhH2GRAncNPLMVyj1QdNsaZjDUygapilbp36iS3rK8ycO/VnrckBwGixR9N 8I7hdFJ4MKvgey4+aY63s+X5oA2+aXSssXZWRFOAhz1J9Vew8hggn2iORvELu60NFLCI bghcsxX2PN91IqN2GkmghNRy6cP4tcnPOYxs08EdHPPxs/y/DeYQAVmDzied4SxHHAD+ jDnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=+3Z+Jqh03P6wtlS3IA1RNnZq+SVbTEAx87ffjwIp0hQ=; fh=z3FHk/pe9b70Bij76/KYHyaiSJAJkvjfMHdhufBuMEA=; b=Kbr3m4XdeBvrlzcXCxIES4ac54C3TBpZAZTUOuj32ptbHbRkXbAtIrcsNIBXpeHpo4 kors7YybjtXZH6ypqNo5VttbxdosqM9+6iuHlWZFU0AVD8RK9MdRxOHXbGENKrtQm1cT 4UW9YSYITLD1AuDudEaHYXQwVc1vmqCiLqahmvleQPJpbSPL3qJaTkNAl9v3nKODSRMM pwCffTzPIT9O4dn/PbIhBGk55YvpwwBRUuYcT2wp2B9+9GdwyH1Jg9V/0LySZndp8e/P krZGZ7q4W/l4pwsy1owbI3ltQMrhto+LzcKPesyk2lpnV6uzI4L9laPtKb+tNtXwnYxo v1mQ==; darn=lists.bufferbloat.net ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mojatatu.com; s=google; t=1792443934; x=1793048734; darn=lists.bufferbloat.net; h=content-transfer-encoding:content-type:cc:to:subject:message-id :date:from:in-reply-to:references:mime-version:from:to:cc:subject :date:message-id:reply-to:content-type; bh=+3Z+Jqh03P6wtlS3IA1RNnZq+SVbTEAx87ffjwIp0hQ=; b=dm/1+YQT8Rq/4MRbDBYohZlvZYbFlJnb6mEqXQRBjMDX5669MJ9NSJTkOiyfQ2TYvX edsyL17pKZYdYngTa3+atkJAQfS0TPzTAMjD7HKnvlaIBsEGVOZxyX0EXaKdcmWG0D2s kNVzqV0P1aQucuDFOMfnB6sMJ4TCW8sT15QQU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792443934; x=1793048734; h=content-transfer-encoding:content-type:cc:to:subject:message-id :date:from:in-reply-to:references:mime-version:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=+3Z+Jqh03P6wtlS3IA1RNnZq+SVbTEAx87ffjwIp0hQ=; b=Y9Z5y9Q9hjhV0mAP8RVUA8aB3vBH2b2sRfe1elPbF1UlfxlDwecCP4DIzSIqAFf5tj sMpLCW38FhwvmNh4uMk0dLaCyix275rtRVjG+zE4lRiesOEqEivcZpQu/r3org3skDDB I3vYumV7YjqAcFvQ+4xt8aKO6GvzOGWPxPMydVVSiO0/4EDuWmHKGBXFYb69Rh5xQ+SR ECoYlD8cRJn91hrRrMdKSElJQBybniCJYhjhcZ4keB/MtVf1XitdjHePpD9A6Odq6s8Z GEvPuXtMGkcxfJVjkTbU8zfvws99xd+/jDJYVN4aXDDTCDHQwxthgU9G1KOS4onI+ZAy GV5g== X-Forwarded-Encrypted: i=1; AKwUvByqgBu9mis440FvxaFYiwPJgcSHh3EDFHgBB/E5u6Wo5za/akSOZ7+2HCN1y2T91cmv0N46@lists.bufferbloat.net X-Gm-Message-State: AFq9FYJOlESjKG/7VWQIA9375cpo6ZdbKt/TNFTRiRlu1MsIBItuBHb0 pufDkzyd3aPP4VJ7t1iFbHdlxTohG/fdPhkjwl2txTVX5luOOiMYnG3zKf9ZcMyiGT4CfsWR4DP 80C2r+0cAUdp3EXeRsCGd5/h25V0IbKJlcW22oV5I X-Gm-Gg: AYBFou0YBUM5fBsuYiPZp0Hc3x9oV3rq5L09YtlXVaOCHT4CGpKUQW6xjbtLo8nPdCX AoBbbGROZccOJWhxb51taBvd2wpgaUGyHfv4H0cdUHEJT8jPG6MYBNpTNFnBRHEFCrvahz+BwCQ XPYIp/O/ztItgchS0XbIiWrzxRyKifEAZ4zDJZpa/uEOS+gKPROA+W4ijWaHu83Cf758OwntdWh HIzZAbOCNAfW1ehDMrsRGHDmfpVx6FeUqtqUHskBGayC0CrTXjoIWWHSzVMEQiGNasPuJ0gnhHC 3uYmJG0m8SUqu3vr1QQq0DZkL2vuIai5CEsIfWs4vjRxI21RdX3khfG+5XL0dJ8Jy0hqM5EpR+M L4Jw177UkUvJtbdW0DHzdNJjckTTtt7FJ7ChJkSe0eEbHdNfrpRmeo012ROnCRHMo0191coFYqa nHMe6tI5iOF6lxLLI= X-Received: by 2002:a05:6a00:13a4:b0:8a0:5b29:269c with SMTP id d2e1a72fcca58-8a07bfe865fmr176294b3a.13.1792443934445; Mon, 19 Oct 2026 14:05:34 -0700 (PDT) MIME-Version: 1.0 References: <87wlrdwof7.fsf@toke.dk> In-Reply-To: <87wlrdwof7.fsf@toke.dk> From: Jamal Hadi Salim Date: Mon, 19 Oct 2026 17:05:22 -0400 X-Gm-Features: AclHuK80iIG0o50u8QTvZF7FmPTPFC2S1ybNJm9DexdEPm7FgzHZm7k39rVhfOo Message-ID: To: =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= Cc: netdev@vger.kernel.org, Jiri Pirko , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Victor Nogueira , =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , cake@lists.bufferbloat.net, Sashiko Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Message-ID-Hash: JZMUN5IUYSVBBF4GDZDRYVXVMVOPN6HL X-Message-ID-Hash: JZMUN5IUYSVBBF4GDZDRYVXVMVOPN6HL X-MailFrom: jhs@mojatatu.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list Subject: [Cake] Re: [PATCH net-next v7 1/4] net/sched: cake, fq_codel: return the classifier result to the caller List-Id: Cake - FQ_codel the next generation Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, Oct 19, 2026 at 2:11=E2=80=AFPM Toke H=C3=B8iland-J=C3=B8rgensen wrote: > > Jamal Hadi Salim writes: > > > The Fix: > > cake and fq_codel run an optional external classifier from their enqueu= e > > path and then compute the flow hash inside the helper. Have the helper > > return the filter's overrides (cake) or a 1-based flow index or a reque= st > > to hash (fq_codel) instead, so the caller owns the flow selection. > > > > This is preparation for the accounting changes that follow. Packet > > classification and flow selection are unchanged. > > It's not clear to me why this change is needed at all for fq_codel? > fq_codel_hash just does a reciprocal_scale() of the skb hash, it doesn't > mutate any qdisc state. So why can't fq_codel_classify not just stay as > it is? It is not functionaly needed for fq_codel, it is more because these two are cousins and simplifies subsequent patches. Note in patch 4 we force the same semantics on cake as in fq_codel (classifier decides the drop, the caller owns flow selection). Keeping fq_codel's classify the same makes patch 3 hunks in the two files similar. There is another reason: the old helper encoded "drop" as a magic return and carried the 1-based +1 arithmetic on every return path. In any case, unless you feel strongly i would rather keep it. cheers, jamal