From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x42e.google.com (mail-pf1-x42e.google.com [IPv6:2607:f8b0:4864:20::42e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id F07583CB38 for ; Mon, 9 Dec 2024 18:00:55 -0500 (EST) Received: by mail-pf1-x42e.google.com with SMTP id d2e1a72fcca58-728e1799d95so3200b3a.2 for ; Mon, 09 Dec 2024 15:00:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mojatatu-com.20230601.gappssmtp.com; s=20230601; t=1733785255; x=1734390055; darn=lists.bufferbloat.net; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=8rdqTpO2uA1Ykp81jesT1emUsHbdy9YgUbLnxTQ984U=; b=Ltc3KaPoEB7sDS9BbpfF+6K3a0oDaNmP7G/xjdhlvuQ+3dEy/WSmk6sPAnVUiMxiQa 6kKuEiF4syFfIFP+uk/uLS0LxAxf0Bsonp+yHN2MGalrI2vPC7IcfuWxwhr529SjOUFd FUa+IPS6xHHqlbrftg8CF8tK0JgLOS7u3vhUbYpFRcsVvvrq7GC8Y81CPD6dDroE1mGJ 7Phx5XPAxlaS1Km0wZ1hGMchPw33839ZRmIBo1zw2ytAHGQxl7LdbMwmxz87Xstf2EgX 6ntIzanQxNCWCK3p4N8V4kDhIGIyVR+S0Ls2mcZF0XdzLcAzgX0eUmx7Sn1qot/rOPJD 4YNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733785255; x=1734390055; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8rdqTpO2uA1Ykp81jesT1emUsHbdy9YgUbLnxTQ984U=; b=r/ft8aQjZ3M2wj8aFZEAgOgaHvQhwrgn0W3Ej4dEYz8rgSYgbEuz7Nl6XTyKz52QF5 zEeg8bD0lS9XtH4/ccuJs1KoYsEGDNetslDSKMalF6kypU8ZZnHE72Ae+55JKpV/NgqC vF11Stm/jlE7qUCgZ/UeJ6WPodRH+t+jxaAQikhfruz86KlK38E7VWD2pKRuUQpwIvV1 qVREvt0lh0CxKpyORCWzat90msMUJIrTC3nDyvieWdKJ0xy7mT0BWHEu4O4S5G7L0qkR A78gRJ28uCh620inLYdt+KwopZCNGwT5B1qHiSdx7/2yr5e7YgItwN9DwRO439xqltR7 AE4A== X-Forwarded-Encrypted: i=1; AJvYcCWnxh3F6S+iz7dZ77wsmMDC7ye9g0LsqrdGgC9QnM5SIeo7ZgebJoXk14ZVvCDdDP9Lkg5B@lists.bufferbloat.net X-Gm-Message-State: AOJu0YxTlqFNU1rw86py6mY3M7/Yl0RJs3X029tZ7jHJ4gsPyriyH9fi rgBPBTIZMZ0pghmraOOcqxqu8+0s8VWiSARLsdlJaya+MxCf1hIz1aP3vaSIptST391mv9+OW8m IwO+NF3Q88/yHjmqtj0fRGf7iqzr4QencwbVe X-Gm-Gg: ASbGncutIVNnihhEwlNp9pNvIxmd4Cd6UD1IIPNY8JHXVfOFRPPwJBg8UWzMYODXwRq Hz5aH2SSxdtqsWAAHffjubQP5iLHobZniDg== X-Google-Smtp-Source: AGHT+IG6WKU6sgAkakV11JKiqBBUmy5CZr+tK6ahkhudY9xN8p7Xb63u2DWQaS54pYrmBuUuBf0pO1kzC5tBKMzAJx4= X-Received: by 2002:a05:6a00:885:b0:726:41e:b32a with SMTP id d2e1a72fcca58-7273c8f1d15mr3403673b3a.4.1733785255122; Mon, 09 Dec 2024 15:00:55 -0800 (PST) MIME-Version: 1.0 References: <20241209-cake-drop-reason-v1-1-19205f6d1f19@redhat.com> In-Reply-To: <20241209-cake-drop-reason-v1-1-19205f6d1f19@redhat.com> From: Jamal Hadi Salim Date: Mon, 9 Dec 2024 18:00:44 -0500 Message-ID: To: =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= , Cong Wang , Jiri Pirko , netdev@vger.kernel.org, cake@lists.bufferbloat.net Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [Cake] [PATCH net-next] net_sched: sch_cake: Add drop reasons X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Dec 2024 23:00:56 -0000 On Mon, Dec 9, 2024 at 7:02=E2=80=AFAM Toke H=C3=B8iland-J=C3=B8rgensen wrote: > > Add three qdisc-specific drop reasons for sch_cake: > > 1) SKB_DROP_REASON_CAKE_CONGESTED > Whenever a packet is dropped by the CAKE AQM algorithm because > congestion is detected. > > 2) SKB_DROP_REASON_CAKE_FLOOD > Whenever a packet is dropped by the flood protection part of the > CAKE AQM algorithm (BLUE). > > 3) SKB_DROP_REASON_CAKE_OVERLIMIT > Whenever the total queue limit for a CAKE instance is exceeded and a > packet is dropped to make room. > > Also use the existing SKB_DROP_REASON_QUEUE_PURGE in cake_clear_tin(). > > Reasons show up as: > > perf record -a -e skb:kfree_skb sleep 1; perf script > > iperf3 665 [005] 848.656964: skb:kfree_skb: skbaddr=3D0xf= fff98168a333500 rx_sk=3D(nil) protocol=3D34525 location=3D__dev_queue_xmit+= 0x10f0 reason: CAKE_OVERLIMIT > swapper 0 [001] 909.166055: skb:kfree_skb: skbaddr=3D0xf= fff98168280cee0 rx_sk=3D(nil) protocol=3D34525 location=3Dcake_dequeue+0x5e= f reason: CAKE_CONGESTED > > Signed-off-by: Toke H=C3=B8iland-J=C3=B8rgensen Reviewed-by: Jamal Hadi Salim cheers, jamal