From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mail.toke.dk; dkim=pass header.d=mojatatu.com header.i=@mojatatu.com header.a=rsa-sha256 header.s=google header.b=QxtvdwVL; arc=pass; dmarc=none Received: from mail-pf1-x42d.google.com (mail-pf1-x42d.google.com [IPv6:2607:f8b0:4864:20::42d]) by mail.toke.dk (Postfix) with ESMTPS id 34625179979C for ; Fri, 09 Oct 2026 11:20:23 +0200 (CEST) Received: by mail-pf1-x42d.google.com with SMTP id d2e1a72fcca58-8897e83332fso737395b3a.1 for ; Fri, 09 Oct 2026 02:20:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1791537620; cv=none; d=google.com; s=arc-20260327; b=VOi+V6Okchm3DkeZ2ou1fOfeVx614wl0e2665m1urNr5XHrTCJLzkHPngBF+14AI/X pO4Nkrgu62RUm9yGElxRoIfRoNdcub4qmuJ8/QgtrWJu+SB+3T0Y5elENaBP0fD5E8ye EFRDcDAg1dSQvedr67Mb0EXYqCmS3Ty69Y/NAonx+Q/JrLYrxuW62Dm7TMzfHKOVOEgW LOYJujBF8NIXvbTuAYqdv4NjoatZ+oeF32cu4Hdky/g/IKdpkCK8a2wcaUvjk1NXqjHx 3iaKkLaOAtMs6mHZck4FPuwQKssVVOwoVIquLafcW79EW+IxMsq92fBCZ2xd8DYwD4G5 ubUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=8T+bagEFNAv/OZqLOip7XkPhqwlIGOPZXUhaa6oDbGU=; fh=Fl3xgy3M/PFMYMeRiowfTNu7h35JHGY0/GsTwUrgEZI=; b=nkYt8rY/zxE0cPbTtmsWa4DrbqfPGM9C+bbrfLire9fJDn5Rerv5ju3c1sVM7ryMl+ vOJTibNFHcl4TdAP74DhwI828C4QYWKZgpGE9wbutrb/Sv8zbyGMqnHpWKX87kT0Kd6Y N9Jzw7lsxldhft0/C/Lht/3/hCxi39KDAGGpcmZaldP0qwJJ0oyy9+jb+XFGn48u4ZKR Z9JL1BpGbaf3FUGljYEv1Dap49Xv+7o8F1ZQsaBK7B9exiGK3rg7IHeMmK8bGrUR5rPl 0F5p6hvsRAxWP3BvX58hCjr8nONaNcJrb06Zdv0Ihri1DNzNRS8VaK+KL/kNBhM7HXYa kPzA==; darn=lists.bufferbloat.net ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mojatatu.com; s=google; t=1791537620; x=1792142420; darn=lists.bufferbloat.net; h=content-transfer-encoding:content-type:cc:to:subject:message-id :date:from:in-reply-to:references:mime-version:from:to:cc:subject :date:message-id:reply-to:content-type; bh=8T+bagEFNAv/OZqLOip7XkPhqwlIGOPZXUhaa6oDbGU=; b=QxtvdwVLSeKPRYNFd/vAsU6MzblLODN76qY/W+1ybb6mOlf8gscoOeKRJrY9CrF8aD doQP2DBQlgF00wSQ1h3425CyY4t3aKlPWTtu2bfw2uYkoUj331vN5/ZEnFXqhe00fFP3 i9lrRjunZz+qUHsuy56I3IVLW3renKIKcQgno= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791537620; x=1792142420; h=content-transfer-encoding:content-type:cc:to:subject:message-id :date:from:in-reply-to:references:mime-version:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=8T+bagEFNAv/OZqLOip7XkPhqwlIGOPZXUhaa6oDbGU=; b=fr/J4/dnXCJdCWegofSd9S+25Ao07SAFn+YriajutiTG5rvnwUU7o7BGJ3ecR9uV8n Hh1HTnG3HqyPxqafTI5ZB4c5LQwd3WiBKrYG2p9PFk1ypcAnhSSwSTNB+opbcLroJXke 06NTAgCdXHXJkQiD/toMbbDfltgnEnyGC0rSyhyHKdWvgwHd9ByhlsPmxBGwBnpXdFzJ nECljeRoloRIPB46YsKVkYLCCASYMXdH7glcF4H9EsHU2jnrjZlUQWYlXEz4gp/3YS4w 75e1S5Zv2iRhPTRq5vJyUuzPhW5jyOEd4iv3VclUCJN2uZXyItI487OLhfY5eOLiQfzT VjMA== X-Forwarded-Encrypted: i=1; AKwUvByeWUTBAr+osnL7EQ93wrYTdbD6hx8SiKjXUqF1vdBDp3ld3uisTQnhC4AVy+oI8+jId301@lists.bufferbloat.net X-Gm-Message-State: AFq9FYIZ/LlGQ29QlT5TdNJNbsxGaVDbNaxPISw4g6p6c1eyfERi0pDe vej88NDVBzqNO5KXMnQnDUVMVDC/GU+zBA4+3nNsn8hy8jB6euv+u5faTNI7Fmcj3DRw05wn9Tv SKqqaPuqiiOHYoREgtQi29NHD9I8BWScvjyHSJeIz X-Gm-Gg: AYBFou3kQVy7p1TMXhZzgh/yWF+WvJD3HChBQWLSwOZHPqgCl1reAWIUR+yEI26BgGu IhsyC4DZDLIW/VKjB87ujzpKnD0RdoFUvscjmELKqInlPfSE8H3vCUuVssFrAaFkYv14rXLgaqp LJaR0JnYvDPn2PqPW+9aZTXDOG6aO648MElkJfXrN5LnVDMkLEtrzeN0f6bPj0IyM+/2FHCYbWT BiQVn5auZ9WE8OOWElahldGnuHtyk14BXI2oQ/HTu8SwF0cMZUJwJHNyNvvdyil9NZdCRsz/UdR unVvBA0CkaAOsChqRxJ8pfqisjDAQE9Cpc60uOZkZkR0G6rNufXd+1l2I2LOlVmY+cQbJAxXUJ2 1uJ5dY4SO1+CFS6Dwu+nobvabUFYAcbnS+Mae0U6K5xwh X-Received: by 2002:a05:6a00:4c1b:b0:878:3705:5724 with SMTP id d2e1a72fcca58-896a4db0354mr1243619b3a.48.1791537620497; Fri, 09 Oct 2026 02:20:20 -0700 (PDT) MIME-Version: 1.0 References: <87a4oottcj.fsf@toke.dk> <87pkxks68f.fsf@toke.dk> In-Reply-To: <87pkxks68f.fsf@toke.dk> From: Jamal Hadi Salim Date: Fri, 9 Oct 2026 05:20:09 -0400 X-Gm-Features: AclHuK9eYAfueee64evY9nqUNmiUsIv2Id4AfGG6z3lIOXpFCxFMLLRHDU4cOvQ Message-ID: To: =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= Cc: netdev@vger.kernel.org, Jiri Pirko , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Victor Nogueira , moeller0@gmx.de, cake@lists.bufferbloat.net, Sashiko Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Message-ID-Hash: BQOH6F7MS5QIM2REIK5HSXAQ6KDU75TO X-Message-ID-Hash: BQOH6F7MS5QIM2REIK5HSXAQ6KDU75TO X-MailFrom: jhs@mojatatu.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list Subject: [Cake] Re: [PATCH net-next v5] net/sched: cap the accounted backlog before it can wrap List-Id: Cake - FQ_codel the next generation Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, Oct 8, 2026 at 8:54=E2=80=AFAM Toke H=C3=B8iland-J=C3=B8rgensen wrote: > > Jamal Hadi Salim writes: > > > On Thu, Oct 8, 2026 at 6:29=E2=80=AFAM Toke H=C3=B8iland-J=C3=B8rgensen= wrote: > >> > >> > This is a follow-up to an issue found by Sashiko (nipa) during revie= w of > >> > commit d9ebd8f9aa8b ("net/sched: fq_codel: clamp default quantum and > >> > mtu"), part of the quantum/mtu overflow series merged as a687f2ae995= f. > >> > Clamping the per-flow quantum and the CoDel mtu does not bound the > >> > accounted backlog, so the per-flow backlog wrap the review flagged > >> > remained. > >> > >> This, and the rest of the commit message is obtuse LLM vomit, and clos= e > >> to unreadable. Please rewrite the commit message without the verbosity= , > >> so it's actually something a human reader can comprehend. For the cake > >> bits in particular: > >> > > > > Ok, but there is a dilemma: The verbosity is an attempt to appease the > > sashikos. The other day it complained that i didnt have a space after > > a semi colon. > > You know you can push back on Sashiko comments, right? :) > You can never if it listens to what you say ;-> See attached screenshot on a small exchange where i pushed back. I did fix the double space on the next one of course ;-> The human behind it is trying to teach it some bad habits ;-> > > The more stuff i add the less it slows me back. It picks on the > > accuracy of the commit text _and changelogs_ and prescribes what i > > said or should have said. I can understand a future AI review would > > benefit from that; there are probably a few humans that read the > > commit logs after the patch has gone in. > > So: > > I have been more targetting the AI more than humans in these comments. > > Writing to appease the bots at the expense of human readers is > absolutely a mistake, IMO. Last time I checked, we are still a community > of humans developing the kernel together, regardless of the fashionable > assistance technology du jour. Having a comprehensive and understandable > commit log is one of the kernel's greatest assets, and often one of the > only things that makes complicated code understandable. We should not be > sacrificing that in an attempt to make the work guess robot guess other > words :/ I dont know ;-> Let's discuss in a year. [..] > > In plain english, it says three things (applies to : > > 1) Splitting a GSO skb can account for more bytes than the original > > packet, so we sum the whole segment list and test the total against > > the ceiling before any segment is linked. > > 2) If it is over, we drop the entire list, and because no flow state > > (tags, hash indices, counters) has been resolved yet, the reject > > leaves nothing behind. > > 3) The fraglist sentence only picks which reference to drop for the > > case skb_segment_list() returns the original skb, so the same skb is > > not freed twice. > > > > This text also applies to the codel piece. Does re-writting as above > > sound better? > > Yes, much better! > [..] > > We have literally have about 100 followups to review from complaints > > of "re-exsting issues" by sashikos and other ai officianados (there > > are at least another 10 on cake) and the hard part is sifting through > > and picking what is important enough to submit. And then deal with the > > fallback from the sashikos turning transforming into bike-shedders. > > I am trying to avoid sending many patches. But i could split this into: > > > > - 0001 (prep, no behavior change): extract cake_tcf_classify() and the > > fq_codel_classify() rewrite. > > - 0002 (prep, no behavior change): skb_list_walk_safe(segs, seg) rename= . > > - 0003 (fix): the enqueue ceiling guard across fq_codel / codel / pie > > / fq_pie / dualpi2 / pfifo / RED / cake, plus the > > qdisc_pkt_len_segs_init() producer clamp. pfifo stays here - RED reads > > a grafted child's backlog, so it is the same overflow, not a separate > > bug. > > - 0004 (cake restructure): the cake_hash_keys() / cake_hash_resolve() > > split and the split-GSO relocation. > > > > Would that work? > > Yeah, this seems roughly along the lines of what I was imagining :) > I will wait for sashiko to run - it does find good issues and will resend with this and the one above in mind. cheers, jamal > -Toke