From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mail.toke.dk; dkim=pass header.d=mojatatu.com header.i=@mojatatu.com header.a=rsa-sha256 header.s=google header.b="G5J/LjOb"; arc=pass; dmarc=none Received: from mail-pf1-x42b.google.com (mail-pf1-x42b.google.com [IPv6:2607:f8b0:4864:20::42b]) by mail.toke.dk (Postfix) with ESMTPS id 414371775440 for ; Wed, 07 Oct 2026 12:14:06 +0200 (CEST) Received: by mail-pf1-x42b.google.com with SMTP id d2e1a72fcca58-887beafb714so936430b3a.1 for ; Wed, 07 Oct 2026 03:14:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1791368044; cv=none; d=google.com; s=arc-20260327; b=Kaj5xW6UyGeRfvYNMiDwePEfNFV2f+564EZExekSC3vGSobDX2uKgivHk90RBKNa8K JYQLPoP+UAQ4mjOCCFLoFIuec89lrWctdi1i4yMXZij3pqLzTWS6Xw7X/bz4Z8qJmXsa pcAHmkBHZGwH/GYuBYMxuGoJYJejLr8KUFm8tFhDy9F+RxB3YbOPRHESYEriKcB8MOdY qMLI6voC3+xj+ri9TgKp6ba7EJK5rOhc2vEtExg2GhQAq4AgLctBVL3rvt5Nd+BRJsuM catLZCzZl/2+UaaGZ82lfIjZZRFWs+EulS2LJ+VlVJkZ4VxO1mN68Ca7xv4PmX1Ipjnq QxJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=EDY5pGh9vkzmlGXT8oGSOIFOutoB19sXEcV1QjJMB6M=; fh=/4BTDatAZiMNZbw+Ru1pFFTDC4xSm9BdtuCvrBnu7ss=; b=B085kYFn+7Oz99Z7PzJ5hS/P3r21LLnH7ZE+H7zETcbVWw8aBGYfuNKNb+Lhf2AbCv B6QV4qZnJlpPf7Q9OND/F0SKxQrXQIruTRoV3J9n8+DGPmKVIfjSc1RRex0KO+K7YsvS cr6GPAXJa002Qa/Hecw7b4yF1Bly14+BUwi57M7Dsu9Qnc6+e+VhVkYw6CnpOF97X5so JiWI8B4l1zlJRLygEbYJ6HTzw4E1qeIR7nFBePjXO8F02HVUnfdfm9MgEuMOlHhiyuZV pH3im/yEq6LbGFvA10KYF89IhpvBnlgwqokerBbb6CHQpex+AAMSJHOAecl8LDo++P5m uEFw==; darn=lists.bufferbloat.net ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mojatatu.com; s=google; t=1791368044; x=1791972844; darn=lists.bufferbloat.net; h=content-transfer-encoding:content-type:cc:to:subject:message-id :date:from:in-reply-to:references:mime-version:from:to:cc:subject :date:message-id:reply-to:content-type; bh=EDY5pGh9vkzmlGXT8oGSOIFOutoB19sXEcV1QjJMB6M=; b=G5J/LjObHTplfhz80pYz8O2ZF0JFxDXmIYCl01swn3i3Ua0n98t7cZi78MzgrACQ+l HZF0k2aklqCL9yQW3oIYLDEy673UrKY8+lNHog8kvZtZwWkCgcErx/3spwLnt/VzDtvc xJXp8PatXkTAyXZJPacqnmoZtrPG8uUXa5BPw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791368044; x=1791972844; h=content-transfer-encoding:content-type:cc:to:subject:message-id :date:from:in-reply-to:references:mime-version:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=EDY5pGh9vkzmlGXT8oGSOIFOutoB19sXEcV1QjJMB6M=; b=tbW5m/ar78aHsNBkvADiK6udubip9MMPIWaixfBfDgjiknjwKuHxotr+eiRLFqAun3 cVCg1uR4on/Ii6Qjitd+RwQruqLWC8ykforGhThWapQ5FCqFVxZUMCo51PLrW72GAdGn KLEbwoqWumbU9z4pn3JCr39wnAww7Q5dNQPMzzSC61qM/9l6WZYw+V/YGybImd+qlUJv JQYgYx6C0PG+3ND+uEuUbb37Sk+4QtfrvnuC53BCmDJ6topBgpuphrmDEvcaohSFO5Za HYm1YQN35wKscmhLXSXQikgFzCN3XkCnwXQrf2l0u6mgGWRE/GyyOzTn9D/4QwwSJLYV wrCA== X-Forwarded-Encrypted: i=1; AKwUvBynhxhcraA//o7H6L4bqG3P8mUYiqJtegoEUFZNxW76NY7ZGxkOjAS9+7KF9WwXKZRliTAP@lists.bufferbloat.net X-Gm-Message-State: AFuF++mwDKVm4K7EXclsQrMLnMTXTMG/yvjXiB8JAdMWJaubWiaYnKO4 TQ/B7Rv3qGgKTj2XbXb9N5CrEAO+ltB6gRY8iXD0INDk+J7HBIvZYaRn1yzezLzX7m+NepCuFlC thn3ku1h2T3fI41AmSkw3Xj5a3vhI6WcKnvaQF+7YW9SElLMKnFA= X-Gm-Gg: AYBFou2UbKPkLnb2Wf9AwgoMbKR/7eEYSiKfumjULLD2/r1ZjX8sNSp9a5J4UPVkXs3 gbj2xVipVa1CnHUdBCw09dTjlE2/89utYa7fZ+S/c3BtIZylcyaA1B4/ebuL+krUZVo5W+KP+fP U8IyuH7tBZt7YqOPRoHUHP1KRX/g3NznUbzC7FRE1+AlhBmbRmEo6mAvddpZy0oRPaT5F37G5TO EQPYe5Qe6wc1u2ofllZCHVSkuYLK4trNmNdBJiS11xBRuxzODYLftfxOHQkm/IcZXzakOISEMQA z+/sDGEt8+bPLOiBxOB/gAUynZMxqFf0XsWQsib0sp8//OfrgNJbDh6wJA0mcVjSdd0O9aPRMMr f0rpQRjEwj1dCC7yUrBpU+VDgmUtJ33F5Bw== X-Received: by 2002:a05:6a00:4fc6:b0:881:d48e:7138 with SMTP id d2e1a72fcca58-891b1193567mr1317212b3a.4.1791368044277; Wed, 07 Oct 2026 03:14:04 -0700 (PDT) MIME-Version: 1.0 References: <20261006153043.GM83879@horms.kernel.org> In-Reply-To: <20261006153043.GM83879@horms.kernel.org> From: Jamal Hadi Salim Date: Wed, 7 Oct 2026 06:13:52 -0400 X-Gm-Features: AclHuK-6LfpAyzZ2sADy3SuT_HqRXqU-iqNXOJEoXzvGEd9JTb0nrG_AEBvSCLU Message-ID: To: Simon Horman Cc: netdev@vger.kernel.org, Jiri Pirko , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Victor Nogueira , =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= , moeller0@gmx.de, cake@lists.bufferbloat.net, Sashiko Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Message-ID-Hash: EDDGCX7VLWCFCKLCCECQEFVPL5GTWONS X-Message-ID-Hash: EDDGCX7VLWCFCKLCCECQEFVPL5GTWONS X-MailFrom: jhs@mojatatu.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list Subject: [Cake] Re: [PATCH net-next v4] net/sched: cap the accounted backlog before it can wrap List-Id: Cake - FQ_codel the next generation Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, Oct 6, 2026 at 11:30=E2=80=AFAM Simon Horman wro= te: > > On Fri, Oct 02, 2026 at 03:44:31AM -0400, Jamal Hadi Salim wrote: > > ... > > > diff --git a/net/sched/sch_cake.c b/net/sched/sch_cake.c > > ... > > > @@ -1712,18 +1738,24 @@ static struct cake_tin_data *cake_select_tin(st= ruct Qdisc *sch, > > return &qd->tins[tin]; > > } > > > > -static u32 cake_classify(struct Qdisc *sch, struct cake_tin_data **t, > > - struct sk_buff *skb, int flow_mode, int *qerr) > > +/* Run the optional external classifier. Returns true when the packet = was > > + * consumed by a terminal TC action (reason in *qerr); else *flow/*hos= t > > FYI: > > W=3D1 builds complain that the line above has a '/*' embedded in a commen= t. > This is likely why Sashiko NIPA didn't run for this series. Thanks for catching this Simon. We don't run W=3D1 - already overwhelmed as it is with the flood. Do you think we should? cheers, jamal > ...