From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mail.toke.dk; dkim=pass header.d=mojatatu.com header.i=@mojatatu.com header.a=rsa-sha256 header.s=google header.b=kjVjE7ew; arc=pass; dmarc=none Received: from mail-qt1-x82f.google.com (mail-qt1-x82f.google.com [IPv6:2607:f8b0:4864:20::82f]) by mail.toke.dk (Postfix) with ESMTPS id 1882E1A3196F for ; Fri, 13 Nov 2026 13:27:09 +0100 (CET) Received: by mail-qt1-x82f.google.com with SMTP id d75a77b69052e-53634b8328eso13959821cf.0 for ; Fri, 13 Nov 2026 04:27:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794572828; cv=none; d=google.com; s=arc-20260327; b=Cn0dL855WKOmqRfzBdhqeFyxDjclvxkJEHP20nuW7B5KqnI0jmd56Tz2Kb3xnKR3IE nRtjf+k3lvKkmb1HqGn/NW9+ph9bMc7Mbn2SnJtZS8wZftGlwEx7Xb07LZUe7Z5ml8VC sW3kh61iC9V/iPAyf1o0s8kKnqwpim2G26BEPl3YeZ4g7x0oYB4G1a7KBEO8wsgjRQ9X zqcIrsR+vmZ6/L/l7rCT4jk0yJ5fei2+c636iDG5FBXW9vZ1yDhqGFC/bOSRkglwHyNl GR1h1/BBVapqAwzjPmr1lB+ukxWM4h/nEQJyJQRgMj7jM7fOfWIj5gh7+ouQ95geU2rh 2tVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=TdnaEhEEMD62fi/Ro4pHyfdxHQ5g+8KcZWgKshSQ4QI=; fh=jkfKYHt3YCWGV8a3xmXo3GPfRouCAP+NAyv21Z/lafU=; b=IRHszd46gf+eHNEv6y9jteDhz6OgvZynSa/SGzih1Bxn1bAvmxYZHfjaB3ej3q1kDV BPWm9nWgk+Af4hgVQJB8CvyXziSX5y+dRRS7K1IJJdUFb8RrwAXMzpPYvTPDjbAGm4OG cCiMhsPx1u+ngO7K3wySR9wkmFOUataIRKW+U+AsJ9mZxphQhwQ/NdhbWCRaVmTkxgfk u58w566QJCtC2IAbDOjhcz/y8RamMzElalb+93YTD1BJMG9FXIPlVTpeKjNLMMq2HALf SqDOdsXb8wLHpVUs9eNE/bY0q+F96SnMDSbzHGVupjQWOpRhi/5fkC4AMP8gEbpih0RK xh2g==; darn=lists.bufferbloat.net ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mojatatu.com; s=google; t=1794572828; x=1795177628; darn=lists.bufferbloat.net; h=content-transfer-encoding:content-type:cc:to:subject:message-id :date:from:in-reply-to:references:mime-version:from:to:cc:subject :date:message-id:reply-to:content-type; bh=TdnaEhEEMD62fi/Ro4pHyfdxHQ5g+8KcZWgKshSQ4QI=; b=kjVjE7ewikXr/oZ1beUr0eX8yNmEgfCKPfc1hNfAIbJMIccYRbE1hvdaM/0beUZN65 Tv15/dolgNcQBXx3WN1n588NIsIK4o0M1RLhIRBnFfU5go9dTdT+7ff/6IqeMpZrv6CH g93RBaBXUN9wp2n/LZ1zLfBic1VfNyQeD0rRc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794572828; x=1795177628; h=content-transfer-encoding:content-type:cc:to:subject:message-id :date:from:in-reply-to:references:mime-version:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=TdnaEhEEMD62fi/Ro4pHyfdxHQ5g+8KcZWgKshSQ4QI=; b=zDVbwOcNFSw7JxHs26LRCh4NcOUyMwkpfsfNH74fYJy1u5ODVfG6W5SPfvsYWs7j2a 2bu1oln7votbFkeLz0t4YtlYq3fV6maITLRIR4tdFuw+9qijQQcW76vzW9LgULweDimM v5qMMhdXSLEm81NRItsmSBN3n1qAMwgZJToMS4D7zQz4KDfUfaoh7cPqVrNFdbARy1+S sjMZuyURbqKWwxJbf6447SMimezGTJbZfixqebtYZ6ayPSfp+yrkEz7EVe9yjxtVfCEI +prY2RVGs1g8PDaPI3Cc2uPv22vXyirrWg+mZydzpYyutcGoXD94TmD480m3KUMUhq/P 8Xjw== X-Forwarded-Encrypted: i=1; AL+hErE3/QC9OO/PwuJB5ycF5khsi/BddCl8o9ickrIXcWbFi5e0NqY/Q3OUmCd9UghWAXsLM6qD@lists.bufferbloat.net X-Gm-Message-State: APuU4Z+8KMvgkTIFW+ktBC2Mk5nQhKqPPGN9LQ4m7KIRS0nj5AZz0LDR H3112LVbCBT/KM+cweNx5i94xUPVLCM8z7P9P41fTV0ETpE1bEXqQ5hepa4l5hB1ihubkcqGnPm R+50vMOIG1SP5a8s+/5CZaU+FHsLtGGrfPwzsIkdsMyvScUsJDp5UIQ== X-Gm-Gg: AYBFou2z6pIlfUCaj+CDS1aJikKiDyIciMBcS/6ONS06hH68zGKIajnLoD7f7rJd1W3 FOOsS9omVrgub/NOyC6uoc1tcy9HPMNwtutbByhoQnnyytNRdz0SoH39U5f0OiIw+0at30S986F UTvQfTlSYDpvjOPC1twv/Q3ub8cIrk7jQkhk21dE1OoNEM24b3G7q+36+3b1omVvzs3hmd6zuDC JntnZ7EHMSGmIpefwGUBldyfpdtFeCJGntDmYqHPtEAEFC9RyYuvM5x+0J/6zL1L0jvkPlTlZAj wBu93XMFJEGPID8YNeHzdlyjcrx/44I1hKsZ7OMkgGIU//8czWUxeZ6KpR2RFj9vFZpZQ0wpSin 07fSuzwkKNVCKPNvD0vdQQruNPKtM8NdsGreRf5tUdzVipMSR6wHHiHYAlWe+qe5euEDO9IAxd3 rjtc/sudemQuITrgOpYAp62t3JrMYvkauUWdafbhIa2Q== X-Received: by 2002:a05:6a00:1392:b0:88d:5832:d96c with SMTP id d2e1a72fcca58-8beb7635d7emr2402379b3a.50.1794569155890; Fri, 13 Nov 2026 03:25:55 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Jamal Hadi Salim Date: Fri, 13 Nov 2026 06:25:44 -0500 X-Gm-Features: AclHuK96mncIjxXhejNUYScJbQHU9ubCEaLBlj3fEgR-aNIYI2z9TX3wJX2a0VM Message-ID: To: netdev@vger.kernel.org Cc: Jiri Pirko , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Victor Nogueira , =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= , =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , cake@lists.bufferbloat.net, Sashiko Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Message-ID-Hash: ACJ4PMPA5EDTZ3P3UW26RGU24GSJAZOS X-Message-ID-Hash: ACJ4PMPA5EDTZ3P3UW26RGU24GSJAZOS X-MailFrom: jhs@mojatatu.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list Subject: [Cake] Re: [PATCH net-next v9 0/4] net/sched: cap the accounted backlog before it can wrap List-Id: Cake - FQ_codel the next generation Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, Nov 10, 2026 at 9:40=E2=80=AFAM Jamal Hadi Salim = wrote: > > This series bounds the accounted backlog of the AQM qdiscs so that it > cannot wrap mod 2^32. > > v1 widened the counters to u64 and was rejected; from v2 on the fix drops > at enqueue instead. The v5 posting was a single patch; at the reviewer's > request it is split into four: > > 1/4 cake: classifier refactor: cake_tcf_classify() returns its result > to the caller. > 2/4 cake: use a dedicated split-GSO list iterator. > 3/4 the fix: drop at enqueue once the stored backlog cannot > represent the packet's accounted length -- the standing > QDISC_MAX_BACKLOG ceiling for ordinary packets, a per-packet > representability check for the larger wire estimates. Covers > fq_codel, cake, codel, pie, fq_pie, dualpi2, RED, pfifo, plug > and gred. > 4/4 cake: split cake_hash() into side-effect-free key extraction (on > the unsegmented skb) and set-associative resolution (after > admission), move the split-GSO path ahead of the resolution, and > tag every deferred split segment. > > For the sashikos: This series targets net-next with no Fixes: (the > aggregate wrap predates every touched qdisc). > Unfortunately something broke in the sashiko reviews. Review for v7 > showed up a while later after v8. So you will see that this series > has fixes (majority in comments and commit logs) from both. > Responding here to address the two sashiko reviews that came out (thanks for getting that out in record time!). Sashiko-nipa found legitimate commit log misstatements; the code is fine. Looking at the history, this patch series has now been going on for 3 months! At some point between v7 and v8 a bunch of merges occurred (one that had the most effect on the accuracy of the commit log was Eric's c6648c9f3b51). I am sure all of us look at the code to make sure we are compatible with latest target tree, but does anyone look at "the comment i made on the commit log i made in v6 is no longer accurate somewhere between v7 and v8" - you have plenty of time in your hands if you do. But on the other hand i admit that the commit log is not accurate anymore. I am honestly exhausted sending this series over and over. I can send a v10 but sashiko will find something to nitpick on. and this could go on for another month and i have plenty of other patches in the backlog this is taking time away from. Thoughts? One other option is i send a fixed v10 and you apply it as fast as possible.. cheers, jamal > Changes in v9 (late Sashiko nipa reviews of v7 and v8, delivered on lore)= : > - 1/4: reword the "The Fix:" heading; this patch is preparation, not a > fix. > - 1/4: the classifier helper's comments now say the caller must drop > the skb, since a terminal action does not take ownership of it. > - 3/4: bound the child backlog as well as RED's aggregate, and re-deriv= e > the aggregate from snapshots taken before the reservation when the > enqueue does not succeed. A child that returns NET_XMIT_CN may or may > not have reduced its ancestors already: pfifo_head_drop, sfq and > fq_codel do, while hhf and skbprio evict a packet and return without > qdisc_tree_reduce_backlog(). Keep what the child actually accounted > for and pass any difference on to the ancestors above RED, so neither > counter can diverge. Verified with two A/B witnesses: RED over a > grafted hhf child (control ends with red_backlog 2042016 !=3D > child_backlog 6177600) and RED under an HTB class over a grafted > pfifo_head_drop limit 1, where an unequal shrinking replacement > otherwise wraps the aggregate and wedges the new admission guard -- > control 4294966052, fixed 92 with RED =3D=3D child =3D=3D HTB. > - 3/4: note that CAKE's own split-GSO branch is the second exception; > the segments it accounts are summed and checked against > QDISC_MAX_BACKLOG by 4/4 before any of them is linked. > - 4/4: add the split-GSO "Conditions to recreate the bug" recipe for th= e > segment-sum rejection at the split ceiling. > - 4/4: the IS_ERR_OR_NULL(segs) segmentation-failure return uses > qdisc_drop_reason(..., QDISC_DROP_GENERIC); __skb_gso_segment() has > already clobbered tc_skb_cb.drop_reason through SKB_GSO_CB, so the ol= d > qdisc_drop() reported an unrelated core reason and skipped > trace_qdisc_drop. > - 4/4: pass the flow_mode snapshot to the later flowchain calls > (cake_get_flow_quantum(), cake_inc_srchost_bulk_flow_count(), > cake_inc_dsthost_bulk_flow_count()) as well, so one enqueue sees one > mode (KCSAN-visible race and stale host index). > > Changes in v8: > - 1/4 is cake-only. fq_codel_classify() is line-for-line the same as > fq_pie_classify(), and fq_pie is not changed by this series, so the > two stay in lockstep: fq_codel keeps its original classify shape and > the fq_codel backlog guard is placed inline in its enqueue path > (3/4) instead. (Toke H=C3=B8iland-J=C3=B8rgensen) > - 3/4: the fq_codel guard sits between idx-- and > codel_set_enqueue_time(), so a dropped packet cannot touch flow > state. The commit message is reworded as suggested. (Toke > H=C3=B8iland-J=C3=B8rgensen) > - 4/4: the original skb is consumed unconditionally right after a > successful split -- that is the caller's reference, since a fraglist > GSO takes the list's own reference on the same skb in > skb_segment_list() -- so the reject branch tags every deferred > segment and drops the whole list with qdisc_drop_all(), and the > admitted path no longer consumes the skb after the walk. (Toke > H=C3=B8iland-J=C3=B8rgensen) > > Changes in v7: > - 1/4: complete the fq_codel_classify() comment (Sashiko nipa v6 > main-2-1, Low). The comment listed only the terminal-action and > no-class-ID cases; the function also returns true when no filter > matched or when the selected class minor is above q->flows_cnt, > and those packets are BYPASS drops, not a fallback to hashing as > in cake. Comment-only, no code change; folded into this resend > since the series is revised anyway. > - 3/4: do not clamp the shared qdisc_pkt_len() (Sashiko nipa v6 > main-2-6, Medium). The clamp silently undercharged BPF > __sk_buff.wire_len, act_police and the HTB/TBF shapers for a valid > large GSO estimate. The initializer now stays truthful for every > input and the overflow protection is enqueue admission: each > affected qdisc drops a packet once the stored backlog cannot > represent its accounted length -- the standing QDISC_MAX_BACKLOG > ceiling covers ordinary packets, and a per-packet representability > check covers the larger wire estimates, which a supported > small-MSS BIG TCP aggregate can legitimately carry above 1 MiB > while its raw length stays within GSO_MAX_SIZE. The consumers read > the real length, and sch_handle_ingress() keeps complete pkt_segs > metadata. > - 4/4: tag every deferred split-GSO segment with QDISC_DROP_OVERLIMIT > (Sashiko nipa v6 gpt-6-astra-2-5, Medium). __skb_gso_segment() stores > SKB_GSO_CB at cb offset 32, aliasing tc_skb_cb.drop_reason, and the c= b > is copied into every segment, so tagging only the head left the rest > with GSO scratch as their drop reason. > - 4/4: snapshot q->config->flow_mode once with READ_ONCE() and pass it > to both hash helpers (Sashiko nipa v6 gpt-6-astra-5-9, Low). The spli= t > introduced two loads with the segmentation work between them. > - Not folded: the 3/4 intermediate-commit split-GSO limitation (4/4 > closes it; the pre-series path was already unbounded) and the > Fixes:/stable suggestions (intentional net-next target). The gemini > v6 TC_ACT_CONSUMED High is the v5 finding already rebutted as > unreachable from a qdisc classify switch. > > v6 rewrite as a four-patch series per Toke H=C3=B8iland-J=C3=B8rgensen's= review of > v5 (split the classifier refactor, the split-GSO iterator, the > overflow guard and the cake hash split; drop the machine-written > prose). Considered the Sashiko gemini v5 TC_ACT_CONSUMED report and > did not fold it (unreachable; see below). Reworded the cake block > comment that had an embedded "/*" (Simon Horman's W=3D1 warning) and > reworded a comment that overstated the classifier's return cases. The > TC_ACT_CONSUMED switch case was dropped from the final 0001 because i= t > still reached __qdisc_drop(); no in-tree producer can deliver > TC_ACT_CONSUMED to a qdisc classify switch (act_ct returns it only on > a clsact/ingress qdisc, act_mirred only for a non-cloning ingress > redirect, and cls_bpf/act_bpf remap an unknown verdict to UNSPEC). > > v5/v4/v3/v2 history: see the v6 posting. In short, v3 adopted the stored > backlog compare qdisc_backlog_at_max() (no double-count of the 1 MiB > headroom, no per-enqueue 64-bit add), moved the classifier and the > ceiling check ahead of the hash/shaper state, and added pfifo; v4 > split the hash keys from the set-associative resolution and handled > the fraglist-GSO self-link; v2 replaced the rejected u64 widening wit= h > the enqueue drop; v1 widened the counters. > > Jamal Hadi Salim (4): > net/sched: cake: return the classifier result to the caller > net/sched: cake: use a dedicated split-GSO list iterator > net/sched: cap the accounted backlog before it can wrap > net/sched: cake: hash before segmenting and reject an overlong split > > include/net/pkt_sched.h | 1 - > include/net/sch_generic.h | 20 +++++ > net/sched/sch_cake.c | 185 ++++++++++++++++++++++++++------------ > net/sched/sch_codel.c | 16 ++-- > net/sched/sch_dualpi2.c | 1 + > net/sched/sch_fifo.c | 6 ++ > net/sched/sch_fq_codel.c | 9 ++ > net/sched/sch_fq_pie.c | 3 +- > net/sched/sch_gred.c | 9 ++ > net/sched/sch_pie.c | 3 +- > net/sched/sch_plug.c | 9 +- > net/sched/sch_red.c | 46 ++++++++-- > 12 files changed, 237 insertions(+), 71 deletions(-) > > -- > 2.43.0 >