From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mail.toke.dk; dkim=pass header.d=mojatatu.com header.i=@mojatatu.com header.a=rsa-sha256 header.s=google header.b=lnTZotav; arc=pass; dmarc=none Received: from mail-pf1-x436.google.com (mail-pf1-x436.google.com [IPv6:2607:f8b0:4864:20::436]) by mail.toke.dk (Postfix) with ESMTPS id 49A2418752ED for ; Mon, 19 Oct 2026 23:39:17 +0200 (CEST) Received: by mail-pf1-x436.google.com with SMTP id d2e1a72fcca58-89f28c3ac7bso794054b3a.0 for ; Mon, 19 Oct 2026 14:39:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1792445955; cv=none; d=google.com; s=arc-20260327; b=bYkk6kq9enSNTOiPC1YtdefiGAQAd6QWmimlPUFsjEYOHj8kqUPKX1OinOw5Kvn8LB zaRkVLmZGN73BSlqAytn8EjpS7VfXx+/l8wNqiy6Vr0EXEDvsauLrTHZSVVzaX+OnuvB ScEYFThKhvBNTM04NK0PuFOr2OruJlSb5oicLqPjI0uOJDOWNFJcUBwfGt1aX+P6OSf3 Yq5poosRU1WpO7pZCvRU8E8NwDFPr5CXS6cO4a1tJ/FbS9ZwMPwVQ6GEcbruxWkLLAHF j8GmvlaXEcg6T9C9R7leBNXj01behFP4BYCPMIAlBijN74bgDiAJm6wyyozm1nQAezid rKRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=YdIEvH0szPm2mof3XdeDVOIQnMVjdWNpvjqDvVaEY5o=; fh=YPKrZ43f/lI1DhdEu+fDgAMRCV/nmh59rPNGFfJL0Xg=; b=jAydsidFvWrjGgNsfVieTz1SMrWKer8ZYznQ3pUKI+k/9AWvwtCn4iGRohKRkSheod n3mCrBinGtc2jOdGgnGXKWgfOWDfRzm1NvN5RhDehEyDjPwOJHaZhxqIwimARDgunIY9 8VWdS3z73wQ8dKqmvizmmkil1O56mrkemniswQjQlLIWSA2ylVsQO3OOCi4/1mEDhMJL Y8rpxpY76/ZNcpyYWrd1EBwuPtBRjSgU7npbmTB1Qo5Pm+h/jNmH0yF2z+DDM6amA79y os6WJZTYjCbe60O7vJghGaKzxPs2YvBJcHdhO6BNajUo7LzVA8JlyyQtuKz7s6Y7zsRK P5TQ==; darn=lists.bufferbloat.net ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mojatatu.com; s=google; t=1792445955; x=1793050755; darn=lists.bufferbloat.net; h=content-transfer-encoding:content-type:cc:to:subject:message-id :date:from:in-reply-to:references:mime-version:from:to:cc:subject :date:message-id:reply-to:content-type; bh=YdIEvH0szPm2mof3XdeDVOIQnMVjdWNpvjqDvVaEY5o=; b=lnTZotavFW5IQlOlPRAuEj8bql7oxgNzyf7eiOQawomHGrJ+V5nPF63XDj4OYdA+FB tDUAikqfVBzjnwrdmUdJbbJfIOOz8sMHg1po+CYvSp2j9m8Mxip/ra4t2meu4EBuAkVS d/cpOVckZMT7BO2UNEtgWhwfedmG9DlJWaYjA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792445955; x=1793050755; h=content-transfer-encoding:content-type:cc:to:subject:message-id :date:from:in-reply-to:references:mime-version:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=YdIEvH0szPm2mof3XdeDVOIQnMVjdWNpvjqDvVaEY5o=; b=SmNkGXeGeup2HowyHAqywOwK2MHMjNZS31EjW4rvALWdtyUj5NC0SVRShRjDBVznlu SsZmaIEilnZYrSGI1lEKy5Ey4cRXuZpVlsEIQuftyw/IYTVTU2zDhC3RxbCIGPfoKD6S TdJC/gAbuxqKUlQcSb6mN/5+m8qMCAo8P4ZpymrJLhznuRcnGmv4O7eqGn5lC4p369lW cSXAEvldzkUfg1y1/VBR3+IrhvkbpGfi9SyV1DMB/DSqD8ViNFKXbs2zArw4wlYGW5t0 N0s7noqc2dVAYQdktBFMOoRibsmWpdUAE5v9wQTIU0xrELYpTS3TJDJoRq+4Jmfm9Pfq 0moA== X-Forwarded-Encrypted: i=1; AKwUvBz80kS3+ubKFNXyOgIzVlguOxkkHE6NoUHZ6Bw4IewgJ9szrsCuiZBoeKhttNoFhow1ufmX@lists.bufferbloat.net X-Gm-Message-State: AFq9FYJZGqmCdhKrMISNcz1fstaoTdX5ld29rag1Fy9ZZx1J2ZVGrkdy IoIyN5ELYcWFfMj7FARugaztFnKFh8nHDvx/mcTC7tdriN88V6IbXqRdO25QtRhtob8aBHYdg2S /enSvri4bV0Ycl5MYNnNcLMtY+8qGeBOxV6zEwZZYZC2nVEVybcw6LA== X-Gm-Gg: AYBFou0FeVh1rSw7gzmsHRkT6AguSGvLNXF0g77sQ4HWUhRB5f953rswZIL9Io16Wsu YtA/Yj4tCpgPbQ6PWse+SpkdRC6NayJLPqxvU5dGHXkgBL6D9uJap4QYZV/rDbZZLByYpxwEfNG eY5quvFVx5BWQ0hrvUayoXmk4nGcbgT69O0exRb4mkjGLt++QXnqTGRqCuNdRvkODcHIoSpZam7 9hBLl8LVWANKW1z0r/LJgJwyDa+rfiub5ReX4KFam2SMFEaVfqZ0MK4N5UjbxtU8T7ZQjazxmno xMFlAna3bmqlRvRl08MPbLkS0BLcorsShJ2oEERtOgO5s7CLs6WJIhIJ/cOkhXofoOMkDnvfEXW PAR2JG9AD5c1rgKxqpD6AgKLu7X5h4PumzPe7xIInIWI0 X-Received: by 2002:a05:6a00:408c:b0:89e:2154:befe with SMTP id d2e1a72fcca58-8a04aa2a249mr6685409b3a.8.1792445954768; Mon, 19 Oct 2026 14:39:14 -0700 (PDT) MIME-Version: 1.0 References: <87ld7t3kl3.fsf@all.your.base.are.belong.to.us> <87ld7twn5c.fsf@toke.dk> In-Reply-To: <87ld7twn5c.fsf@toke.dk> From: Jamal Hadi Salim Date: Mon, 19 Oct 2026 17:39:03 -0400 X-Gm-Features: AclHuK_v_qThEpQTS0k4SvxRYLmwbCwYIgn59ELw6lEuRTWz8aDuR5OJLtdOoCA Message-ID: To: =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= Cc: =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , netdev@vger.kernel.org, Jiri Pirko , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , cake@lists.bufferbloat.net, Victor Nogueira , Sashiko Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Message-ID-Hash: AUKMPJFQ4MWDWL4EWOYUKJJFXTK6RNGK X-Message-ID-Hash: AUKMPJFQ4MWDWL4EWOYUKJJFXTK6RNGK X-MailFrom: jhs@mojatatu.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list Subject: [Cake] Re: [PATCH net-next v2 1/4] net/sched/sch_cake: serialize reconfiguration with the datapath List-Id: Cake - FQ_codel the next generation Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, Oct 19, 2026 at 2:39=E2=80=AFPM Toke H=C3=B8iland-J=C3=B8rgensen wrote: > > Jamal Hadi Salim writes: > > > On Mon, Oct 19, 2026 at 10:53=E2=80=AFAM Bj=C3=B6rn T=C3=B6pel wrote: > >> > >> Jamal! > >> > >> On Mon, 19 Oct 2026 at 15:47, Jamal Hadi Salim wrot= e: > >> > > >> > Hey Bj=C3=B6rn, > >> > > >> > On Mon, Oct 19, 2026 at 9:07=E2=80=AFAM Bj=C3=B6rn T=C3=B6pel wrote: > >> > > > >> > > Jamal Hadi Salim writes: > >> > > > >> > > > This is a follow-up to commit 7cbfb180945c ("net/sched: sch_cake= : fix > >> > > > autorate reconfiguration throttling"). That change only stored > >> > > > last_reconfig_time; it did not address the concurrency between t= he > >> > > > autorate rate update in cake_enqueue() and the netlink reconfigu= ration > >> > > > path, which the original review flagged. > >> > > > > >> > > >> > You are reviewing a very old version - the last one was a v6[1], mos= t > >> > of these fixes are in the "no good deed goes unpunished" from sashik= o > >> > ;-> > >> > I am about to post a v7. Maybe review that one? > >> > >> OMG... sorry for the noise. > >> > > > > Not noise at all - with all these AI dump it is overwhelming. Always > > great to have someone review. Sashiko will always find something to > > whine about - the bikeshedding it engages in is shameless sometimes;-> > > I just sent an update. > > Erm, I think you're confusing patch series? This one is not the one > you're at v7 on, Bj=C3=B6rn did review the latest version AFAICT (and I a= gree > with his comments FWIW) :) Sigh. You are correct - too many patches in flight (in this case both were 4 patch series and had "cake" in the subject). Sorry Bj=C3=B6rn - i will send with your suggestions in place (I notice that both sashikos have responded and bizare with all their bikeshedding skills they both missed reverse xmas;->) cheers, jamal > -Toke