From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw1-x112e.google.com (mail-yw1-x112e.google.com [IPv6:2607:f8b0:4864:20::112e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id C7FD63B29D for ; Fri, 2 Feb 2024 07:08:24 -0500 (EST) Received: by mail-yw1-x112e.google.com with SMTP id 00721157ae682-604059403e9so20387617b3.3 for ; Fri, 02 Feb 2024 04:08:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mojatatu-com.20230601.gappssmtp.com; s=20230601; t=1706875704; x=1707480504; darn=lists.bufferbloat.net; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=AbUHI8hXSl0417ZmZn93pMUO7YG1xwRNmnX/Oh+gVXw=; b=qVILrK5n5BZjjPhAv3vJNcdrXFpOwKA+EvtGz83oxgDSEEFn/IMOoVoyiT1Bs6ESde xr5AhG5yErK5x1Lmw/z70kyEKp1w1+Q6JUjpIUFuutAwOgFZlndAss8S/nS6HNTIayL+ YTCppiksA4jEqjwmgPGOGUTD+ST49vqJqEi91nF4f/TNb03yaYwWrD30/W8zXI/Be7io ZodAkhHEZypBJiFlL27nNEt5mRlzEqUog8uvUuIlZtaFHUP8b4JbPc+XIWQ/9Qf41ReV Fhu5Br9Nbeg6cmblQjJOw3+CfOStzctl+JsCLg1h2BzqD32p51VldVNbkQfSoWmKzLoX EuaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706875704; x=1707480504; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AbUHI8hXSl0417ZmZn93pMUO7YG1xwRNmnX/Oh+gVXw=; b=fgMh5rfwqL12lLi+DODO2gUz+IDCL8p54Ps2B+kHNRz6NKAp9IQlP6TRmgNy5XnhLK XfcZfBqmUWQT0vLfjHK6pTXOufQ1YqTMmopM+PAZMEFcikkVd1KzSMD04uBaC77bX/rY Vi7A+ZZoFMziRAsU57Dt1O8hY+VeIlTe9iagiw/YZN+Mv3MQhzQ0KpI1C0H/SJGHxH42 3hDNsnK316KlxCUzqfHbhJXcAbeUyBI25rXoGfIL8TJXeipZKoZhgPlpqkOdj4fpBtdm XzAgz8D7uBans69BJaDjJffP5Bnj38ZzH+QLmBMlEpx/JknsjZLpp3FNtj9OyDdfK1eN kPNg== X-Gm-Message-State: AOJu0YzRj5m3goM9PV5v/sK1yRQ+L9i1atRffYK9q/A7NPbiE6WiX2Tz kyxPYBdrs9QhqNAfrStgGs+GFAh0rOdMHaxYxQ/wshXCwXSF5G3PKlz8RhZhYs5pSfu7BDPbQm3 U56gzw1P7OdUaHKJjHwGObj786stExC6KpCsw X-Google-Smtp-Source: AGHT+IEjjtQ/DhGAXm7hLk1+I7JJDKeMEgJ/8DH8etGoQz3Y/c+zY06bh/klIto8q9wn+v1N2uLHjxeleIKOIY6i6m0= X-Received: by 2002:a25:2d16:0:b0:dc2:66d4:1544 with SMTP id t22-20020a252d16000000b00dc266d41544mr5634193ybt.55.1706875703633; Fri, 02 Feb 2024 04:08:23 -0800 (PST) MIME-Version: 1.0 References: <20240201130943.19536-1-mkoutny@suse.com> In-Reply-To: <20240201130943.19536-1-mkoutny@suse.com> From: Jamal Hadi Salim Date: Fri, 2 Feb 2024 07:08:12 -0500 Message-ID: To: =?UTF-8?Q?Michal_Koutn=C3=BD?= Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, cake@lists.bufferbloat.net, "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Cong Wang , Jiri Pirko , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= , Vinicius Costa Gomes , Stephen Hemminger , Simon Horman , Pedro Tammela Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [Cake] [PATCH v5 0/4] net/sched: Load modules via alias X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Feb 2024 12:08:24 -0000 On Thu, Feb 1, 2024 at 8:09=E2=80=AFAM Michal Koutn=C3=BD wrote: > > These modules may be loaded lazily without user's awareness and > control. Add respective aliases to modules and request them under these > aliases so that modprobe's blacklisting mechanism (through aliases) > works for them. (The same pattern exists e.g. for filesystem > modules.) > > For example (before the change): > $ tc filter add dev lo parent 10: protocol ip prio 10 handle 1: cgroup > # cls_cgroup module is loaded despite a `blacklist cls_cgroup` entry > # in /etc/modprobe.d/*.conf > > After the change: > $ tc filter add dev lo parent 10: protocol ip prio 10 handle 1: cgroup > Error: TC classifier not found. > We have an error talking to the kernel > # explicit/acknowledged (privileged) action is needed > $ modprobe cls_cgroup > # blacklist entry won't apply to this direct modprobe, module is > # loaded with awareness > > A considered alternative was invoking `modprobe -b` always from > request_module(), however, dismissed as too intrusive and slightly > confusing in favor of the precedented aliases (the commit 7f78e0351394 > ("fs: Limit sys_mount to only request filesystem modules."). > > User experience suffers in both alternatives. Its improvement is > orthogonal to blacklist honoring. > Thanks Michal. We still didnt hear from Stephen, but i think looks solid now. So for the patchset: Acked-by: Jamal Hadi Salim cheers, jamal > Changes from v1 (https://lore.kernel.org/r/20231121175640.9981-1-mkoutny@= suse.com) > - Treat sch_ and act_ modules analogously to cls_ > > Changes from v2 (https://lore.kernel.org/r/20231206192752.18989-1-mkoutny= @suse.com) > - reorganized commits (one generated commit + manual pre-/post- work) > - used alias names more fitting the existing net- aliases > - more info in commit messages and cover letter > - rebased on current master > > Changes from v3 (https://lore.kernel.org/r/20240112180646.13232-1-mkoutny= @suse.com) > - rebase on netdev/net-next/main > - correct aliases in cls_* modules (wrong sed) > - replace repeated prefix strings with a macro > - patch also request_module call in qdisc_set_default() > > Changes from v4 (https://lore.kernel.org/r/20240123135242.11430-1-mkoutny= @suse.com) > - update example in cover letter to existing module (cls_tcindex->cls_cgr= oup) > - tested that ':-) > - remove __stringify in alias macro, net-cls-cgroup instead of net-cls-"c= group" > - pass correct argument to request_module() (Simon) > - rebased on netdev-next/main > > Michal Koutn=C3=BD (4): > net/sched: Add helper macros with module names > net/sched: Add module aliases for cls_,sch_,act_ modules > net/sched: Load modules via their alias > net/sched: Remove alias of sch_clsact > > include/net/act_api.h | 2 ++ > include/net/pkt_cls.h | 2 ++ > include/net/pkt_sched.h | 2 ++ > net/sched/act_api.c | 2 +- > net/sched/act_bpf.c | 1 + > net/sched/act_connmark.c | 1 + > net/sched/act_csum.c | 1 + > net/sched/act_ct.c | 1 + > net/sched/act_ctinfo.c | 1 + > net/sched/act_gact.c | 1 + > net/sched/act_gate.c | 1 + > net/sched/act_ife.c | 1 + > net/sched/act_mirred.c | 1 + > net/sched/act_mpls.c | 1 + > net/sched/act_nat.c | 1 + > net/sched/act_pedit.c | 1 + > net/sched/act_police.c | 1 + > net/sched/act_sample.c | 1 + > net/sched/act_simple.c | 1 + > net/sched/act_skbedit.c | 1 + > net/sched/act_skbmod.c | 1 + > net/sched/act_tunnel_key.c | 1 + > net/sched/act_vlan.c | 1 + > net/sched/cls_api.c | 2 +- > net/sched/cls_basic.c | 1 + > net/sched/cls_bpf.c | 1 + > net/sched/cls_cgroup.c | 1 + > net/sched/cls_flow.c | 1 + > net/sched/cls_flower.c | 1 + > net/sched/cls_fw.c | 1 + > net/sched/cls_matchall.c | 1 + > net/sched/cls_route.c | 1 + > net/sched/cls_u32.c | 1 + > net/sched/sch_api.c | 4 ++-- > net/sched/sch_cake.c | 1 + > net/sched/sch_cbs.c | 1 + > net/sched/sch_choke.c | 1 + > net/sched/sch_codel.c | 1 + > net/sched/sch_drr.c | 1 + > net/sched/sch_etf.c | 1 + > net/sched/sch_ets.c | 1 + > net/sched/sch_fq.c | 1 + > net/sched/sch_fq_codel.c | 1 + > net/sched/sch_gred.c | 1 + > net/sched/sch_hfsc.c | 1 + > net/sched/sch_hhf.c | 1 + > net/sched/sch_htb.c | 1 + > net/sched/sch_ingress.c | 3 ++- > net/sched/sch_mqprio.c | 1 + > net/sched/sch_multiq.c | 1 + > net/sched/sch_netem.c | 1 + > net/sched/sch_pie.c | 1 + > net/sched/sch_plug.c | 1 + > net/sched/sch_prio.c | 1 + > net/sched/sch_qfq.c | 1 + > net/sched/sch_red.c | 1 + > net/sched/sch_sfb.c | 1 + > net/sched/sch_sfq.c | 1 + > net/sched/sch_skbprio.c | 1 + > net/sched/sch_taprio.c | 1 + > net/sched/sch_tbf.c | 1 + > 61 files changed, 66 insertions(+), 5 deletions(-) > > > base-commit: 644c64318de0df5f4ea9f00e4b8cc262b343a93f > -- > 2.43.0 >