From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mail.toke.dk; dkim=pass header.d=mojatatu.com header.i=@mojatatu.com header.a=rsa-sha256 header.s=google header.b=wY32moZI; arc=pass; dmarc=none Received: from mail-pf1-x432.google.com (mail-pf1-x432.google.com [IPv6:2607:f8b0:4864:20::432]) by mail.toke.dk (Postfix) with ESMTPS id D8E72185E93A for ; Mon, 19 Oct 2026 15:47:38 +0200 (CEST) Received: by mail-pf1-x432.google.com with SMTP id d2e1a72fcca58-885cd98d226so867470b3a.1 for ; Mon, 19 Oct 2026 06:47:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1792417655; cv=none; d=google.com; s=arc-20260327; b=QweKmNzb0y6tHUrAQTsovYJhA3nyK4oNEZc5K7HnjmmR0BOW86JNSp9EAgqilWXt0U LIc6OmlxAx5Ki/KC4CZ4abXHquVR5viR7HIi/Tiu2B3vuWXXVY0tvzpyT9QQ8zu4agi7 BkhmNgl/YtsXBa2gPC1b5KWudt2bPxtoaVvndq3zBqC6oB/T5sC1hZfpkH69vGWLfLdY OQHqgZi8fjpqZg9Mvw4OWvsmDTapYErhrO2HWIf4jwqx1Wpls9yq08Iss0NNfKo3LvPB yM3TZki2Be3WfvGPph1CmVi7fCwXwjGo8qcHbERKAjLNyY0mobhHbB/Y7kmdDFSABrnm fg9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=IxkYfjbbzXtZyJeIqZ6QLhzxAx1ox5CXI9h6Gt01KUU=; fh=EqYUK1m1r/Hc5xxnmOmr9B5UjMIzxiIqQTx2BXKAINI=; b=NpJpriW+ZIlMMM8xBo3+oQar3TFfe+SaQB6/JnYIbHItAqxytK69ZAUatwCeD594Q4 t1UgMo+OT3RnSGsmSFK0TR3ZrWeeZ2fs22nXzEyOrJLzTb2E/V2xvjghFEv1XeAXYZ5U iLPiRsu1rUD3hvMafW4DWUC5F2m9GwLsiQjE5lZsWYKuBh6+ylUkspp25SIgw/kMg1Kj 9sqtVpOyJjJdKg5Hbe5TgH4VgTB6TMOb2WF2mSHUkAbkJXSudwjcaTcTGddf5UIwRtZF LB92l/bbMtUJkGBBX1VN6eE4jJNRcs13b3GksuindzKWrIdtTlqt+8iMUU8PNnPCFEP9 JBZA==; darn=lists.bufferbloat.net ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mojatatu.com; s=google; t=1792417655; x=1793022455; darn=lists.bufferbloat.net; h=content-transfer-encoding:content-type:cc:to:subject:message-id :date:from:in-reply-to:references:mime-version:from:to:cc:subject :date:message-id:reply-to:content-type; bh=IxkYfjbbzXtZyJeIqZ6QLhzxAx1ox5CXI9h6Gt01KUU=; b=wY32moZIMOckaBkLyn3upRw6dr2x6QhlpFuJ3zolu/Xj5kAbj5Iscg5Dky4meA2bLM /STv9kvhwIbFHFiGhswM2MZv43OXxr4SSQgPSpWgGtLxuLa/6akwkUZZxk/fVfWNPv25 AwYB2CBGOq5kFrB+WTuzvjHqHx6uMMCv6iURQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792417655; x=1793022455; h=content-transfer-encoding:content-type:cc:to:subject:message-id :date:from:in-reply-to:references:mime-version:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=IxkYfjbbzXtZyJeIqZ6QLhzxAx1ox5CXI9h6Gt01KUU=; b=IKi7W7JY+gdqtRKICO+WkNPhcKtyauHtx0rwnlC5/K2AdnQlG9G4rIyetqZB2FUtSk sjxu4aUFblSPCQnRaAGTUhywDB1LVD584k4h3czPmHgvBO84yiw/LUuIorrL/oBgfvfm Nds6L9Be6W81mAWwmQ72DBmljL1pJ8FkD5q9dvZ4MPKMGxgqpsIpPp9HJQyFxqZd8yz+ t8gS5aPZHhZcUsLP9/dZjeCYnAQo6/Mr3zogjW/xMtVMx51aeufQb+GOrop9En6KI0zK oUpKvbeovr9KW8oYOj2YuBUuVPnwIOLZ4dyVcwCEABXwAM2kusfV5pNZIG9XI3iagpgm prsw== X-Forwarded-Encrypted: i=1; AKwUvBzzBvZkt5Qd2y7iol0ZWzTUlgRpNi645ykZp2+Px+OJW1lykl4V81otP01Sqg2sCzOKvDYp@lists.bufferbloat.net X-Gm-Message-State: AFq9FYJeH7IiPrgIeBdPPAWJi7JHwASa5xeZ1WuW8xNH3YmG4tfau9/W 0ZHurlLkwUcMt69Z93itScVQAJbU3j7nU2luj2u6qC8a9cClgjNCrf1Abuu4JdaqXtA7qoHZoCz AEu3nhlWzBAtcl4pqbM0m8SZIEnQesv3aKCJehnU3v4EIp30ou7RJ2Q== X-Gm-Gg: AYBFou16MGs9S+uhFYTX+lxwKDKWbjQeCdeLRfKqsWl8EwQ7xcSFw7onrbJNFyDhthH f5f/j5jPzLUg3dLhj4kShGDebU69an6weUs2ghuLCg9TOhFf3vxlJ82F0SQgT4ys4MQtZ3csg9f A7vEjyLCpoyZpHeBb2fg3P66VoApRlVJjGWcc+SRMgWl1qC7MUsKVjBBHxrTZPIC8CfAHxqZh9s DI5mpt8uov2oOiekMETJFH3pUJ8qh1OuKtODokr4dc9l12tHrKd+FoqiCRIIH1VaxmuHASqRbl8 AyokNBPpsHOupBWinvHI5VgzAme7hnmndypORFQCWio5hrxfmAVGZ0MGkOmCSCqU/UdEHZkWMcE du9PIgr/iPK+TsqiV0I9oHsDdDdmIzkdgpR2402ofsxlY X-Received: by 2002:a05:6a00:2d1a:b0:89f:f166:e221 with SMTP id d2e1a72fcca58-89ff166e494mr5001339b3a.46.1792417655490; Mon, 19 Oct 2026 06:47:35 -0700 (PDT) MIME-Version: 1.0 References: <87ld7t3kl3.fsf@all.your.base.are.belong.to.us> In-Reply-To: <87ld7t3kl3.fsf@all.your.base.are.belong.to.us> From: Jamal Hadi Salim Date: Mon, 19 Oct 2026 09:47:21 -0400 X-Gm-Features: AclHuK_kzp92HQLPFnjpkI2erNoFI6v8vjMiGON8GWcsHv6WbmNHliLjXp1wBk8 Message-ID: To: =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= Cc: netdev@vger.kernel.org, =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= , Jiri Pirko , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , cake@lists.bufferbloat.net, Victor Nogueira , Sashiko Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Message-ID-Hash: HNNVFD2UY5RSUJQRUD7NKHOUQIK2GQ3R X-Message-ID-Hash: HNNVFD2UY5RSUJQRUD7NKHOUQIK2GQ3R X-MailFrom: jhs@mojatatu.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list Subject: [Cake] Re: [PATCH net-next v2 1/4] net/sched/sch_cake: serialize reconfiguration with the datapath List-Id: Cake - FQ_codel the next generation Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Hey Bj=C3=B6rn, On Mon, Oct 19, 2026 at 9:07=E2=80=AFAM Bj=C3=B6rn T=C3=B6pel wrote: > > Jamal Hadi Salim writes: > > > This is a follow-up to commit 7cbfb180945c ("net/sched: sch_cake: fix > > autorate reconfiguration throttling"). That change only stored > > last_reconfig_time; it did not address the concurrency between the > > autorate rate update in cake_enqueue() and the netlink reconfiguration > > path, which the original review flagged. > > You are reviewing a very old version - the last one was a v6[1], most of these fixes are in the "no good deed goes unpunished" from sashiko ;-> I am about to post a v7. Maybe review that one? cheers, jamal [1] https://lore.kernel.org/netdev/QDISC-BA27.v6.r0.20261014054826@mojatatu= .com/