From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mail.toke.dk; dkim=pass header.d=mojatatu.com header.i=@mojatatu.com header.a=rsa-sha256 header.s=google header.b=wW1ECzZG; arc=pass; dmarc=none Received: from mail-pf1-x434.google.com (mail-pf1-x434.google.com [IPv6:2607:f8b0:4864:20::434]) by mail.toke.dk (Postfix) with ESMTPS id 2FCAA1879955 for ; Tue, 20 Oct 2026 12:07:04 +0200 (CEST) Received: by mail-pf1-x434.google.com with SMTP id d2e1a72fcca58-8a05b210703so999615b3a.0 for ; Tue, 20 Oct 2026 03:07:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1792490823; cv=none; d=google.com; s=arc-20260327; b=clwfp5JI51r/HSWK3AX0VIIHqM/UELfKAo/vNaRgW8tNnglW/p5YzzaDUOs24bwZOe 6d5zcO7XasJXUxG4Pj+PlbdBvEIEEZeT84L+IXZdUQzykjYGAh0cZHZgyolEIdwKTS85 oWH/3KxtMUFNR11CXYu2u0b86DaZgnxWMuKjJY5wNgy5mewTdyXT0EcUoyewDkXsBiOd 6yh5IRf6Hh9AkYRs8T3kgNpwpM7dvBmnxnZxNU5DknCLT+4nJZCgFza51rRJqxWtgoxu lFb263oOeGQ4OMyZTEvq+D5IFebD1Q2RICm+V/DAvkR3bIpNr0DqZIxG+pma0YPYyN9I VBsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=gqk4kcmRoMaSTvrG4XMjC0bfnvl+ByKIzfnkUV+Ycig=; fh=XvTb3aLiZ1FKErqLAqJ5OktpWDueYdZrTJcUyjgWanI=; b=YKljycGStozk0hZiUWsBsup5yHxS6+q2RrrhgX3CoEc1ym4TCyEQtZ5MDOQjGd3fmt hyGvPFc1O9RQe6QLpl6PrJkHwEGqNMri9LLmXOqAJReWu9u5oQXK8tRI5Z7dDYbaB159 xkMrphA17oHPQQjaTXQIj8jIS1TU4DbYc0MZDZ3Vbi7Gf7yqOUBT4VZpWccY407srqFW R9sBV+nKMQZmLKzKYTY7umAeTXJbLsz++48QmHswFcAuCoshtj6yJYLf+gyp/lfpUScZ lPmrm1DY6xTi4aQd4YEZwuFS/+3DnEVr/lW04ZWJ9AMCxw7Fh1ce4RULQJJXON3V4Sd3 7y3w==; darn=lists.bufferbloat.net ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mojatatu.com; s=google; t=1792490823; x=1793095623; darn=lists.bufferbloat.net; h=content-transfer-encoding:content-type:cc:to:subject:message-id :date:from:in-reply-to:references:mime-version:from:to:cc:subject :date:message-id:reply-to:content-type; bh=gqk4kcmRoMaSTvrG4XMjC0bfnvl+ByKIzfnkUV+Ycig=; b=wW1ECzZGMTpGnSmcJ+9xCGRhXbS9J6+kwMDt7xfNmnWskgJfaWmx3q7dP89Wk4mrm0 lrC32VASX9ZrNsyVRRAo12VxTWGoTSeKPlnsYXoGqEhcWRgLQeZe3MORaJIDiHU3cuAZ BBgNhvuqgjR/Q2v9I5a8cfXy9kIpe0fic3pRI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792490823; x=1793095623; h=content-transfer-encoding:content-type:cc:to:subject:message-id :date:from:in-reply-to:references:mime-version:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=gqk4kcmRoMaSTvrG4XMjC0bfnvl+ByKIzfnkUV+Ycig=; b=0tOJ6f7hZnGVjpEHMA/qVeGEdk7H9c0wOypdre3vl0a/A9r6uI6cCOhYAPrpwSeBJb tdmPAptKuVHNOypwFByrLwxYaoC04hr4ouQrwqetPjLlICEgCt7a8WekF2SRU5jE8tKA 29PZkADrBAyumHw5hpMWxQ+NGkECKZye6PJPV2Y1hnGQgzxqfjtk1u72/wYT+ovXi2Qk kQIVJUTKTklroMNHKomPZTsKytwgZ47WF/IK6fg+p/zhLaC6FCY5Y/rVvB8HS8R/8T7h bhhrKdG4H3Uea4164IPgkUR645CBEnLZcKvukx6XJr24XOYgM9zKu9TxpCP5oLRsv4VZ TTHA== X-Forwarded-Encrypted: i=1; AKwUvBwSukKxQVQgvLAzYTeqZGN0PeLzDToP0QYVdEyx/VS1fxTUqifurtbAjXpaQ+K/wBvGs0/7@lists.bufferbloat.net X-Gm-Message-State: AFq9FYLpDkyHJHrC9TlGpEHH/ci4mpLasiKqBjHzHWxHtEjObRAOqzdj A2cgqIPBHoVGFNggEU82JpSse4i7rPFo7ysUgVbIar2gYJuszit26PQkpUgbdloScxvEvxKZfTu g8eTrxdK4VUVLI2Flv3jubnIrZHDbezxQS+J4MpBc X-Gm-Gg: AYBFou0Y+SjfURpHYKGya8nZp7EypQ3TeVRtQsPJ5Zmlbdija9TmkOnazjCaCjdPh6G w28tvJA99QAhZZs7worcq2+IjGRyvclJpOmer8SPNJOfNQHJSs1GAIMPCC2hC0qmsaPy7dF9Ibh +nclWf5o2MEVB0wj/oVTqYA/EnCr8pAO4Z+eYP/bnVPoZcHCKrYILOgU7/4fcOabvWWBCGeqqul kK5NjkSBDxwGWb6O51ZJ6v1lYD8E4Nu13FT2HpluMag8CsTxADTK5RHDVECV9WbaSnaqy5W7fEd GJEJCHl1WQVKV37kVpsFr33ZV3HswshhVQ2MPTgiWPGDdRXA6tSHXw2AANYSqxJABMzsjLoesYw foH/G5bLzZOkzGv4Kpoa6Zf3qQNiLlEHXPQ== X-Received: by 2002:a05:6a00:10c7:b0:881:fffd:26ab with SMTP id d2e1a72fcca58-8a04be37532mr8001944b3a.24.1792490822862; Tue, 20 Oct 2026 03:07:02 -0700 (PDT) MIME-Version: 1.0 References: <87wlrdwof7.fsf@toke.dk> <875wywvjct.fsf@toke.dk> In-Reply-To: <875wywvjct.fsf@toke.dk> From: Jamal Hadi Salim Date: Tue, 20 Oct 2026 06:06:51 -0400 X-Gm-Features: AclHuK8PGEkccFOWafkEkHCeXxJeERy7lXG0VwKRnOb1QP0RMA5crHAy1snL_Kk Message-ID: To: =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= Cc: netdev@vger.kernel.org, Jiri Pirko , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Victor Nogueira , =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , cake@lists.bufferbloat.net, Sashiko Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Message-ID-Hash: W52C3AJXK3FV5ZKXPBJUZSWFKCF5H62W X-Message-ID-Hash: W52C3AJXK3FV5ZKXPBJUZSWFKCF5H62W X-MailFrom: jhs@mojatatu.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list Subject: [Cake] Re: [PATCH net-next v7 1/4] net/sched: cake, fq_codel: return the classifier result to the caller List-Id: Cake - FQ_codel the next generation Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, Oct 20, 2026 at 4:58=E2=80=AFAM Toke H=C3=B8iland-J=C3=B8rgensen wrote: > > Jamal Hadi Salim writes: > > > On Mon, Oct 19, 2026 at 2:11=E2=80=AFPM Toke H=C3=B8iland-J=C3=B8rgense= n wrote: > >> > >> Jamal Hadi Salim writes: > >> > >> > The Fix: > >> > cake and fq_codel run an optional external classifier from their enq= ueue > >> > path and then compute the flow hash inside the helper. Have the help= er > >> > return the filter's overrides (cake) or a 1-based flow index or a re= quest > >> > to hash (fq_codel) instead, so the caller owns the flow selection. > >> > > >> > This is preparation for the accounting changes that follow. Packet > >> > classification and flow selection are unchanged. > >> > >> It's not clear to me why this change is needed at all for fq_codel? > >> fq_codel_hash just does a reciprocal_scale() of the skb hash, it doesn= 't > >> mutate any qdisc state. So why can't fq_codel_classify not just stay a= s > >> it is? > > > > It is not functionaly needed for fq_codel, it is more because these > > two are cousins and simplifies subsequent patches. > > Note in patch 4 we force the same semantics on cake as in fq_codel > > (classifier decides the drop, the caller owns flow selection). Keeping > > fq_codel's classify the same makes patch 3 hunks in the two files > > similar. There is another reason: the old helper encoded "drop" as a > > magic return and carried the 1-based +1 arithmetic on every return > > path. > > But you're not making the same change to fq_pie, although its classify > function is line-for-line the same as fq_codel. I think it's better to > keep those two the same; you can add the new check to fq_codel between > the 'idx--' and 'codel_set_enqueue_time()' lines just fine. > > > In any case, unless you feel strongly i would rather keep it. > > Well, see above :) Ok, i will drop it ;-> cheers, jamal > -Toke