From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mail.toke.dk; dkim=pass header.d=mojatatu.com header.i=@mojatatu.com header.a=rsa-sha256 header.s=google header.b="iS08X/Ln"; arc=pass; dmarc=none Received: from mail-pf1-x430.google.com (mail-pf1-x430.google.com [IPv6:2607:f8b0:4864:20::430]) by mail.toke.dk (Postfix) with ESMTPS id 2DF68185F998 for ; Mon, 19 Oct 2026 18:03:10 +0200 (CEST) Received: by mail-pf1-x430.google.com with SMTP id d2e1a72fcca58-8a04d34e294so971128b3a.3 for ; Mon, 19 Oct 2026 09:03:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1792425789; cv=none; d=google.com; s=arc-20260327; b=aewqkglRPuO70+Vm9cduYkY+yli1ZdCh8WblgPNSdgOqyJ6OZ8qOrt18kH4kY4qczO YNAW6lq4u9guvn54whyKxUv8EeQQQB1UUxaABpLU9aQDHOkruhs37YKzCB4tZKf00elb 2L8XqE/rxrUa50eJkoECpX1o4AsNid6dpS+O18idWrPVEyoANcqoCTnrHFfB+eZSenDx xTvc3NnPNFxCGQ5RO5FLyqLNKMC4nL/NW30HWRlw4RLSx4cMjRV/kw60B20ORARwCYQM hJV7uivacNYCBP/rP/Dt9ceNlo3HILDiBWyezTWufoGG0hSp5x8YwbwnrJtz/bVJcKWC DSSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=RbLiIfPw2q80htvwYCithB+heGpaY2y+RO++XY5n8fo=; fh=4cM9wuAozJjevpexX9kBas9+ki5LkJa/Nje9WZ1ni9A=; b=e6kvkCUiW7i22OzHN2jPSXQwWWafKUsir+xhdZ1EADap/6tammcDp0sz99SyhIix19 5NTWe3cq/dBnj4THW48ooi0f3iz8IayBfbmzUrxCkxlGyDW4VWaKUHZryH93zIWfh0e9 80f2O5D1MNE7PtLD1jQPE3DhJMOulB/5rkIYnwWnHR0T6fTjrVhcMDmKQ3s73YsLKCwo enLT+hKRLXB9OjHrcsbyNeSQkoWlTwqI29QfU3IEmjJzvHUtpeCIPb46DNxlHQgaD/74 E/OHBFnsV1b0flYoEc64G9p1IKPdw/H6UNNkq6LCoskJZBXYr/zw/kMUYKjUHxkF6s0E OvNw==; darn=lists.bufferbloat.net ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mojatatu.com; s=google; t=1792425789; x=1793030589; darn=lists.bufferbloat.net; h=content-transfer-encoding:content-type:cc:to:subject:message-id :date:from:in-reply-to:references:mime-version:from:to:cc:subject :date:message-id:reply-to:content-type; bh=RbLiIfPw2q80htvwYCithB+heGpaY2y+RO++XY5n8fo=; b=iS08X/LnvpjnyvRaUv7w5WLueRCC58Oi3cfuaCIyg9cRx4j0MnfDyeKcJCarjk+Mj6 hlBmfvqVF+3WNs9+bGYZ8ivSskOqfSNdrYow4/aaRHeFj2LZgYPqubSBAPhrQImRyk7L OC3HLsYahMzje6M8PkgUTMxL5sanVsmoavOnM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792425789; x=1793030589; h=content-transfer-encoding:content-type:cc:to:subject:message-id :date:from:in-reply-to:references:mime-version:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=RbLiIfPw2q80htvwYCithB+heGpaY2y+RO++XY5n8fo=; b=rCoroB/iDvozdYATEWz/oPUXXZT7y7Z3BIL//SfsGIgHmPFaouqH3Qw56uSJnoF2sF PBKf1Epqhgtv3umPgRfwbQulYq9hsKtp0YH86n8zpCLQzYC8YMj0n3XNp6edrubX5+oW eyjHFFVL3AaWzFQiRkwF4VhbvBYrePx/FxWb32pxVBX5QOAheryWU/6/kb6nAkFCBS/L /mzgJkWnnCCo3BtKEpxAnILQ/5W+WohRutUOD4SgVT7s0wxmYs925Sep4gDGAZKRxAN4 LFTcC9CjrlkFHT3zdQrzE421WJqzbB9HaKWCDnQDsQEKYdFVYmyroz+0hDpb4fNL7XjN LJMA== X-Forwarded-Encrypted: i=1; AKwUvBzOUhbkKlzlx4SAtLTlqzudoea2G13JEnZKBWWOV6u2syzuCqJ3f40yMVJeTBcd2JYb9q1r@lists.bufferbloat.net X-Gm-Message-State: AFq9FYKxkK89dURDxYU9nH8a1MZS0pNo573e9dlx6AwjEh+EXJQRNV/+ TjA8fjcADEBeZGTIUIg/pavICnQ5siuhoR8Ia1cBFUIrm9glll+TJT8N1xAZ0deLArO7T1fDynv 24uabU/Ke0F5ZKNz/PojTZrCH1Fm/TmFMWoGST+Gq X-Gm-Gg: AYBFou2Psnsi79MH4oHMPVmtNsE2U0NCnwL8ikcDbjKuLYoj6Gjtj8IaNqK8/cuMD76 zJkgZF3fsaY02N96oBUGOP1JYk2tUuK4CfTSXLytqJhVCJsaVOxvIgGSJiVxJTL5OnTqBggOeGr BkBX5XHDanm+LnOppNw5qDCe2C4Knby/azQAyp1D56t2TiZibAOH2DuPnUToQ+91WUXPBBy3eqT dTa4e7Vom0iLqqJ09xXYTVQNy1ULQjxT6Mzi+TIM8bVdd3W5HRaIULIeX/VjK+C5BzIHvsprsnP TEy++0sp9OFp0tXU7Kp/dpYrtfdNmfhvanhykGgSolMmDob1L/WRlZpaLh1tSToJNYIjVx0x6i7 0/xm1SzrQ17sCxdNDnEl9MG6Pgl7Z8uGm5kJdpMFR/mEHBOnBiYNZr9BQa1subACg1QO8lXzfvS 3VMndQQqSB462RCDgGFBCeMoD1v46AcuK7sIT3 X-Received: by 2002:a05:6a00:2da4:b0:8a0:2914:5d27 with SMTP id d2e1a72fcca58-8a04c43653emr5859750b3a.44.1792425788967; Mon, 19 Oct 2026 09:03:08 -0700 (PDT) MIME-Version: 1.0 References: <87ld7t3kl3.fsf@all.your.base.are.belong.to.us> In-Reply-To: From: Jamal Hadi Salim Date: Mon, 19 Oct 2026 12:02:57 -0400 X-Gm-Features: AclHuK98yjpUr4du6cnGnVd5CFRnSyfIIWkx7bK1GtpKEViD0x2r6Mmpiqnmitw Message-ID: To: =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= Cc: netdev@vger.kernel.org, =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= , Jiri Pirko , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , cake@lists.bufferbloat.net, Victor Nogueira , Sashiko Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Message-ID-Hash: IQMDFF76GTCSBPGCWOL222CYTAYAIOI5 X-Message-ID-Hash: IQMDFF76GTCSBPGCWOL222CYTAYAIOI5 X-MailFrom: jhs@mojatatu.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list Subject: [Cake] Re: [PATCH net-next v2 1/4] net/sched/sch_cake: serialize reconfiguration with the datapath List-Id: Cake - FQ_codel the next generation Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, Oct 19, 2026 at 10:53=E2=80=AFAM Bj=C3=B6rn T=C3=B6pel wrote: > > Jamal! > > On Mon, 19 Oct 2026 at 15:47, Jamal Hadi Salim wrote: > > > > Hey Bj=C3=B6rn, > > > > On Mon, Oct 19, 2026 at 9:07=E2=80=AFAM Bj=C3=B6rn T=C3=B6pel wrote: > > > > > > Jamal Hadi Salim writes: > > > > > > > This is a follow-up to commit 7cbfb180945c ("net/sched: sch_cake: f= ix > > > > autorate reconfiguration throttling"). That change only stored > > > > last_reconfig_time; it did not address the concurrency between the > > > > autorate rate update in cake_enqueue() and the netlink reconfigurat= ion > > > > path, which the original review flagged. > > > > > > > > You are reviewing a very old version - the last one was a v6[1], most > > of these fixes are in the "no good deed goes unpunished" from sashiko > > ;-> > > I am about to post a v7. Maybe review that one? > > OMG... sorry for the noise. > Not noise at all - with all these AI dump it is overwhelming. Always great to have someone review. Sashiko will always find something to whine about - the bikeshedding it engages in is shameless sometimes;-> I just sent an update. cheers, jamal > Bj=C3=B6rn