From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-x242.google.com (mail-pf0-x242.google.com [IPv6:2607:f8b0:400e:c00::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 25F6F3B29E for ; Fri, 18 May 2018 00:27:29 -0400 (EDT) Received: by mail-pf0-x242.google.com with SMTP id c10-v6so3110857pfi.12 for ; Thu, 17 May 2018 21:27:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Br0nzfjtrO2r7y9KBgIl8rKX8mP2LtqEP0FlNXiCJm8=; b=XGCBgTxjykp3Gkg1uQEDI4juYc4blUKyRkFj0idekVi1JbAFFvaF7SoaVDz3A816kN lDTWrT/o68OTO9UZ0hXYuS6m8fgawoGaZ+f3j0VU4wiLzREza3+oW9FkZ89v9uwMmLco 7dNG/Vz30EaWzqHAD31w8BxHamG9LIS/lfDDAnNdX+nEXfa2IYsGlYwSpd4UWJpbDT8E cIoxFpwYmBTGMD014xIqa7y9Zi0NKRg1KNnv8fpvE/Z86gWV8EirBGitNtlAYGlH1il7 XD8pKjqrg9JdKBEPl4TgTqybXlwAUIVnl4Ua92LXXGJdn2M2S0M24k4tT2j30Y/uM6YG E91g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Br0nzfjtrO2r7y9KBgIl8rKX8mP2LtqEP0FlNXiCJm8=; b=O0amyLF+04WCAh6l/AEBvs1tKq5Hov2nN8LXuvtnNX5XLYr3odZwa3lv9D0FQ7gnBl Ov4uQYCvAhGyH8De6czk0aeb9a2Cwd72G/YrEVzcXzBxpHKGntUqXh8z0QOPbltb6yXK 2Ln2PCmFI23j7RCUiTlIFKJWmbzKNpCOeQs2mTLeE9LRk8cNEL3HM8TCOPwVss/CwcJ0 0ThqQgVU3BFbKAaxDlNG0KhWc/8iqct5x1NwPw+OyYE3c7ZIUslUUtZfM8n36ccZsyOl y6aCtc8HT4iIsDiGzO/VgZotvcDw7PhYKupswwZ5VccPfqkzYZF4DSdDREhilPKnUzaQ oEEQ== X-Gm-Message-State: ALKqPwcCThuFfstd3/HHDR4DyRlM7FKigdz+Vt2WnuGLbaohESTA1D7J IeXcpm/Zvr+maLo/zbc6gfwO+rvcYZJk9ac0Whw= X-Google-Smtp-Source: AB8JxZqTiIl/iYgFqNyPPp4hJHiYncfm4wt0mmFJSLu4Qcf+yM8ewt/IqWRm/rYVwAK6WQHTRgFtnu1F2tKA+oyF84U= X-Received: by 2002:a63:7807:: with SMTP id t7-v6mr6179515pgc.125.1526617648326; Thu, 17 May 2018 21:27:28 -0700 (PDT) MIME-Version: 1.0 Received: by 10.236.179.152 with HTTP; Thu, 17 May 2018 21:27:07 -0700 (PDT) In-Reply-To: <87in7my196.fsf@toke.dk> References: <152650253056.25701.10138252969621361651.stgit@alrua-kau> <152650254614.25701.1377066681230937234.stgit@alrua-kau> <87in7my196.fsf@toke.dk> From: Cong Wang Date: Thu, 17 May 2018 21:27:07 -0700 Message-ID: To: =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= Cc: Eric Dumazet , Linux Kernel Network Developers , Cake List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailman-Approved-At: Fri, 18 May 2018 06:39:37 -0400 Subject: Re: [Cake] [PATCH net-next v12 3/7] sch_cake: Add optional ACK filter X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 May 2018 04:27:29 -0000 On Thu, May 17, 2018 at 4:23 AM, Toke H=C3=B8iland-J=C3=B8rgensen wrote: > Eric Dumazet writes: > >> On 05/16/2018 01:29 PM, Toke H=C3=B8iland-J=C3=B8rgensen wrote: >>> The ACK filter is an optional feature of CAKE which is designed to impr= ove >>> performance on links with very asymmetrical rate limits. On such links >>> (which are unfortunately quite prevalent, especially for DSL and cable >>> subscribers), the downstream throughput can be limited by the number of >>> ACKs capable of being transmitted in the *upstream* direction. >>> >> >> ... >> >>> >>> Signed-off-by: Toke H=C3=B8iland-J=C3=B8rgensen >>> --- >>> net/sched/sch_cake.c | 260 ++++++++++++++++++++++++++++++++++++++++++= ++++++++ >>> 1 file changed, 258 insertions(+), 2 deletions(-) >>> >>> >> >> I have decided to implement ACK compression in TCP stack itself. > > Awesome! Will look forward to seeing that! +1 It is really odd to put into a TC qdisc, TCP stack is a much better place.