From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <xiyou.wangcong@gmail.com>
Received: from mail-pf0-x236.google.com (mail-pf0-x236.google.com
 [IPv6:2607:f8b0:400e:c00::236])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by lists.bufferbloat.net (Postfix) with ESMTPS id 54E7A3BA8E
 for <cake@lists.bufferbloat.net>; Tue,  1 May 2018 18:32:10 -0400 (EDT)
Received: by mail-pf0-x236.google.com with SMTP id j11so10058033pff.10
 for <cake@lists.bufferbloat.net>; Tue, 01 May 2018 15:32:10 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=mime-version:in-reply-to:references:from:date:message-id:subject:to
 :cc; bh=6vDqCm2tQgWhx7BbF6IjBX4ACIZ9UMF9Pa9hzFwUZ8c=;
 b=eyju+SRGmLdrnpmzAg5jasumRFr/j1YPEGjJBAq9Atwnk7H5iR94rEfZB3vQFZuFRb
 PnjqAUGyqaXIxUHzFYD0APyXAyb9NmO5omizx362W7Ct+j2CQa+fLsAXrayCEXTCpm9S
 /Q2yWJlbhtM063VJTQQh33FnV55Nnb4oQ5fQq70zp4d6uqEVnI2SvfUgvwj+7WIksr5a
 AzVZL57T3GaWqf72gwf+mw4bbdyu43psF+7En27a82o/LteBydU5EVN8UQNrtykJUEaV
 +RAP6wwTjBIZxZIeFdOuMNh8gCjzUgRv7fzxJyXQx68Ix1NQAi3/b1hs6UI2aVIjNxox
 1b2w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:in-reply-to:references:from:date
 :message-id:subject:to:cc;
 bh=6vDqCm2tQgWhx7BbF6IjBX4ACIZ9UMF9Pa9hzFwUZ8c=;
 b=m/tJMfGZe5VViHwKw8/oE6eE8A0ZzDaGN+uD34TDRDm9pF0Kr4S1cUt6YjcwqdMN6t
 Qwa7uqRYbuEULQw1tFOBg4fz6cn3lsYrj6dXTHwe9MOLIcLcSyNZ3k1X+4yJWWaX2rNw
 gNjUjL+0lHv1tNxGdeFDqhafZFy5iBP3aCo28sV3i2ujFCk0s2irhZDtQOx01Wv95txw
 SUM1kmOhYc/EjqsvfbII27ZMpNXgxtMj51nuTC4cweMTVN5Hf9LblVobpW6cBJIilfaQ
 AbISkWRWcFrJudN5XHZymggc1m07Nlxql/ZqY9a+WA8X6sd8PXr9HY6kGOSsXfHnHuuP
 evkA==
X-Gm-Message-State: ALQs6tA1oPQmqoUlVaIWnaToMW2KTe7aH5eVVQNGRlMfItJDkbaf+OOC
 NRIwTaaLLmteFm44IgDx3vsFonPVDvKTyEMfaRg=
X-Google-Smtp-Source: AB8JxZqb1r/T30popYMIUt6Q3iFS1A07TD05n8hPWGiclCs0VsMns4OjtoQp4BYD9qTkKLk6M1myMq4ATRS0iOs6M4A=
X-Received: by 10.98.201.135 with SMTP id l7mr16880865pfk.221.1525213929496;
 Tue, 01 May 2018 15:32:09 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.236.179.152 with HTTP; Tue, 1 May 2018 15:31:49 -0700 (PDT)
In-Reply-To: <4ec8da81-8671-f434-bada-27088b09ce7b@gmail.com>
References: <20180429213439.7389-1-toke@toke.dk>
 <CAM_iQpWVrhoo+PjguBLYqwyGyX98Cv3-M=G+CbHrwBom13fwZQ@mail.gmail.com>
 <CAA93jw6F+c-QRXe+MA2QmRkwiKEBqFgOFKTvWGfO7FvCQ5tFvw@mail.gmail.com>
 <dff5ba09-1b81-7cd8-4be3-e7a419797d8e@gmail.com> <878t932ont.fsf@toke.dk>
 <4ec8da81-8671-f434-bada-27088b09ce7b@gmail.com>
From: Cong Wang <xiyou.wangcong@gmail.com>
Date: Tue, 1 May 2018 15:31:49 -0700
Message-ID: <CAM_iQpUa8snecbrdKrtj6VPYzVrbf__Z-hvTePXND0nMroPrWQ@mail.gmail.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= <toke@toke.dk>, 
 Dave Taht <dave.taht@gmail.com>, 
 Linux Kernel Network Developers <netdev@vger.kernel.org>,
 Cake List <cake@lists.bufferbloat.net>
Content-Type: text/plain; charset="UTF-8"
X-Mailman-Approved-At: Tue, 01 May 2018 19:02:31 -0400
Subject: Re: [Cake] [PATCH net-next v6] Add Common Applications Kept
	Enhanced (cake) qdisc
X-BeenThere: cake@lists.bufferbloat.net
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: Cake - FQ_codel the next generation <cake.lists.bufferbloat.net>
List-Unsubscribe: <https://lists.bufferbloat.net/options/cake>,
 <mailto:cake-request@lists.bufferbloat.net?subject=unsubscribe>
List-Archive: <https://lists.bufferbloat.net/pipermail/cake>
List-Post: <mailto:cake@lists.bufferbloat.net>
List-Help: <mailto:cake-request@lists.bufferbloat.net?subject=help>
List-Subscribe: <https://lists.bufferbloat.net/listinfo/cake>,
 <mailto:cake-request@lists.bufferbloat.net?subject=subscribe>
X-List-Received-Date: Tue, 01 May 2018 22:32:10 -0000

On Tue, May 1, 2018 at 12:12 PM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
>
> I guess that nobody really wants to really review Cake if
> it is a file with 2700 lines of code and hundreds of variables/tunables.
>
> Sure, we have big files in networking land, as a result of thousands of changes.
>
> If you split it, then maybe the work can be split among reviewers as a result.
>

+1

At *least* split it into CAKE without ack-filter and ack-filter implementation.