Cake - FQ_codel the next generation
 help / color / mirror / Atom feed
From: Cong Wang <xiyou.wangcong@gmail.com>
To: "Toke Høiland-Jørgensen" <toke@toke.dk>
Cc: "Linux Kernel Network Developers" <netdev@vger.kernel.org>,
	"Cake List" <cake@lists.bufferbloat.net>,
	"Toke Høiland-Jørgensen" <toke@redhat.com>
Subject: Re: [Cake] [PATCH 1/4] sched: Avoid dereferencing skb pointer after child enqueue
Date: Tue, 8 Jan 2019 17:38:55 -0800	[thread overview]
Message-ID: <CAM_iQpVcw3+Crg_1vR4sPfG2v+arQVMY2yzBjp7yw296xCaN6Q@mail.gmail.com> (raw)
In-Reply-To: <20190107194733.31138-2-toke@toke.dk>

On Mon, Jan 7, 2019 at 11:50 AM Toke Høiland-Jørgensen <toke@toke.dk> wrote:
> @@ -1254,7 +1256,7 @@ static int qfq_enqueue(struct sk_buff *skb, struct Qdisc *sch,
>         if (cl->qdisc->q.qlen != 1) {
>                 if (unlikely(skb == cl->qdisc->ops->peek(cl->qdisc)) &&


Isn't this comparison problematic too? While you are on it...

  reply	other threads:[~2019-01-09  1:39 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-07 19:47 [Cake] [PATCH 0/4] sched: Fix qdisc interactions exposed by using sch_cake as a leaf qdisc Toke Høiland-Jørgensen
2019-01-07 19:47 ` [Cake] [PATCH 1/4] sched: Avoid dereferencing skb pointer after child enqueue Toke Høiland-Jørgensen
2019-01-09  1:38   ` Cong Wang [this message]
2019-01-09  8:14     ` Toke Høiland-Jørgensen
2019-01-10 18:16       ` Cong Wang
2019-01-07 19:47 ` [Cake] [PATCH 2/4] sched: Fix detection of empty queues in child qdiscs Toke Høiland-Jørgensen
2019-01-07 19:57   ` Dave Taht
2019-01-07 19:47 ` [Cake] [PATCH 3/4] sch_api: Allow reducing queue backlog by a negative value Toke Høiland-Jørgensen
2019-01-07 20:54   ` Eric Dumazet
2019-01-08  9:55     ` Toke Høiland-Jørgensen
2019-01-07 19:47 ` [Cake] [PATCH 4/4] sch_cake: Correctly update parent qlen when splitting GSO packets Toke Høiland-Jørgensen
2019-01-08 21:30 ` [Cake] [PATCH 0/4] sched: Fix qdisc interactions exposed by using sch_cake as a leaf qdisc David Miller
2019-01-09  8:37   ` Toke Høiland-Jørgensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAM_iQpVcw3+Crg_1vR4sPfG2v+arQVMY2yzBjp7yw296xCaN6Q@mail.gmail.com \
    --to=xiyou.wangcong@gmail.com \
    --cc=cake@lists.bufferbloat.net \
    --cc=netdev@vger.kernel.org \
    --cc=toke@redhat.com \
    --cc=toke@toke.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox