From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <xiyou.wangcong@gmail.com>
Received: from mail-pf1-x442.google.com (mail-pf1-x442.google.com
 [IPv6:2607:f8b0:4864:20::442])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by lists.bufferbloat.net (Postfix) with ESMTPS id B64DD3B29E
 for <cake@lists.bufferbloat.net>; Tue,  8 Jan 2019 20:39:07 -0500 (EST)
Received: by mail-pf1-x442.google.com with SMTP id g62so2805502pfd.12
 for <cake@lists.bufferbloat.net>; Tue, 08 Jan 2019 17:39:07 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=mime-version:references:in-reply-to:from:date:message-id:subject:to
 :cc:content-transfer-encoding;
 bh=xUruead+JuPC4cTWANaq7X2jIl3PDM0JzlrAX4ehWH8=;
 b=RzIQiMIxJxTt+WuMgz/HPh9+xHfcdBN+pLXRwxY1diX0UC62LMteNOz5l56KwU/rMv
 fsYsLDiH1vhhtt/k/seDS4pFx15geu6qOdVKEmfZOoB248n5wg0e2A0lW3jYmzjfV3QW
 v+v/RlfJcVZPPDkkxcwNliwyAe2YK6HipItjlWoobxsyaaLP5N5ihsFUWMRFxhSHrmiJ
 rdJjq+bxqiwmBfJucWgU7mgQ9NsmwIHn2Jb/+9VptH9XjSZdzzVgx7mPeXO1zssEI7O1
 S0h6m0724Snd/aafMlTisITh5B5d3SAU4JB1lBAThEo71fcZP/ZPnF6Pc+3ms8jENKVt
 oIqg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc:content-transfer-encoding;
 bh=xUruead+JuPC4cTWANaq7X2jIl3PDM0JzlrAX4ehWH8=;
 b=d4PQJVC5PpRO4ROTVZ6sKmIP/zwz0qeZQvGLHAk+CDuB4EcIswZy384Bj9SCr15ORv
 DiQuLGx0q7tfmKhtMQw6vPnebmZ5FtJ0mqkpx2LHL2NRtVSfGI/QgiYdZBqxB2i3LZu9
 YJIRBoVdTG78/vz3JOd6zKJ7FZRdSi7a6rPeb/ESBDpT5KdwOGsJ7KMEExOSDgdnDh3f
 pjSmMBW5cv9uX0JDf6cspcn6zYiQ99GnnWe6A2uZpnt/h8thLxbvURcSEfIaEIhHRJ4T
 nWuAoanJS6N6QO+tLMsIDdzELgiYmA+ebU5NWNLM3NEyNSFkpQgpD8aNZ0XcKQq8ZFOd
 qzpw==
X-Gm-Message-State: AJcUukeZ+Be3SKpj5v6VgDtNSPB/2XZp+CMjwWBB+TpSg3Y0MewNboWg
 U+hVf1o2knrpet6KVK5bY3KtX8wWqqu3gHJiBfA=
X-Google-Smtp-Source: ALg8bN72E25ai3kUkR+l4KZW7Rp5DmB+OjVjA8L33xUG7bxoJLJL/EY/k6580D5IKmpNbUpE+F3qgfBjchH+suwkhX0=
X-Received: by 2002:a62:870e:: with SMTP id i14mr4123375pfe.41.1546997946726; 
 Tue, 08 Jan 2019 17:39:06 -0800 (PST)
MIME-Version: 1.0
References: <20190107194733.31138-1-toke@toke.dk>
 <20190107194733.31138-2-toke@toke.dk>
In-Reply-To: <20190107194733.31138-2-toke@toke.dk>
From: Cong Wang <xiyou.wangcong@gmail.com>
Date: Tue, 8 Jan 2019 17:38:55 -0800
Message-ID: <CAM_iQpVcw3+Crg_1vR4sPfG2v+arQVMY2yzBjp7yw296xCaN6Q@mail.gmail.com>
To: =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= <toke@toke.dk>
Cc: Linux Kernel Network Developers <netdev@vger.kernel.org>,
 Cake List <cake@lists.bufferbloat.net>, 
 =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= <toke@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Mailman-Approved-At: Wed, 09 Jan 2019 03:37:05 -0500
Subject: Re: [Cake] [PATCH 1/4] sched: Avoid dereferencing skb pointer after
	child enqueue
X-BeenThere: cake@lists.bufferbloat.net
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: Cake - FQ_codel the next generation <cake.lists.bufferbloat.net>
List-Unsubscribe: <https://lists.bufferbloat.net/options/cake>,
 <mailto:cake-request@lists.bufferbloat.net?subject=unsubscribe>
List-Archive: <https://lists.bufferbloat.net/pipermail/cake>
List-Post: <mailto:cake@lists.bufferbloat.net>
List-Help: <mailto:cake-request@lists.bufferbloat.net?subject=help>
List-Subscribe: <https://lists.bufferbloat.net/listinfo/cake>,
 <mailto:cake-request@lists.bufferbloat.net?subject=subscribe>
X-List-Received-Date: Wed, 09 Jan 2019 01:39:07 -0000

On Mon, Jan 7, 2019 at 11:50 AM Toke H=C3=B8iland-J=C3=B8rgensen <toke@toke=
.dk> wrote:
> @@ -1254,7 +1256,7 @@ static int qfq_enqueue(struct sk_buff *skb, struct =
Qdisc *sch,
>         if (cl->qdisc->q.qlen !=3D 1) {
>                 if (unlikely(skb =3D=3D cl->qdisc->ops->peek(cl->qdisc)) =
&&


Isn't this comparison problematic too? While you are on it...