From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <xiyou.wangcong@gmail.com>
Received: from mail-pg0-x244.google.com (mail-pg0-x244.google.com
 [IPv6:2607:f8b0:400e:c05::244])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by lists.bufferbloat.net (Postfix) with ESMTPS id AEB853CB39
 for <cake@lists.bufferbloat.net>; Wed, 16 May 2018 17:09:21 -0400 (EDT)
Received: by mail-pg0-x244.google.com with SMTP id k2-v6so835424pgc.1
 for <cake@lists.bufferbloat.net>; Wed, 16 May 2018 14:09:21 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=mime-version:in-reply-to:references:from:date:message-id:subject:to
 :cc:content-transfer-encoding;
 bh=4ENlNLvKfi+LjrvuS8IgdyXCFYZhsFWoMa84PMiUbNw=;
 b=W5u1FRbfzrntsSGFnsZMNJn2ImuQmPYp5tFxXq5APZSmO8L2+JOaYGzv+cje/skHc+
 kdY1nMCm0f9kkipjFXoytZt+fj7U1o3w4VGOVSLQOr+fQtwUW0Oljd+ETgZGjEWLgHq+
 g82020AjghV3c0tuIQ27xb8zBZhJlhalKWUHuveqp0QTOkTxE3/xYGaGspgssnFPk9Sx
 Lo/2cbg6ZQS6fQPCL+bSyuK3xd+9ECBkQZtboMQ23OyNiyTh+jKc7ZRPkiyR4BEMTyaF
 3jgnHsqM5SWLuE+eqJiTaAIdqFC8MZykfbuYBeBmqajhsFFyiUWqjf2ugRbONg6HUwK6
 kuRw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:in-reply-to:references:from:date
 :message-id:subject:to:cc:content-transfer-encoding;
 bh=4ENlNLvKfi+LjrvuS8IgdyXCFYZhsFWoMa84PMiUbNw=;
 b=j4f7bDusCh7++w3S88Y0SvW8aN7lYnGRNdV9j42xwKlAlQuPLb/9fkb6lJsZWEoQnT
 aV3K2xVS2utGb/RGdXpW9+QAquqZJ0ARhTKZovSM92m5FhYWhBeNDrU2uEFUXhSCrUHK
 6erMkmFtnNABYJs2PE/12KbjTWZxhMM71e1QMm2TTc9cHF+w3J9qYAdRhrSp5KmFfHEt
 NLGxZPToxgBBpWAdfN3rH9KBpK1kddMAZijZJVktoXGF8lbUlCghJdohBtdcO3m/OM8c
 XSIBhaf17WbZvdoydR1hRldnwgXQe3lnlWHkSrWxhRX1woU5ujGvMiXhGms5ypGwq3r1
 gRmA==
X-Gm-Message-State: ALKqPwelm2J5iHQ+x/H8mMoT3yUwa6FkptvRpJKQEMQiA6h4w1qqvzC3
 GN1OvmUBbUPVG9JtIluuEPajK0diSVrRUyN8LhE=
X-Google-Smtp-Source: AB8JxZr2BVuFMkTOK5jJmy1wNn7TwVWfI9J0LgWwMrQdvmjHL0kp6EfBSPbT/Zk2N8T8joVPrZ8Fs+FUlLFya52BWPM=
X-Received: by 2002:a63:6f89:: with SMTP id
 k131-v6mr1959412pgc.237.1526504960957; 
 Wed, 16 May 2018 14:09:20 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.236.179.152 with HTTP; Wed, 16 May 2018 14:09:00 -0700 (PDT)
In-Reply-To: <152650254608.25701.5749607607862123240.stgit@alrua-kau>
References: <152650253056.25701.10138252969621361651.stgit@alrua-kau>
 <152650254608.25701.5749607607862123240.stgit@alrua-kau>
From: Cong Wang <xiyou.wangcong@gmail.com>
Date: Wed, 16 May 2018 14:09:00 -0700
Message-ID: <CAM_iQpVz9bRDkW_cqj-vo6fapXaG6zV-bWM0Sc2wmHuj-vzWqg@mail.gmail.com>
To: =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= <toke@toke.dk>
Cc: Linux Kernel Network Developers <netdev@vger.kernel.org>,
 Cake List <cake@lists.bufferbloat.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Mailman-Approved-At: Wed, 16 May 2018 17:14:25 -0400
Subject: Re: [Cake] [PATCH net-next v12 2/7] sch_cake: Add ingress mode
X-BeenThere: cake@lists.bufferbloat.net
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: Cake - FQ_codel the next generation <cake.lists.bufferbloat.net>
List-Unsubscribe: <https://lists.bufferbloat.net/options/cake>,
 <mailto:cake-request@lists.bufferbloat.net?subject=unsubscribe>
List-Archive: <https://lists.bufferbloat.net/pipermail/cake>
List-Post: <mailto:cake@lists.bufferbloat.net>
List-Help: <mailto:cake-request@lists.bufferbloat.net?subject=help>
List-Subscribe: <https://lists.bufferbloat.net/listinfo/cake>,
 <mailto:cake-request@lists.bufferbloat.net?subject=subscribe>
X-List-Received-Date: Wed, 16 May 2018 21:09:21 -0000

On Wed, May 16, 2018 at 1:29 PM, Toke H=C3=B8iland-J=C3=B8rgensen <toke@tok=
e.dk> wrote:
> +       if (tb[TCA_CAKE_AUTORATE]) {
> +               if (!!nla_get_u32(tb[TCA_CAKE_AUTORATE]))
> +                       q->rate_flags |=3D CAKE_FLAG_AUTORATE_INGRESS;
> +               else
> +                       q->rate_flags &=3D ~CAKE_FLAG_AUTORATE_INGRESS;
> +       }
> +
> +       if (tb[TCA_CAKE_INGRESS]) {
> +               if (!!nla_get_u32(tb[TCA_CAKE_INGRESS]))
> +                       q->rate_flags |=3D CAKE_FLAG_INGRESS;
> +               else
> +                       q->rate_flags &=3D ~CAKE_FLAG_INGRESS;
> +       }
> +
>         if (tb[TCA_CAKE_MEMORY])
>                 q->buffer_config_limit =3D nla_get_u32(tb[TCA_CAKE_MEMORY=
]);
>
> @@ -1559,6 +1628,14 @@ static int cake_dump(struct Qdisc *sch, struct sk_=
buff *skb)
>         if (nla_put_u32(skb, TCA_CAKE_MEMORY, q->buffer_config_limit))
>                 goto nla_put_failure;
>
> +       if (nla_put_u32(skb, TCA_CAKE_AUTORATE,
> +                       !!(q->rate_flags & CAKE_FLAG_AUTORATE_INGRESS)))
> +               goto nla_put_failure;
> +
> +       if (nla_put_u32(skb, TCA_CAKE_INGRESS,
> +                       !!(q->rate_flags & CAKE_FLAG_INGRESS)))
> +               goto nla_put_failure;
> +

Why do you want to dump each bit of the rate_flags separately rather than
dumping the whole rate_flags as an integer?