From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <xiyou.wangcong@gmail.com>
Received: from mail-pg0-x244.google.com (mail-pg0-x244.google.com
 [IPv6:2607:f8b0:400e:c05::244])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by lists.bufferbloat.net (Postfix) with ESMTPS id B8F8D3B29E
 for <cake@lists.bufferbloat.net>; Wed, 16 May 2018 16:45:19 -0400 (EDT)
Received: by mail-pg0-x244.google.com with SMTP id c22-v6so124092pgn.11
 for <cake@lists.bufferbloat.net>; Wed, 16 May 2018 13:45:19 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=mime-version:in-reply-to:references:from:date:message-id:subject:to
 :cc:content-transfer-encoding;
 bh=wKs1CSSeMbIkwW/Hy0z8itGnaaqH3WUMRqt8qjgNxtg=;
 b=cvO4MOrbHw5NmNPe4k+rQQuIZlk3olarjNwi0KpYHnZ+c0ckxAXIUu+PqwVTXjVtof
 auoJplwqht3uQR27RHLsZGBrMmCa/FYH6AhuLXxtmLA+aGRka21PmBr6GQXC6WPiFWac
 SRyb8t6DTGn25Cp25RihRXYCEphCT+35ZDm7+BJQkO2NbA8GYUZ/K1FJXpLqh/f8zyLm
 EmC/h0ZHoSU+sdAhyfRpTYMvNJYBOv0vBUXRzL3d3Vx4t1m70klhZT2rWW45/PpXHAHR
 CsExb04TMTb1r2JOJ0qfrozrV2QBnwVNpjhRhqW5ZnYsI18M0cv6rz5tzi7Eld9rVrYJ
 SbeA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:in-reply-to:references:from:date
 :message-id:subject:to:cc:content-transfer-encoding;
 bh=wKs1CSSeMbIkwW/Hy0z8itGnaaqH3WUMRqt8qjgNxtg=;
 b=s/eUVUNCUXmw4SzDmMjvofhoMLRk+ahbAmiSrtFlTopJzp3FZ0ywX1O1wRMq63wTbo
 Uwqf5BC/VJajs9yxocwA0PWwcvai29vy/wx0RVrz0p0gpmY3tGJPhoGy1tTlN1lbge1y
 McZNIa7qxmQIY7gx7QbU+cX5PzdPKZVRas/IEkz8kW0pzz6AO/Tc/u9sV22hgzTXUWHw
 Hv554IbgkgIvr/854GWbK8Rss8ZuLpgvKBE6giky2xGX6pGhNE44YC3tP++LeDX8lAIb
 EvvxUgvttJrD2378BxOo/UlX7/kXl5Zq/K92BUyR6e/bFFzaH/32b3PjAqi8mBXV4XKT
 /1Yw==
X-Gm-Message-State: ALKqPwfNf3iWMDBXMspZIBiY0Ty4godc1CIQo8JHDjgqLgbAnGsvhtbk
 ugt6E3mb8klusWycEUmVdbvdFGnmvSwPMIpMAYc=
X-Google-Smtp-Source: AB8JxZr3SWBM9/iIevYzbhod4ExBN7nvLH+JuECKoIDH8EcjVBpLjPHa6JEqxymPlDVwZByAEOGSaZYwch5CwQseNsQ=
X-Received: by 2002:a62:9696:: with SMTP id
 s22-v6mr2422219pfk.191.1526503518999; 
 Wed, 16 May 2018 13:45:18 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.236.179.152 with HTTP; Wed, 16 May 2018 13:44:58 -0700 (PDT)
In-Reply-To: <152650254604.25701.14673720046190425630.stgit@alrua-kau>
References: <152650253056.25701.10138252969621361651.stgit@alrua-kau>
 <152650254604.25701.14673720046190425630.stgit@alrua-kau>
From: Cong Wang <xiyou.wangcong@gmail.com>
Date: Wed, 16 May 2018 13:44:58 -0700
Message-ID: <CAM_iQpX0mfKJWjDE_2ofKftcr2KgaOkinm70-CdNtNSBj8_cJQ@mail.gmail.com>
To: =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= <toke@toke.dk>
Cc: Linux Kernel Network Developers <netdev@vger.kernel.org>,
 Cake List <cake@lists.bufferbloat.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Mailman-Approved-At: Wed, 16 May 2018 16:53:04 -0400
Subject: Re: [Cake] [PATCH net-next v12 1/7] sched: Add Common Applications
 Kept Enhanced (cake) qdisc
X-BeenThere: cake@lists.bufferbloat.net
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: Cake - FQ_codel the next generation <cake.lists.bufferbloat.net>
List-Unsubscribe: <https://lists.bufferbloat.net/options/cake>,
 <mailto:cake-request@lists.bufferbloat.net?subject=unsubscribe>
List-Archive: <https://lists.bufferbloat.net/pipermail/cake>
List-Post: <mailto:cake@lists.bufferbloat.net>
List-Help: <mailto:cake-request@lists.bufferbloat.net?subject=help>
List-Subscribe: <https://lists.bufferbloat.net/listinfo/cake>,
 <mailto:cake-request@lists.bufferbloat.net?subject=subscribe>
X-List-Received-Date: Wed, 16 May 2018 20:45:20 -0000

On Wed, May 16, 2018 at 1:29 PM, Toke H=C3=B8iland-J=C3=B8rgensen <toke@tok=
e.dk> wrote:
> +
> +static struct Qdisc *cake_leaf(struct Qdisc *sch, unsigned long arg)
> +{
> +       return NULL;
> +}
> +
> +static unsigned long cake_find(struct Qdisc *sch, u32 classid)
> +{
> +       return 0;
> +}
> +
> +static void cake_walk(struct Qdisc *sch, struct qdisc_walker *arg)
> +{
> +}


Thanks for adding the support to other TC filters, it is much better now!

A quick question: why class_ops->dump_stats is still NULL?

It is supposed to dump the stats of each flow. Is there still any difficult=
y
to map it to tc class? I thought you figured it out when you added the
tcf_classify().