Re: [Cake] Hopefully fixed ACK filter for v6

[Ryan Mounce <ryan@mounce.com.au>]

On 29 April 2018 at 07:19, Toke Høiland-Jørgensen <toke@toke.dk> wrote:
> Think I finally managed to fix the ACK filter so it works for both 6in4
> and regular v6 (the latter seems to have been broken since the commit
> "e6b72c2 ack_filter: make less aggressive by default" which accidentally
> reversed the address compare logic). It should also be safe against
> weirdly fragmented packets (ha! famous last words!).
>
> If someone wants to either eyeball the code and/or test the ACK filter
> please do. I'm planning to resubmit the patch to netdev sometime
> tomorrow evening :)

Eyeballing now, only a couple of comments.

- Initialisation of iph and ipv6h can be moved before the while()
loop. The compiler probably does this anyway.
- Whether it is worth the complexity of restoring the
skb->encapsulation check within cake_get_tcphdr to handle other cases
of encapsulated v4/v6 traffic. I may find some time to test this later
today.

Everything else looks good to me, much cleaner.

Thank you so much for your efforts so far in getting cake upstream,
and in particular to rescue ACK filtering. We may have to send you a
real cake!

Ryan

>
> -Toke
> _______________________________________________
> Cake mailing list
> Cake@lists.bufferbloat.net
> https://lists.bufferbloat.net/listinfo/cake