From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-x22d.google.com (mail-pg0-x22d.google.com [IPv6:2607:f8b0:400e:c05::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id AFBDA3BA8E for ; Sat, 28 Apr 2018 21:02:11 -0400 (EDT) Received: by mail-pg0-x22d.google.com with SMTP id p10-v6so4053399pgn.1 for ; Sat, 28 Apr 2018 18:02:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mounce.com.au; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=rnCGh9/+8FuCWcKeEkaGUo5VmzciRiL8MKaQykrsHBQ=; b=OBtvtRL54vuFPJM2A657JKWzMKjMt4VRvF7ugRYbMJkhKdoreMCu0HhQqvkQwsA6MR nxiUjU37oH4dYmbfZhIEuwRdqkNbj59JjqkELduX9O6HodvN+Ln6MbArBhUhW8S/W2JS hr+UROD8O1MCSdNgChF7VO1hpeSYShXCFVaitbfrh9G4jp/Et+aSbcByFymc4svgdPWf yYchFsYT3N7oaCySaOBS6i2Eq1O2/ioRTt26LKXHwpoEmO1XJvleeOQg0EkdiINCUCjE Td0OGqaRd6fA4kstARcOHIhSf24fWCfn0deKtjfvxs0drSIEUzl+dAO1Fxo92xylMzsE Ubdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=rnCGh9/+8FuCWcKeEkaGUo5VmzciRiL8MKaQykrsHBQ=; b=mfvefRBeNL8JtFr1GVkWYxLH5BSIu1fFw51qe1ukzyUtF3L9Am5JMav4Rikh27jpxf cxT13ylIGDVIL6dOmY32bZHAH41Q+PEM3pM7Mq7hRrlJtOCI44yFVtTrXMIRCA6JjdiK x9Tiz786YvBK7kMgI+dzLjm6reCfZTl0vFjof/+HymjKRQJ+eVxNdGT1oCyXBiK3mhdU ke5elvKaoahoZdiu6OaOB7l/UWjdaC0LGGl/IXGlQWdDznLSvqgh1QkyeenquCcmPQqr gv1z2dsI/rmgHN7Cbh6qgqCsikuW1NLkOut6ShQCWsz3Vf79NJkke2KTWtfDmOs9h93D 5s+w== X-Gm-Message-State: ALQs6tDJHRxgXe/oQZJOBYCVB5KT1lLVHK8RY3N31Q0Is2PmJBL/ovCQ Ssl88jEgE69Rm0pxmJZ7OJQcUlQnRJ5uXoV4Y8dzHLMbKE0= X-Google-Smtp-Source: AB8JxZoxpKcE3PUhhoJpsa6USWI2aSxbEZLQmib6hkeGTCnHHNlp5GsRJv0ht6b58NhRHZgdfQd199K0d5lJPLHnwm4= X-Received: by 10.98.160.150 with SMTP id p22mr7334859pfl.9.1524963730467; Sat, 28 Apr 2018 18:02:10 -0700 (PDT) MIME-Version: 1.0 Received: by 10.236.155.194 with HTTP; Sat, 28 Apr 2018 18:01:55 -0700 (PDT) X-Originating-IP: [45.118.67.18] In-Reply-To: <87wowr2e8t.fsf@toke.dk> References: <87wowr2e8t.fsf@toke.dk> From: Ryan Mounce Date: Sun, 29 Apr 2018 10:31:55 +0930 Message-ID: To: =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= Cc: Cake List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [Cake] Hopefully fixed ACK filter for v6 X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Apr 2018 01:02:11 -0000 On 29 April 2018 at 07:19, Toke H=C3=B8iland-J=C3=B8rgensen = wrote: > Think I finally managed to fix the ACK filter so it works for both 6in4 > and regular v6 (the latter seems to have been broken since the commit > "e6b72c2 ack_filter: make less aggressive by default" which accidentally > reversed the address compare logic). It should also be safe against > weirdly fragmented packets (ha! famous last words!). > > If someone wants to either eyeball the code and/or test the ACK filter > please do. I'm planning to resubmit the patch to netdev sometime > tomorrow evening :) Eyeballing now, only a couple of comments. - Initialisation of iph and ipv6h can be moved before the while() loop. The compiler probably does this anyway. - Whether it is worth the complexity of restoring the skb->encapsulation check within cake_get_tcphdr to handle other cases of encapsulated v4/v6 traffic. I may find some time to test this later today. Everything else looks good to me, much cleaner. Thank you so much for your efforts so far in getting cake upstream, and in particular to rescue ACK filtering. We may have to send you a real cake! Ryan > > -Toke > _______________________________________________ > Cake mailing list > Cake@lists.bufferbloat.net > https://lists.bufferbloat.net/listinfo/cake